mbox series

[v2,0/2] Fix PSIHB interrupts init PQ state

Message ID 20230703081215.55252-1-fbarrat@linux.ibm.com (mailing list archive)
Headers show
Series Fix PSIHB interrupts init PQ state | expand

Message

Frederic Barrat July 3, 2023, 8:12 a.m. UTC
On P9 and 10, the real hardware defines the PQ state of the PSIHB
interrupts to be 0b00. Qemu defaults to 0b01.

It doesn't matter to skiboot, which doesn't rely on it and explicitly
masks the interrupts during intialization. But this patch fixes it,
just in case some other hypervisor checks it.

Changelog:
v2: rename property/struct member
    rebase to Daniel's ppc-next branch


Frederic Barrat (2):
  pnv/xive: Add property on xive sources to define PQ state on reset
  pnv/psi: Initialize the PSIHB interrupts to match hardware

 hw/intc/xive.c        | 8 ++++++--
 hw/ppc/pnv_psi.c      | 2 ++
 include/hw/ppc/xive.h | 1 +
 3 files changed, 9 insertions(+), 2 deletions(-)

Comments

Philippe Mathieu-Daudé July 3, 2023, 9:50 a.m. UTC | #1
On 3/7/23 10:12, Frederic Barrat wrote:

> Frederic Barrat (2):
>    pnv/xive: Add property on xive sources to define PQ state on reset
>    pnv/psi: Initialize the PSIHB interrupts to match hardware

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Daniel Henrique Barboza July 3, 2023, 1:50 p.m. UTC | #2
Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks,


Daniel

On 7/3/23 05:12, Frederic Barrat wrote:
> On P9 and 10, the real hardware defines the PQ state of the PSIHB
> interrupts to be 0b00. Qemu defaults to 0b01.
> 
> It doesn't matter to skiboot, which doesn't rely on it and explicitly
> masks the interrupts during intialization. But this patch fixes it,
> just in case some other hypervisor checks it.
> 
> Changelog:
> v2: rename property/struct member
>      rebase to Daniel's ppc-next branch
> 
> 
> Frederic Barrat (2):
>    pnv/xive: Add property on xive sources to define PQ state on reset
>    pnv/psi: Initialize the PSIHB interrupts to match hardware
> 
>   hw/intc/xive.c        | 8 ++++++--
>   hw/ppc/pnv_psi.c      | 2 ++
>   include/hw/ppc/xive.h | 1 +
>   3 files changed, 9 insertions(+), 2 deletions(-)
>