mbox series

[v7,0/3] shmemfs stable directory offsets

Message ID 168814723481.530310.17776748558242063239.stgit@manet.1015granger.net (mailing list archive)
Headers show
Series shmemfs stable directory offsets | expand

Message

Chuck Lever June 30, 2023, 5:48 p.m. UTC
The following series implements stable directory offsets for
shmemfs/tmpfs and provides infrastructure for use by other file
systems that are based on simplefs.


Changes since v6:
- Add appropriate documentation

Changes since v5:
- Rename functions and structures

Changes since v4:
- Remove new fields from struct inode/dentry
- Remove EXPORT_SYMBOL and extern for new functions
- Try again to fix error handling for rename_exchange

Changes since v3:
- Rebased on v6.4
- Fixed error handling bugs

Changes since v2:
- Move bulk of stable offset support into fs/libfs.c
- Replace xa_find_after with xas_find_next for efficiency

Changes since v1:
- Break the single patch up into a series

Changes since RFC:
- Destroy xarray in shmem_destroy_inode() instead of free_in_core_inode()
- A few cosmetic updates

---

Chuck Lever (3):
      libfs: Add directory operations for stable offsets
      shmem: Refactor shmem_symlink()
      shmem: stable directory offsets


 Documentation/filesystems/locking.rst |   2 +
 Documentation/filesystems/vfs.rst     |   6 +-
 fs/libfs.c                            | 247 ++++++++++++++++++++++++++
 include/linux/fs.h                    |  18 ++
 include/linux/shmem_fs.h              |   1 +
 mm/shmem.c                            |  62 +++++--
 6 files changed, 320 insertions(+), 16 deletions(-)

--
Chuck Lever

Comments

Christian Brauner July 3, 2023, 3:23 p.m. UTC | #1
On Fri, 30 Jun 2023 13:48:43 -0400, Chuck Lever wrote:
> The following series implements stable directory offsets for
> shmemfs/tmpfs and provides infrastructure for use by other file
> systems that are based on simplefs.
> 
> 
> Changes since v6:
> - Add appropriate documentation
> 
> [...]

I've folded in the mentioned changes to make offset types consistent.
Thanks for adding documentation for the new i_op.

---

Applied to the vfs.readdir branch of the vfs/vfs.git tree.
Patches in the vfs.readdir branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.readdir

[1/3] libfs: Add directory operations for stable offsets
      https://git.kernel.org/vfs/vfs/c/7a3472ae9614
[2/3] shmem: Refactor shmem_symlink()
      https://git.kernel.org/vfs/vfs/c/0462391d6d03
[3/3] shmem: stable directory offsets
      https://git.kernel.org/vfs/vfs/c/ddb7bcf8430a