| Message ID | 20230705190309.579783-9-jlayton@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
On Wed 05-07-23 15:00:36, Jeff Layton wrote: > A rename potentially involves updating 4 different inode timestamps. > Convert to the new simple_rename_timestamp helper function. > > Signed-off-by: Jeff Layton <jlayton@kernel.org> Looks good to me. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > mm/shmem.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index 0f45e72a5ca7..1693134959c5 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -3306,9 +3306,7 @@ static int shmem_rename2(struct mnt_idmap *idmap, > > old_dir->i_size -= BOGO_DIRENT_SIZE; > new_dir->i_size += BOGO_DIRENT_SIZE; > - old_dir->i_ctime = old_dir->i_mtime = > - new_dir->i_ctime = new_dir->i_mtime = > - inode->i_ctime = current_time(old_dir); > + simple_rename_timestamp(old_dir, old_dentry, new_dir, new_dentry); > inode_inc_iversion(old_dir); > inode_inc_iversion(new_dir); > return 0; > -- > 2.41.0 >
diff --git a/mm/shmem.c b/mm/shmem.c index 0f45e72a5ca7..1693134959c5 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -3306,9 +3306,7 @@ static int shmem_rename2(struct mnt_idmap *idmap, old_dir->i_size -= BOGO_DIRENT_SIZE; new_dir->i_size += BOGO_DIRENT_SIZE; - old_dir->i_ctime = old_dir->i_mtime = - new_dir->i_ctime = new_dir->i_mtime = - inode->i_ctime = current_time(old_dir); + simple_rename_timestamp(old_dir, old_dentry, new_dir, new_dentry); inode_inc_iversion(old_dir); inode_inc_iversion(new_dir); return 0;
A rename potentially involves updating 4 different inode timestamps. Convert to the new simple_rename_timestamp helper function. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- mm/shmem.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)