[v2,3/4] sysfb: Do not include <linux/screen_info.h> from sysfb header

Commit Message

Thomas Zimmermann July 6, 2023, 10:42 a.m. UTC

The header file <linux/sysfb.h> does not need anything from
<linux/screen_info.h>. Declare struct screen_info and remove
the include statements.

Signed-off-by: Thomas Zimmermann <[e-mail]>
Reviewed-by: Javier Martinez Canillas <[e-mail]>
Reviewed-by: Sui Jingfeng <[e-mail]>
Cc: Ard Biesheuvel <[e-mail]>
Cc: Hans de Goede <[e-mail]>
Cc: Javier Martinez Canillas <[e-mail]>
---
 include/linux/sysfb.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Arnd Bergmann July 6, 2023, 11:38 a.m. UTC | #1

On Thu, Jul 6, 2023, at 12:42, Thomas Zimmermann wrote:
> The header file <linux/sysfb.h> does not need anything from
> <linux/screen_info.h>. Declare struct screen_info and remove
> the include statements.
>
> Signed-off-by: Thomas Zimmermann <[e-mail]>
> Reviewed-by: Javier Martinez Canillas <[e-mail]>
> Reviewed-by: Sui Jingfeng <[e-mail]>
> Cc: Ard Biesheuvel <[e-mail]>
> Cc: Hans de Goede <[e-mail]>
> Cc: Javier Martinez Canillas <[e-mail]>

Reviewed-by: Arnd Bergmann <[e-mail]>

Patch

diff --git a/include/linux/sysfb.h b/include/linux/sysfb.h
index c1ef5fc60a3c..19cb803dd5ec 100644
--- a/include/linux/sysfb.h
+++ b/include/linux/sysfb.h
@@ -9,7 +9,8 @@ 
 
 #include <linux/kernel.h>
 #include <linux/platform_data/simplefb.h>
-#include <linux/screen_info.h>
+
+struct screen_info;
 
 enum {
 	M_I17,		/* 17-Inch iMac */