| Message ID | 20230706151432.20674-2-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | fbdev: Generate deferred-I/O helpers | expand |
On 7/6/23 17:08, Thomas Zimmermann wrote: > The Kconfig token FB_SYS_HELPERS_DEFERRED selects everything that > is required for deferred I/O on system-memory framebuffers. Select > it from FB_BROADSHEET in favor of the existing identical selection. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> I'm actually not a fan of deferred-IO for older drivers, but in this case where the drivers operate on system memory anyway, this is the right approach. The series looks good: Acked-by: Helge Deller <deller@gmx.de> Helge > --- > drivers/video/fbdev/Kconfig | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > index f14229757311..fd862faafe66 100644 > --- a/drivers/video/fbdev/Kconfig > +++ b/drivers/video/fbdev/Kconfig > @@ -2179,11 +2179,7 @@ config FB_MX3 > config FB_BROADSHEET > tristate "E-Ink Broadsheet/Epson S1D13521 controller support" > depends on FB && (ARCH_PXA || COMPILE_TEST) > - select FB_SYS_FILLRECT > - select FB_SYS_COPYAREA > - select FB_SYS_IMAGEBLIT > - select FB_SYS_FOPS > - select FB_DEFERRED_IO > + select FB_SYS_HELPERS_DEFERRED > help > This driver implements support for the E-Ink Broadsheet > controller. The release name for this device was Epson S1D13521
Hi Am 06.07.23 um 21:13 schrieb Helge Deller: > On 7/6/23 17:08, Thomas Zimmermann wrote: >> The Kconfig token FB_SYS_HELPERS_DEFERRED selects everything that >> is required for deferred I/O on system-memory framebuffers. Select >> it from FB_BROADSHEET in favor of the existing identical selection. >> >> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > > I'm actually not a fan of deferred-IO for older drivers, but > in this case where the drivers operate on system memory anyway, > this is the right approach. Yeah, deferred I/O has a certain overhead. But for this kind of hardware there's no good way to make mmap work reliably without. (Well, there's msync(), but who uses that?) These drivers already implement defio, so it's not really a change, just a cleanup. > > The series looks good: > > Acked-by: Helge Deller <deller@gmx.de> Thanks a lot. Best regards Thomas > > Helge > >> --- >> drivers/video/fbdev/Kconfig | 6 +----- >> 1 file changed, 1 insertion(+), 5 deletions(-) >> >> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig >> index f14229757311..fd862faafe66 100644 >> --- a/drivers/video/fbdev/Kconfig >> +++ b/drivers/video/fbdev/Kconfig >> @@ -2179,11 +2179,7 @@ config FB_MX3 >> config FB_BROADSHEET >> tristate "E-Ink Broadsheet/Epson S1D13521 controller support" >> depends on FB && (ARCH_PXA || COMPILE_TEST) >> - select FB_SYS_FILLRECT >> - select FB_SYS_COPYAREA >> - select FB_SYS_IMAGEBLIT >> - select FB_SYS_FOPS >> - select FB_DEFERRED_IO >> + select FB_SYS_HELPERS_DEFERRED >> help >> This driver implements support for the E-Ink Broadsheet >> controller. The release name for this device was Epson S1D13521 >
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index f14229757311..fd862faafe66 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -2179,11 +2179,7 @@ config FB_MX3 config FB_BROADSHEET tristate "E-Ink Broadsheet/Epson S1D13521 controller support" depends on FB && (ARCH_PXA || COMPILE_TEST) - select FB_SYS_FILLRECT - select FB_SYS_COPYAREA - select FB_SYS_IMAGEBLIT - select FB_SYS_FOPS - select FB_DEFERRED_IO + select FB_SYS_HELPERS_DEFERRED help This driver implements support for the E-Ink Broadsheet controller. The release name for this device was Epson S1D13521
The Kconfig token FB_SYS_HELPERS_DEFERRED selects everything that is required for deferred I/O on system-memory framebuffers. Select it from FB_BROADSHEET in favor of the existing identical selection. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- drivers/video/fbdev/Kconfig | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)