| Message ID | 20230627050148.2045691-1-yangcong5@huaqin.corp-partner.google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] drm/panel: Fine tune Starry-ili9882t panel HFP and HBP | expand |
Hi, On Mon, Jun 26, 2023 at 10:01 PM Cong Yang <yangcong5@huaqin.corp-partner.google.com> wrote: > > Because the setting of hproch is too small, there will be warning in > kernel log[1]. After fine tune the HFP and HBP, this warning can be > solved. The actual measurement frame rate is 60.1Hz. > > [1]: WARNING kernel:[drm] HFP + HBP less than d-phy, FPS will under 60Hz Thanks for including the warming. This looks like something that's only printed on Mediatek display controllers. Just out of curiosity: is that because Mediatek controllers have special requirements, or is this something generic and the Mediatek controller is the only one that warns about it? > Fixes: 8716a6473e6c ("drm/panel: Support for Starry-ili9882t TDDI > MIPI-DSI panel") Ideally the tool you have to send mail wouldn't wrap the Fixes line. Probably not worth resending just for this, but see if there's something you can do to fix this in the future. Since this is a tiny fix, I don't think we need to wait too long. I'll plan to land it on Thursday unless Neil wants to land it himself sooner. Reviewed-by: Douglas Anderson <dianders@chromium.org>
Hi, Doug On Wed, Jun 28, 2023 at 5:17 AM Doug Anderson <dianders@google.com> wrote: > > Hi, > > On Mon, Jun 26, 2023 at 10:01 PM Cong Yang > <yangcong5@huaqin.corp-partner.google.com> wrote: > > > > Because the setting of hproch is too small, there will be warning in > > kernel log[1]. After fine tune the HFP and HBP, this warning can be > > solved. The actual measurement frame rate is 60.1Hz. > > > > [1]: WARNING kernel:[drm] HFP + HBP less than d-phy, FPS will under 60Hz > > Thanks for including the warming. This looks like something that's > only printed on Mediatek display controllers. Just out of curiosity: > is that because Mediatek controllers have special requirements, or is > this something generic and the Mediatek controller is the only one > that warns about it? It seems to be a generic calculation formula for MTK controllers. At least I have see this warning in both MT8186 and MT8188. By the way, the same warning will also appear under coreboot. > > > > Fixes: 8716a6473e6c ("drm/panel: Support for Starry-ili9882t TDDI > > MIPI-DSI panel") > > Ideally the tool you have to send mail wouldn't wrap the Fixes line. > Probably not worth resending just for this, but see if there's > something you can do to fix this in the future. > > Since this is a tiny fix, I don't think we need to wait too long. I'll > plan to land it on Thursday unless Neil wants to land it himself > sooner. Thank you, Doug. > > Reviewed-by: Douglas Anderson <dianders@chromium.org>
Hi, On Tue, Jun 27, 2023 at 2:17 PM Doug Anderson <dianders@google.com> wrote: > > Hi, > > On Mon, Jun 26, 2023 at 10:01 PM Cong Yang > <yangcong5@huaqin.corp-partner.google.com> wrote: > > > > Because the setting of hproch is too small, there will be warning in I realized that hproch should be hporch. I fixed when applying. > > kernel log[1]. After fine tune the HFP and HBP, this warning can be > > solved. The actual measurement frame rate is 60.1Hz. > > > > [1]: WARNING kernel:[drm] HFP + HBP less than d-phy, FPS will under 60Hz > > Thanks for including the warming. This looks like something that's > only printed on Mediatek display controllers. Just out of curiosity: > is that because Mediatek controllers have special requirements, or is > this something generic and the Mediatek controller is the only one > that warns about it? > > > > Fixes: 8716a6473e6c ("drm/panel: Support for Starry-ili9882t TDDI > > MIPI-DSI panel") > > Ideally the tool you have to send mail wouldn't wrap the Fixes line. > Probably not worth resending just for this, but see if there's > something you can do to fix this in the future. > > Since this is a tiny fix, I don't think we need to wait too long. I'll > plan to land it on Thursday unless Neil wants to land it himself > sooner. > > Reviewed-by: Douglas Anderson <dianders@chromium.org> OK, landed. This is a weird time to land since this is a fix and the fix has already made its way to Linus's tree but -rc1 isn't ready yet. From reading the flowchart in the committer guidelines: https://drm.pages.freedesktop.org/maintainer-tools/committer-drm-misc.html ...this means that it lands in drm-misc-next-fixes, so I've pushed it there. 59bba51ec2a5 drm/panel: Fine tune Starry-ili9882t panel HFP and HBP -Doug
On Fri, Jun 30, 2023 at 2:42 AM Doug Anderson <dianders@chromium.org> wrote: > ...this means that it lands in drm-misc-next-fixes, so I've pushed it there. > > 59bba51ec2a5 drm/panel: Fine tune Starry-ili9882t panel HFP and HBP I guess that means we need to merge drm-misc-next-fixes back to the drm-misc-next branch so that I can rebase my series breaking out the ili9882t driver to its own file? Yours, Linus Walleij
Hi, On Tue, Jul 4, 2023 at 12:39 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Fri, Jun 30, 2023 at 2:42 AM Doug Anderson <dianders@chromium.org> wrote: > > > ...this means that it lands in drm-misc-next-fixes, so I've pushed it there. > > > > 59bba51ec2a5 drm/panel: Fine tune Starry-ili9882t panel HFP and HBP > > I guess that means we need to merge drm-misc-next-fixes back to the > drm-misc-next branch so that I can rebase my series breaking out the > ili9882t driver to its own file? It looks like this fix is on its way to the main DRM tree: https://lore.kernel.org/r/20230706112203.GA30555@linux-uq9g Presumably if we wait a few days things will sort themselves out. If something needs to happen sooner then we'll have to get the drm-misc maintainers involved. Probably at this point it makes sense to wait? -Doug
On Thu, Jul 6, 2023 at 9:26 PM Doug Anderson <dianders@chromium.org> wrote: > Presumably if we wait a few days things will sort themselves out. If > something needs to happen sooner then we'll have to get the drm-misc > maintainers involved. Probably at this point it makes sense to wait? Yeah there is certainly no hurry :D Yours, Linus Walleij
diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c index 3cc9fb0d4f5d..dc276c346fd1 100644 --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c @@ -2139,9 +2139,9 @@ static const struct panel_desc starry_himax83102_j02_desc = { static const struct drm_display_mode starry_ili9882t_default_mode = { .clock = 165280, .hdisplay = 1200, - .hsync_start = 1200 + 32, - .hsync_end = 1200 + 32 + 30, - .htotal = 1200 + 32 + 30 + 32, + .hsync_start = 1200 + 72, + .hsync_end = 1200 + 72 + 30, + .htotal = 1200 + 72 + 30 + 72, .vdisplay = 1920, .vsync_start = 1920 + 68, .vsync_end = 1920 + 68 + 2,
Because the setting of hproch is too small, there will be warning in kernel log[1]. After fine tune the HFP and HBP, this warning can be solved. The actual measurement frame rate is 60.1Hz. [1]: WARNING kernel:[drm] HFP + HBP less than d-phy, FPS will under 60Hz Fixes: 8716a6473e6c ("drm/panel: Support for Starry-ili9882t TDDI MIPI-DSI panel") Signed-off-by: Cong Yang <yangcong5@huaqin.corp-partner.google.com> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> --- v2: - Update commit add Fixes tag --- drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)