| Message ID | 20230706044128.2726747-1-junfeng.guo@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0503efeadbf6bb8bf24397613a73b67e665eac5f |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] gve: Set default duplex configuration to full | expand |
On Thu, Jul 06, 2023 at 12:41:28PM +0800, Junfeng Guo wrote: > Current duplex mode was unset in the driver, resulting in the default > parameter being set to 0, which corresponds to half duplex. It might > mislead users to have incorrect expectation about the driver's > transmission capabilities. > Set the default duplex configuration to full, as the driver runs in > full duplex mode at this point. > > Fixes: 7e074d5a76ca ("gve: Enable Link Speed Reporting in the driver.") > Signed-off-by: Junfeng Guo <junfeng.guo@intel.com> > --- > drivers/net/ethernet/google/gve/gve_ethtool.c | 3 +++ > 1 file changed, 3 insertions(+) > Thanks, Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 6 Jul 2023 12:41:28 +0800 you wrote: > Current duplex mode was unset in the driver, resulting in the default > parameter being set to 0, which corresponds to half duplex. It might > mislead users to have incorrect expectation about the driver's > transmission capabilities. > Set the default duplex configuration to full, as the driver runs in > full duplex mode at this point. > > [...] Here is the summary with links: - [net] gve: Set default duplex configuration to full https://git.kernel.org/netdev/net/c/0503efeadbf6 You are awesome, thank you!
diff --git a/drivers/net/ethernet/google/gve/gve_ethtool.c b/drivers/net/ethernet/google/gve/gve_ethtool.c index cfd4b8d284d1..50162ec9424d 100644 --- a/drivers/net/ethernet/google/gve/gve_ethtool.c +++ b/drivers/net/ethernet/google/gve/gve_ethtool.c @@ -590,6 +590,9 @@ static int gve_get_link_ksettings(struct net_device *netdev, err = gve_adminq_report_link_speed(priv); cmd->base.speed = priv->link_speed; + + cmd->base.duplex = DUPLEX_FULL; + return err; }
Current duplex mode was unset in the driver, resulting in the default parameter being set to 0, which corresponds to half duplex. It might mislead users to have incorrect expectation about the driver's transmission capabilities. Set the default duplex configuration to full, as the driver runs in full duplex mode at this point. Fixes: 7e074d5a76ca ("gve: Enable Link Speed Reporting in the driver.") Signed-off-by: Junfeng Guo <junfeng.guo@intel.com> --- drivers/net/ethernet/google/gve/gve_ethtool.c | 3 +++ 1 file changed, 3 insertions(+)