| Message ID | 20230630160645.3984596-1-kherbst@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/nouveau/disp/g94: enable HDMI | expand |
Reviewed-by: Lyude Paul <lyude@redhat.com> But seeing as I looked at this + some other patches yesterday I assume there's still more to this? On Fri, 2023-06-30 at 18:06 +0200, Karol Herbst wrote: > Cc: Ben Skeggs <bskeggs@redhat.com> > Cc: Lyude Paul <lyude@redhat.com> > Fixes: f530bc60a30b ("drm/nouveau/disp: move HDMI config into acquire + infoframe methods") > Signed-off-by: Karol Herbst <kherbst@redhat.com> > --- > drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c > index a4853c4e5ee3..67ef889a0c5f 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c > +++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c > @@ -295,6 +295,7 @@ g94_sor = { > .clock = nv50_sor_clock, > .war_2 = g94_sor_war_2, > .war_3 = g94_sor_war_3, > + .hdmi = &g84_sor_hdmi, > .dp = &g94_sor_dp, > }; >
On Fri, Jul 7, 2023 at 11:03 PM Lyude Paul <lyude@redhat.com> wrote: > > Reviewed-by: Lyude Paul <lyude@redhat.com> > > But seeing as I looked at this + some other patches yesterday I assume there's > still more to this? > not really. All those patches are all independent and just a bunch of fixes. I just figured this one out a bit later. > On Fri, 2023-06-30 at 18:06 +0200, Karol Herbst wrote: > > Cc: Ben Skeggs <bskeggs@redhat.com> > > Cc: Lyude Paul <lyude@redhat.com> > > Fixes: f530bc60a30b ("drm/nouveau/disp: move HDMI config into acquire + infoframe methods") > > Signed-off-by: Karol Herbst <kherbst@redhat.com> > > --- > > drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c > > index a4853c4e5ee3..67ef889a0c5f 100644 > > --- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c > > +++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c > > @@ -295,6 +295,7 @@ g94_sor = { > > .clock = nv50_sor_clock, > > .war_2 = g94_sor_war_2, > > .war_3 = g94_sor_war_3, > > + .hdmi = &g84_sor_hdmi, > > .dp = &g94_sor_dp, > > }; > > > > -- > Cheers, > Lyude Paul (she/her) > Software Engineer at Red Hat >
Would a corresponding imperative description be helpful also for such a small change? See also: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n94 Regards, Markus
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c index a4853c4e5ee3..67ef889a0c5f 100644 --- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c +++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c @@ -295,6 +295,7 @@ g94_sor = { .clock = nv50_sor_clock, .war_2 = g94_sor_war_2, .war_3 = g94_sor_war_3, + .hdmi = &g84_sor_hdmi, .dp = &g94_sor_dp, };
Cc: Ben Skeggs <bskeggs@redhat.com> Cc: Lyude Paul <lyude@redhat.com> Fixes: f530bc60a30b ("drm/nouveau/disp: move HDMI config into acquire + infoframe methods") Signed-off-by: Karol Herbst <kherbst@redhat.com> --- drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c | 1 + 1 file changed, 1 insertion(+)