| Message ID | 20230705094655.44753-8-frank.li@vivo.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/8] fpga: bridge: Convert to devm_platform_ioremap_resource() | expand |
On 7/5/23 11:46, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li <frank.li@vivo.com> > --- > drivers/fpga/zynq-fpga.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c > index f8214cae9b6e..96611d424a10 100644 > --- a/drivers/fpga/zynq-fpga.c > +++ b/drivers/fpga/zynq-fpga.c > @@ -555,7 +555,6 @@ static int zynq_fpga_probe(struct platform_device *pdev) > struct device *dev = &pdev->dev; > struct zynq_fpga_priv *priv; > struct fpga_manager *mgr; > - struct resource *res; > int err; > > priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > @@ -563,8 +562,7 @@ static int zynq_fpga_probe(struct platform_device *pdev) > return -ENOMEM; > spin_lock_init(&priv->dma_lock); > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - priv->io_base = devm_ioremap_resource(dev, res); > + priv->io_base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(priv->io_base)) > return PTR_ERR(priv->io_base); > Acked-by: Michal Simek <michal.simek@amd.com> M
On 2023-07-07 at 06:55:49 +0200, Michal Simek wrote: > > > On 7/5/23 11:46, Yangtao Li wrote: > > Use devm_platform_ioremap_resource() to simplify code. > > > > Signed-off-by: Yangtao Li <frank.li@vivo.com> > > --- > > drivers/fpga/zynq-fpga.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c > > index f8214cae9b6e..96611d424a10 100644 > > --- a/drivers/fpga/zynq-fpga.c > > +++ b/drivers/fpga/zynq-fpga.c > > @@ -555,7 +555,6 @@ static int zynq_fpga_probe(struct platform_device *pdev) > > struct device *dev = &pdev->dev; > > struct zynq_fpga_priv *priv; > > struct fpga_manager *mgr; > > - struct resource *res; > > int err; > > priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > > @@ -563,8 +562,7 @@ static int zynq_fpga_probe(struct platform_device *pdev) > > return -ENOMEM; > > spin_lock_init(&priv->dma_lock); > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > - priv->io_base = devm_ioremap_resource(dev, res); > > + priv->io_base = devm_platform_ioremap_resource(pdev, 0); > > if (IS_ERR(priv->io_base)) > > return PTR_ERR(priv->io_base); > > Acked-by: Michal Simek <michal.simek@amd.com> Acked-by: Xu Yilun <yilun.xu@intel.com> Applied. > > M
diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c index f8214cae9b6e..96611d424a10 100644 --- a/drivers/fpga/zynq-fpga.c +++ b/drivers/fpga/zynq-fpga.c @@ -555,7 +555,6 @@ static int zynq_fpga_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct zynq_fpga_priv *priv; struct fpga_manager *mgr; - struct resource *res; int err; priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); @@ -563,8 +562,7 @@ static int zynq_fpga_probe(struct platform_device *pdev) return -ENOMEM; spin_lock_init(&priv->dma_lock); - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - priv->io_base = devm_ioremap_resource(dev, res); + priv->io_base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(priv->io_base)) return PTR_ERR(priv->io_base);
Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li <frank.li@vivo.com> --- drivers/fpga/zynq-fpga.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)