| Message ID | 20230710230546.3544912-1-arowa@google.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wifi: ath11k: Add crash logging | expand |
Arowa Suliman <arowa@chromium.org> writes: > Change crash logging from debug to informational and add warning when > firmware crash MHI_CB_EE_RDDM happens. Why? What's the reason why you want to change this? The commit log should always describe that. > Tested-on: Qualcomm WCN6855 This is not correct format: https://wireless.wiki.kernel.org/en/users/drivers/ath11k/submittingpatches#tested-on_tag > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202306141105.c1e82Q0y-lkp@intel.com/ The robot only reported problems with your patch, it didn't report the original problem. So you should remove these two lines. > Signed-off-by: Arowa Suliman <arowa@google.com> From and s-o-b have different email addresses. Also this seems to a second version of your patch so you should have marked it as v2 and include a changelog what changed from v1. Please read our documentation from the wiki link below how to submit patches.
diff --git a/drivers/net/wireless/ath/ath11k/mhi.c b/drivers/net/wireless/ath/ath11k/mhi.c index 3ac689f1def4..5db4b61c1cba 100644 --- a/drivers/net/wireless/ath/ath11k/mhi.c +++ b/drivers/net/wireless/ath/ath11k/mhi.c @@ -325,7 +325,7 @@ static void ath11k_mhi_op_status_cb(struct mhi_controller *mhi_cntrl, { struct ath11k_base *ab = dev_get_drvdata(mhi_cntrl->cntrl_dev); - ath11k_dbg(ab, ATH11K_DBG_BOOT, "notify status reason %s\n", + ath11k_info(ab, "notify status reason %s\n", ath11k_mhi_op_callback_to_str(cb)); switch (cb) { @@ -333,7 +333,8 @@ static void ath11k_mhi_op_status_cb(struct mhi_controller *mhi_cntrl, ath11k_warn(ab, "firmware crashed: MHI_CB_SYS_ERROR\n"); break; case MHI_CB_EE_RDDM: - if (!(test_bit(ATH11K_FLAG_UNREGISTERING, &ab->dev_flags))) + ath11k_warn(ab, "firmware crashed: MHI_CB_EE_RDDM\n"); + if (!(test_bit(ATH11K_FLAG_UNREGISTERING, &ab->dev_flags))) queue_work(ab->workqueue_aux, &ab->reset_work); break; default:
Change crash logging from debug to informational and add warning when firmware crash MHI_CB_EE_RDDM happens. Tested-on: Qualcomm WCN6855 Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202306141105.c1e82Q0y-lkp@intel.com/ Signed-off-by: Arowa Suliman <arowa@google.com> --- drivers/net/wireless/ath/ath11k/mhi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)