mbox series

[5.10.y-cip,0/5] Add SDHI support to the Renesas RZ/V2M

Message ID 20230703171649.15862-1-fabrizio.castro.jz@renesas.com (mailing list archive)
Headers show
Series Add SDHI support to the Renesas RZ/V2M | expand

Message

Fabrizio Castro July 3, 2023, 5:16 p.m. UTC 
Dear All,

this series adds eMMC/SDHI support to the Renesas RZ/V2M SoC.

I would like to highlight that the driver patch looks fairly
different from upstream, and the reason for it is that the
SDHI IP found inside the RZ/V2M requires a couple of quirks.
The SDHI quirks have been reworked quite a bit over time, and
the implementation the upstream driver patch relies on depends
on changes spanning the renesas sdhi core, the renesas internal
DMAC implementation, and the CPG implemenation.
Considering the amount of patches that would need backporting
in order to get a similar solution to the one found upstream,
and considering that the changes would affect several platforms,
I thought that adapting the solution for the quirks found
upstream to the solution currently available in v5.10.y-cip is the
best way to go, as it adds the required support without introducing
unnecessary risks.

Cheers,
Fab

Fabrizio Castro (4):
  dt-bindings: mmc: renesas,sdhi: Document RZ/V2M support
  mmc: renesas_sdhi: Add RZ/V2M compatible string
  arm64: dts: renesas: r9a09g011: Add eMMC and SDHI support
  arm64: dts: renesas: rzv2mevk2: Add uSD card and eMMC support

Phil Edworthy (1):
  clk: renesas: r9a09g011: Add SDHI/eMMC clock and reset entries

 .../devicetree/bindings/mmc/renesas,sdhi.yaml |   1 +
 .../boot/dts/renesas/r9a09g011-v2mevk2.dts    | 123 ++++++++++++++++++
 arch/arm64/boot/dts/renesas/r9a09g011.dtsi    |  48 +++++++
 drivers/clk/renesas/r9a09g011-cpg.c           |  20 +++
 drivers/mmc/host/renesas_sdhi_core.c          |   1 +
 drivers/mmc/host/renesas_sdhi_internal_dmac.c |   3 +
 6 files changed, 196 insertions(+)

Comments

Nobuhiro Iwamatsu July 6, 2023, 1:18 a.m. UTC | #1 
Hi Fabrizio,

> -----Original Message-----
> From: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> Sent: Tuesday, July 4, 2023 2:17 AM
> To: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□
> ＤＩＴ○ＯＳＴ) <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek
> <pavel@denx.de>
> Cc: Biju Das <biju.das@bp.renesas.com>; Lad Prabhakar
> <prabhakar.mahadev-lad.rj@bp.renesas.com>; Chris Paterson
> <Chris.Paterson2@renesas.com>; Fabrizio Castro
> <fabrizio.castro.jz@renesas.com>
> Subject: [PATCH 5.10.y-cip 0/5] Add SDHI support to the Renesas RZ/V2M
> 
> Dear All,
> 
> this series adds eMMC/SDHI support to the Renesas RZ/V2M SoC.
> 
> I would like to highlight that the driver patch looks fairly different from upstream,
> and the reason for it is that the SDHI IP found inside the RZ/V2M requires a
> couple of quirks.
> The SDHI quirks have been reworked quite a bit over time, and the
> implementation the upstream driver patch relies on depends on changes
> spanning the renesas sdhi core, the renesas internal DMAC implementation,
> and the CPG implemenation.
> Considering the amount of patches that would need backporting in order to get
> a similar solution to the one found upstream, and considering that the changes
> would affect several platforms, I thought that adapting the solution for the
> quirks found upstream to the solution currently available in v5.10.y-cip is the
> best way to go, as it adds the required support without introducing
> unnecessary risks.
> 
> Cheers,
> Fab
> 
> Fabrizio Castro (4):
>   dt-bindings: mmc: renesas,sdhi: Document RZ/V2M support
>   mmc: renesas_sdhi: Add RZ/V2M compatible string
>   arm64: dts: renesas: r9a09g011: Add eMMC and SDHI support
>   arm64: dts: renesas: rzv2mevk2: Add uSD card and eMMC support
> 
> Phil Edworthy (1):
>   clk: renesas: r9a09g011: Add SDHI/eMMC clock and reset entries
> 

I reviewed the patch and found no issues.
I can apply, if there are no comments and issues.

Test: https://gitlab.com/cip-project/cip-kernel/linux-cip/-/pipelines/919945015
Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>

Best regards,
  Nobuhiro
Pavel Machek July 7, 2023, 3:49 p.m. UTC | #2 
Hi!

> > Fabrizio Castro (4):
> >   dt-bindings: mmc: renesas,sdhi: Document RZ/V2M support
> >   mmc: renesas_sdhi: Add RZ/V2M compatible string
> >   arm64: dts: renesas: r9a09g011: Add eMMC and SDHI support
> >   arm64: dts: renesas: rzv2mevk2: Add uSD card and eMMC support
> > 
> > Phil Edworthy (1):
> >   clk: renesas: r9a09g011: Add SDHI/eMMC clock and reset entries
> > 
> 
> I reviewed the patch and found no issues.
> I can apply, if there are no comments and issues.
> 
> Test: https://gitlab.com/cip-project/cip-kernel/linux-cip/-/pipelines/919945015
> Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>

There's an extra empty line in 2/5, but that's too minor detail to be
worth fixing.

Reviewed-by: Pavel Machek <pavel@denx.de>

We'll need similar series for 6.1, AFAICT.

Best regards,
								Pavel
Fabrizio Castro July 11, 2023, 8:25 a.m. UTC | #3 
Hi Pavel,

Thanks for your feedback.

> From: Pavel Machek <pavel@denx.de>
> Subject: Re: [PATCH 5.10.y-cip 0/5] Add SDHI support to the Renesas
> RZ/V2M
> 
> Hi!
> 
> > > Fabrizio Castro (4):
> > >   dt-bindings: mmc: renesas,sdhi: Document RZ/V2M support
> > >   mmc: renesas_sdhi: Add RZ/V2M compatible string
> > >   arm64: dts: renesas: r9a09g011: Add eMMC and SDHI support
> > >   arm64: dts: renesas: rzv2mevk2: Add uSD card and eMMC support
> > >
> > > Phil Edworthy (1):
> > >   clk: renesas: r9a09g011: Add SDHI/eMMC clock and reset entries
> > >
> >
> > I reviewed the patch and found no issues.
> > I can apply, if there are no comments and issues.
> >
> > Test: https://gitlab.com/cip-project/cip-kernel/linux-cip/-
> /pipelines/919945015
> > Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> 
> There's an extra empty line in 2/5, but that's too minor detail to be
> worth fixing.
> 
> Reviewed-by: Pavel Machek <pavel@denx.de>
> 
> We'll need similar series for 6.1, AFAICT.

Yes, I will send a similar series for 6.1 soon.

Cheers,
Fab

> 
> Best regards,
> 								Pavel
> --
> DENX Software Engineering GmbH,        Managing Director: Erika Unter
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Fabrizio Castro July 11, 2023, 9:15 a.m. UTC | #4 
Hi Iwamatsu-san,

Thanks your reply!

> From: nobuhiro1.iwamatsu@toshiba.co.jp
> Subject: RE: [PATCH 5.10.y-cip 0/5] Add SDHI support to the Renesas
> RZ/V2M
> 
> Hi Fabrizio,
> 
> > -----Original Message-----
> > From: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> > Sent: Tuesday, July 4, 2023 2:17 AM
> > To: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ
> □
> > ＤＩＴ○ＯＳＴ) <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek
> > <pavel@denx.de>
> > Cc: Biju Das <biju.das@bp.renesas.com>; Lad Prabhakar
> > <prabhakar.mahadev-lad.rj@bp.renesas.com>; Chris Paterson
> > <Chris.Paterson2@renesas.com>; Fabrizio Castro
> > <fabrizio.castro.jz@renesas.com>
> > Subject: [PATCH 5.10.y-cip 0/5] Add SDHI support to the Renesas
> RZ/V2M
> >
> > Dear All,
> >
> > this series adds eMMC/SDHI support to the Renesas RZ/V2M SoC.
> >
> > I would like to highlight that the driver patch looks fairly
> different from upstream,
> > and the reason for it is that the SDHI IP found inside the RZ/V2M
> requires a
> > couple of quirks.
> > The SDHI quirks have been reworked quite a bit over time, and the
> > implementation the upstream driver patch relies on depends on
> changes
> > spanning the renesas sdhi core, the renesas internal DMAC
> implementation,
> > and the CPG implemenation.
> > Considering the amount of patches that would need backporting in
> order to get
> > a similar solution to the one found upstream, and considering that
> the changes
> > would affect several platforms, I thought that adapting the solution
> for the
> > quirks found upstream to the solution currently available in
> v5.10.y-cip is the
> > best way to go, as it adds the required support without introducing
> > unnecessary risks.
> >
> > Cheers,
> > Fab
> >
> > Fabrizio Castro (4):
> >   dt-bindings: mmc: renesas,sdhi: Document RZ/V2M support
> >   mmc: renesas_sdhi: Add RZ/V2M compatible string
> >   arm64: dts: renesas: r9a09g011: Add eMMC and SDHI support
> >   arm64: dts: renesas: rzv2mevk2: Add uSD card and eMMC support
> >
> > Phil Edworthy (1):
> >   clk: renesas: r9a09g011: Add SDHI/eMMC clock and reset entries
> >
> 
> I reviewed the patch and found no issues.
> I can apply, if there are no comments and issues.

I think this series is safe to apply, as no issues have been highlighted
from the reviews.

Thanks,
Fab

> 
> 
> Best regards,
>   Nobuhiro
Pavel Machek July 11, 2023, 1:14 p.m. UTC | #5 
Hi!

> > I reviewed the patch and found no issues.
> > I can apply, if there are no comments and issues.
> 
> I think this series is safe to apply, as no issues have been highlighted
> from the reviews.

Let me take a look. Patches apply ok, I'm now running tests.

Best regards,
								Pavel
Pavel Machek July 11, 2023, 2:01 p.m. UTC | #6 
Hi!

> > I reviewed the patch and found no issues.
> > I can apply, if there are no comments and issues.
> 
> I think this series is safe to apply, as no issues have been highlighted
> from the reviews.

Thank you, applied.

I'm not aware of any other patches in the pipeline; if there's
anything I am missing, let me know.

Best regards,
								Pavel