| Message ID | 20230711200141.239025-1-gnstark@sberdevices.ru (mailing list archive) |
|---|---|
| Headers | show |
| Series | iio: adc: meson: add iio channels to read channel 7 mux inputs | expand |
On Tue, Jul 11, 2023 at 11:00:16PM +0300, George Stark wrote:
> Changelog:
I gave you a tag, any reason why you haven't applied it to your patches?
Hello Andy On 7/12/23 18:26, Andy Shevchenko wrote: > On Tue, Jul 11, 2023 at 11:00:16PM +0300, George Stark wrote: >> Changelog: > > I gave you a tag, any reason why you haven't applied it to your patches? if you're talking about patch 6 commit message - yes, I missed the last line in your letter, I'll fix it. -- Best regards George
On Thu, Jul 13, 2023 at 02:04:05AM +0300, George Stark wrote: > Hello Andy > > On 7/12/23 18:26, Andy Shevchenko wrote: > > On Tue, Jul 11, 2023 at 11:00:16PM +0300, George Stark wrote: > > > Changelog: > > > > I gave you a tag, any reason why you haven't applied it to your patches? > > if you're talking about patch 6 commit message - yes, I missed the last line > in your letter, I'll fix it. I believe I answered to the cover letter [1], which means that it applies to the entire series. If you don't include tag of the reviewer(s) who spent time on your code, you have to well justify WHY you did so. [1]: https://lore.kernel.org/lkml/ZKvQaoFxO5gpAFdM@smile.fi.intel.com/
On 7/13/23 15:08, Andy Shevchenko wrote: > On Thu, Jul 13, 2023 at 02:04:05AM +0300, George Stark wrote: >> Hello Andy >> >> On 7/12/23 18:26, Andy Shevchenko wrote: >>> On Tue, Jul 11, 2023 at 11:00:16PM +0300, George Stark wrote: >>> >>> I gave you a tag, any reason why you haven't applied it to your patches? >> >> if you're talking about patch 6 commit message - yes, I missed the last line >> in your letter, I'll fix it. > > I believe I answered to the cover letter [1], which means that it applies to > the entire series. If you don't include tag of the reviewer(s) who spent time > on your code, you have to well justify WHY you did so. > > [1]: https://lore.kernel.org/lkml/ZKvQaoFxO5gpAFdM@smile.fi.intel.com/ > Hello Andy I think I've understood at last what you meant by "not applied tag". I'm not experienced kernel contributor yet and believed that RvBs and Acks are added by one who merges patches or by some kind of magic :) Of course I'll add the tag, I missed it not on purpose. Thank you very much for help and your work for the common good.
On Fri, Jul 14, 2023 at 02:11:19AM +0300, George Stark wrote: > On 7/13/23 15:08, Andy Shevchenko wrote: > > On Thu, Jul 13, 2023 at 02:04:05AM +0300, George Stark wrote: > > > On 7/12/23 18:26, Andy Shevchenko wrote: > > > > On Tue, Jul 11, 2023 at 11:00:16PM +0300, George Stark wrote: > > > > > > > > I gave you a tag, any reason why you haven't applied it to your patches? > > > > > > if you're talking about patch 6 commit message - yes, I missed the last line > > > in your letter, I'll fix it. > > > > I believe I answered to the cover letter [1], which means that it applies to > > the entire series. If you don't include tag of the reviewer(s) who spent time > > on your code, you have to well justify WHY you did so. > > > > [1]: https://lore.kernel.org/lkml/ZKvQaoFxO5gpAFdM@smile.fi.intel.com/ > > Hello Andy > > I think I've understood at last what you meant by "not applied tag". I'm not > experienced kernel contributor yet and believed that RvBs and Acks are added > by one who merges patches or by some kind of magic :) If you (not a maintainer) respin the series, it's your responsibility to add / drop / update tags. And hence to explain any modifications to that. > Of course I'll add the tag, I missed it not on purpose. > Thank you very much for help and your work for the common good. No problem, as I said, I'm in favour of your good contribution, just some processing issues which can be easily fixed.