| Message ID | 20230312131318.351173-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/28] media: cec: ch7322: drop of_match_ptr for ID table | expand |
Hi Krzysztof, Thank you for the patch. On Sun, Mar 12, 2023 at 02:13:12PM +0100, Krzysztof Kozlowski wrote: > The driver will match mostly by DT table (even thought there is regular > ID table) so there is little benefit in of_match_ptr (this also allows > ACPI matching via PRP0001, even though it might not be relevant here). > This also fixes !CONFIG_OF error: > > drivers/media/i2c/mt9m111.c:1370:34: error: ‘mt9m111_of_match’ defined but not used [-Werror=unused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/media/i2c/mt9m111.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/mt9m111.c b/drivers/media/i2c/mt9m111.c > index f5fe272d1205..20ed87d872c8 100644 > --- a/drivers/media/i2c/mt9m111.c > +++ b/drivers/media/i2c/mt9m111.c > @@ -1382,7 +1382,7 @@ MODULE_DEVICE_TABLE(i2c, mt9m111_id); > static struct i2c_driver mt9m111_i2c_driver = { > .driver = { > .name = "mt9m111", > - .of_match_table = of_match_ptr(mt9m111_of_match), > + .of_match_table = mt9m111_of_match, > }, > .probe_new = mt9m111_probe, > .remove = mt9m111_remove,
Hi Krzysztof, Thank you for the patch. On Sun, Mar 12, 2023 at 02:13:15PM +0100, Krzysztof Kozlowski wrote: > The driver will match mostly by DT table (even thought there is regular > ID table) so there is little benefit in of_match_ptr (this also allows > ACPI matching via PRP0001, even though it might not be relevant here). > This also fixes !CONFIG_OF error: > > drivers/media/i2c/ov7740.c:1203:34: error: ‘ov7740_of_match’ defined but not used [-Werror=unused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/media/i2c/ov7740.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/ov7740.c b/drivers/media/i2c/ov7740.c > index c9fd9b0bc54a..42121916d25f 100644 > --- a/drivers/media/i2c/ov7740.c > +++ b/drivers/media/i2c/ov7740.c > @@ -1210,7 +1210,7 @@ static struct i2c_driver ov7740_i2c_driver = { > .driver = { > .name = "ov7740", > .pm = &ov7740_pm_ops, > - .of_match_table = of_match_ptr(ov7740_of_match), > + .of_match_table = ov7740_of_match, > }, > .probe_new = ov7740_probe, > .remove = ov7740_remove,
On 12/03/2023 14:12, Krzysztof Kozlowski wrote: > The driver can match only via the DT table so the table should be always > used and the of_match_ptr does not have any sense (this also allows ACPI > matching via PRP0001, even though it might not be relevant here). > > drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> I assume you want to take this series, but if you prefer to have us do it, then just let me know. Thanks! Hans > --- > drivers/media/cec/i2c/ch7322.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/cec/i2c/ch7322.c b/drivers/media/cec/i2c/ch7322.c > index 34fad7123704..3c6e6496a001 100644 > --- a/drivers/media/cec/i2c/ch7322.c > +++ b/drivers/media/cec/i2c/ch7322.c > @@ -589,7 +589,7 @@ MODULE_DEVICE_TABLE(of, ch7322_of_match); > static struct i2c_driver ch7322_i2c_driver = { > .driver = { > .name = "ch7322", > - .of_match_table = of_match_ptr(ch7322_of_match), > + .of_match_table = ch7322_of_match, > }, > .probe_new = ch7322_probe, > .remove = ch7322_remove,
On Sun, Mar 12, 2023 at 02:12:51PM +0100, Krzysztof Kozlowski wrote: > The driver can match only via the DT table so the table should be always > used and the of_match_ptr does not have any sense (this also allows ACPI > matching via PRP0001, even though it might not be relevant here). > > drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Guenter Roeck <linux@roeck-us.net> FWIW: There is also https://patches.linaro.org/project/linux-media/patch/20230215214724.3798917-1-linux@roeck-us.net/ The lack of ACPI support is a real problem and very relevant. Guenter > --- > drivers/media/cec/i2c/ch7322.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/cec/i2c/ch7322.c b/drivers/media/cec/i2c/ch7322.c > index 34fad7123704..3c6e6496a001 100644 > --- a/drivers/media/cec/i2c/ch7322.c > +++ b/drivers/media/cec/i2c/ch7322.c > @@ -589,7 +589,7 @@ MODULE_DEVICE_TABLE(of, ch7322_of_match); > static struct i2c_driver ch7322_i2c_driver = { > .driver = { > .name = "ch7322", > - .of_match_table = of_match_ptr(ch7322_of_match), > + .of_match_table = ch7322_of_match, > }, > .probe_new = ch7322_probe, > .remove = ch7322_remove,
On 13/03/2023 12:46, Hans Verkuil wrote: > On 12/03/2023 14:12, Krzysztof Kozlowski wrote: >> The driver can match only via the DT table so the table should be always >> used and the of_match_ptr does not have any sense (this also allows ACPI >> matching via PRP0001, even though it might not be relevant here). >> >> drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=] >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> > > I assume you want to take this series, but if you prefer to have us do it, then > just let me know. I prefer if you to take it. Please grab it! :) Best regards, Krzysztof
On 14/03/2023 09:34, Hans Verkuil wrote: > On 13/03/2023 23:01, Guenter Roeck wrote: >> On Sun, Mar 12, 2023 at 02:12:51PM +0100, Krzysztof Kozlowski wrote: >>> The driver can match only via the DT table so the table should be always >>> used and the of_match_ptr does not have any sense (this also allows ACPI >>> matching via PRP0001, even though it might not be relevant here). >>> >>> drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=] >>> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> Reviewed-by: Guenter Roeck <linux@roeck-us.net> >> >> FWIW: There is also >> https://patches.linaro.org/project/linux-media/patch/20230215214724.3798917-1-linux@roeck-us.net/ > > I superseded that patch in patchwork in favor of this patch since this is part of > a larger series. I am personally fan of FIFO, so Guenter's patch should go in. > > Krzysztof, please let me know if you will take this series yourself or want me to > make a PR for it. I prefer if you take entire patchset. Best regards, Krzysztof
On 3/14/23 09:32, Krzysztof Kozlowski wrote: > On 14/03/2023 09:34, Hans Verkuil wrote: >> On 13/03/2023 23:01, Guenter Roeck wrote: >>> On Sun, Mar 12, 2023 at 02:12:51PM +0100, Krzysztof Kozlowski wrote: >>>> The driver can match only via the DT table so the table should be always >>>> used and the of_match_ptr does not have any sense (this also allows ACPI >>>> matching via PRP0001, even though it might not be relevant here). >>>> >>>> drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=] >>>> >>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> >>> Reviewed-by: Guenter Roeck <linux@roeck-us.net> >>> >>> FWIW: There is also >>> https://patches.linaro.org/project/linux-media/patch/20230215214724.3798917-1-linux@roeck-us.net/ >> >> I superseded that patch in patchwork in favor of this patch since this is part of >> a larger series. > > I am personally fan of FIFO, so Guenter's patch should go in. > FWIW, I do not care either way, I just wanted to point out that this patch _is_ both relevant and needed, and that it (or, rather, the original version) has been reviewed and tested. Thanks, Guenter
On 12/03/2023 14:12, Krzysztof Kozlowski wrote: > The driver can match only via the DT table so the table should be always > used and the of_match_ptr does not have any sense (this also allows ACPI > matching via PRP0001, even though it might not be relevant here). > > drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Hans, Sakari, Can you pick up the patchset? There was positive feedback: https://patchwork.linuxtv.org/project/linux-media/patch/20230312131318.351173-1-krzysztof.kozlowski@linaro.org/ but it seems it was not applied. Best regards, Krzysztof
On 12/05/2023 18:35, Krzysztof Kozlowski wrote: > On 12/03/2023 14:12, Krzysztof Kozlowski wrote: >> The driver can match only via the DT table so the table should be always >> used and the of_match_ptr does not have any sense (this also allows ACPI >> matching via PRP0001, even though it might not be relevant here). >> >> drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=] >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- > > Hans, Sakari, > > Can you pick up the patchset? There was positive feedback: > https://patchwork.linuxtv.org/project/linux-media/patch/20230312131318.351173-1-krzysztof.kozlowski@linaro.org/ > > but it seems it was not applied. I see it is delegated to Sakari in patchwork and marked Under Review, but I don't see a corresponding pull request for this series. Sakari, did something go wrong? Regards, Hans > > Best regards, > Krzysztof >
Hi Hans, On Sat, May 13, 2023 at 11:57:33AM +0200, Hans Verkuil wrote: > On 12/05/2023 18:35, Krzysztof Kozlowski wrote: > > On 12/03/2023 14:12, Krzysztof Kozlowski wrote: > >> The driver can match only via the DT table so the table should be always > >> used and the of_match_ptr does not have any sense (this also allows ACPI > >> matching via PRP0001, even though it might not be relevant here). > >> > >> drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=] > >> > >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> --- > > > > Hans, Sakari, > > > > Can you pick up the patchset? There was positive feedback: > > https://patchwork.linuxtv.org/project/linux-media/patch/20230312131318.351173-1-krzysztof.kozlowski@linaro.org/ > > > > but it seems it was not applied. > > I see it is delegated to Sakari in patchwork and marked Under Review, but I don't > see a corresponding pull request for this series. > > Sakari, did something go wrong? I spotted this as Hans notified me in IRC, I wasn't cc'd. Apologies for this --- I intended to take these but I think I must have missed something important in the process. I'll take them now. Thanks.
Hi folks, On Thu, May 25, 2023 at 03:40:04PM +0300, Sakari Ailus wrote: > Hi Hans, > > On Sat, May 13, 2023 at 11:57:33AM +0200, Hans Verkuil wrote: > > On 12/05/2023 18:35, Krzysztof Kozlowski wrote: > > > On 12/03/2023 14:12, Krzysztof Kozlowski wrote: > > >> The driver can match only via the DT table so the table should be always > > >> used and the of_match_ptr does not have any sense (this also allows ACPI > > >> matching via PRP0001, even though it might not be relevant here). > > >> > > >> drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=] > > >> > > >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > >> --- > > > > > > Hans, Sakari, > > > > > > Can you pick up the patchset? There was positive feedback: > > > https://patchwork.linuxtv.org/project/linux-media/patch/20230312131318.351173-1-krzysztof.kozlowski@linaro.org/ > > > > > > but it seems it was not applied. > > > > I see it is delegated to Sakari in patchwork and marked Under Review, but I don't > > see a corresponding pull request for this series. > > > > Sakari, did something go wrong? > > I spotted this as Hans notified me in IRC, I wasn't cc'd. Apologies for > this --- I intended to take these but I think I must have missed something > important in the process. I'll take them now. > > Thanks. This no longer applied cleanly. Mostly there was fuzz near .of_match_table changes as probe_new (and remove_new?) changes have been recently merged. There were other issues as well, I marked a few patches in the set "not applicable" as other patches had already done equivalent changes earlier. There were substance-changing changes in the 20th patch, replied to the disuccsion there. I've pushed the result here and intend to send PR to Mauro soon if there are no issues: <URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=of-match-ptr>
On 19/06/2023 16:13, Krzysztof Kozlowski wrote: > On 25/05/2023 15:19, Sakari Ailus wrote: >> Hi folks, >> >> On Thu, May 25, 2023 at 03:40:04PM +0300, Sakari Ailus wrote: >>> Hi Hans, >>> >>> On Sat, May 13, 2023 at 11:57:33AM +0200, Hans Verkuil wrote: >>>> On 12/05/2023 18:35, Krzysztof Kozlowski wrote: >>>>> On 12/03/2023 14:12, Krzysztof Kozlowski wrote: >>>>>> The driver can match only via the DT table so the table should be always >>>>>> used and the of_match_ptr does not have any sense (this also allows ACPI >>>>>> matching via PRP0001, even though it might not be relevant here). >>>>>> >>>>>> drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=] >>>>>> >>>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>>>> --- >>>>> >>>>> Hans, Sakari, >>>>> >>>>> Can you pick up the patchset? There was positive feedback: >>>>> https://patchwork.linuxtv.org/project/linux-media/patch/20230312131318.351173-1-krzysztof.kozlowski@linaro.org/ >>>>> >>>>> but it seems it was not applied. >>>> >>>> I see it is delegated to Sakari in patchwork and marked Under Review, but I don't >>>> see a corresponding pull request for this series. >>>> >>>> Sakari, did something go wrong? >>> >>> I spotted this as Hans notified me in IRC, I wasn't cc'd. Apologies for >>> this --- I intended to take these but I think I must have missed something >>> important in the process. I'll take them now. >>> >>> Thanks. >> >> This no longer applied cleanly. Mostly there was fuzz near .of_match_table >> changes as probe_new (and remove_new?) changes have been recently merged. >> There were other issues as well, I marked a few patches in the set "not >> applicable" as other patches had already done equivalent changes earlier. >> >> There were substance-changing changes in the 20th patch, replied to the >> disuccsion there. >> >> I've pushed the result here and intend to send PR to Mauro soon if there >> are no issues: >> >> <URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=of-match-ptr> > > One month later, I still don't see this set in the linux-next. What's > happening here? > I don't think this was merged in v6.5-rc1. It's not in linux-next, either. Another month passed... Best regards, Krzysztof
On 13/07/2023 08:46, Krzysztof Kozlowski wrote: > On 19/06/2023 16:13, Krzysztof Kozlowski wrote: >> On 25/05/2023 15:19, Sakari Ailus wrote: >>> Hi folks, >>> >>> On Thu, May 25, 2023 at 03:40:04PM +0300, Sakari Ailus wrote: >>>> Hi Hans, >>>> >>>> On Sat, May 13, 2023 at 11:57:33AM +0200, Hans Verkuil wrote: >>>>> On 12/05/2023 18:35, Krzysztof Kozlowski wrote: >>>>>> On 12/03/2023 14:12, Krzysztof Kozlowski wrote: >>>>>>> The driver can match only via the DT table so the table should be always >>>>>>> used and the of_match_ptr does not have any sense (this also allows ACPI >>>>>>> matching via PRP0001, even though it might not be relevant here). >>>>>>> >>>>>>> drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=] >>>>>>> >>>>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>>>>> --- >>>>>> >>>>>> Hans, Sakari, >>>>>> >>>>>> Can you pick up the patchset? There was positive feedback: >>>>>> https://patchwork.linuxtv.org/project/linux-media/patch/20230312131318.351173-1-krzysztof.kozlowski@linaro.org/ >>>>>> >>>>>> but it seems it was not applied. >>>>> >>>>> I see it is delegated to Sakari in patchwork and marked Under Review, but I don't >>>>> see a corresponding pull request for this series. >>>>> >>>>> Sakari, did something go wrong? >>>> >>>> I spotted this as Hans notified me in IRC, I wasn't cc'd. Apologies for >>>> this --- I intended to take these but I think I must have missed something >>>> important in the process. I'll take them now. >>>> >>>> Thanks. >>> >>> This no longer applied cleanly. Mostly there was fuzz near .of_match_table >>> changes as probe_new (and remove_new?) changes have been recently merged. >>> There were other issues as well, I marked a few patches in the set "not >>> applicable" as other patches had already done equivalent changes earlier. >>> >>> There were substance-changing changes in the 20th patch, replied to the >>> disuccsion there. >>> >>> I've pushed the result here and intend to send PR to Mauro soon if there >>> are no issues: >>> >>> <URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=of-match-ptr> >> >> One month later, I still don't see this set in the linux-next. What's >> happening here? >> > > I don't think this was merged in v6.5-rc1. It's not in linux-next, > either. Another month passed... I'm really hopeful it will be merged very soon. As you may have noticed (!) we have problems with maintaining the media subsystem (too many patches, not enough maintainers). We had a meeting about that a few weeks ago and are working on it. The core problem for this particular series was that the PR containing this series was posted much too late (as in three months too late!), and it came in too late for 6.5. Regards, Hans
Hi Krzysztof, On Thu, Jul 13, 2023 at 08:46:58AM +0200, Krzysztof Kozlowski wrote: > On 19/06/2023 16:13, Krzysztof Kozlowski wrote: > > On 25/05/2023 15:19, Sakari Ailus wrote: > >> Hi folks, > >> > >> On Thu, May 25, 2023 at 03:40:04PM +0300, Sakari Ailus wrote: > >>> Hi Hans, > >>> > >>> On Sat, May 13, 2023 at 11:57:33AM +0200, Hans Verkuil wrote: > >>>> On 12/05/2023 18:35, Krzysztof Kozlowski wrote: > >>>>> On 12/03/2023 14:12, Krzysztof Kozlowski wrote: > >>>>>> The driver can match only via the DT table so the table should be always > >>>>>> used and the of_match_ptr does not have any sense (this also allows ACPI > >>>>>> matching via PRP0001, even though it might not be relevant here). > >>>>>> > >>>>>> drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=] > >>>>>> > >>>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >>>>>> --- > >>>>> > >>>>> Hans, Sakari, > >>>>> > >>>>> Can you pick up the patchset? There was positive feedback: > >>>>> https://patchwork.linuxtv.org/project/linux-media/patch/20230312131318.351173-1-krzysztof.kozlowski@linaro.org/ > >>>>> > >>>>> but it seems it was not applied. > >>>> > >>>> I see it is delegated to Sakari in patchwork and marked Under Review, but I don't > >>>> see a corresponding pull request for this series. > >>>> > >>>> Sakari, did something go wrong? > >>> > >>> I spotted this as Hans notified me in IRC, I wasn't cc'd. Apologies for > >>> this --- I intended to take these but I think I must have missed something > >>> important in the process. I'll take them now. > >>> > >>> Thanks. > >> > >> This no longer applied cleanly. Mostly there was fuzz near .of_match_table > >> changes as probe_new (and remove_new?) changes have been recently merged. > >> There were other issues as well, I marked a few patches in the set "not > >> applicable" as other patches had already done equivalent changes earlier. > >> > >> There were substance-changing changes in the 20th patch, replied to the > >> disuccsion there. > >> > >> I've pushed the result here and intend to send PR to Mauro soon if there > >> are no issues: > >> > >> <URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=of-match-ptr> > > > > One month later, I still don't see this set in the linux-next. What's > > happening here? > > > > I don't think this was merged in v6.5-rc1. It's not in linux-next, > either. Another month passed... These are now in the media-stage tree <URL:https://git.linuxtv.org/media_stage.git/log/>. Assuming nothing goes wrong, these should end up in Linus's tree for 6.6. The issues related to media tree maintenance are being addressed as we're changing the process how the tree is maintained. The patches will eventually get in still, also expect this to improve in the future.
On 25/07/2023 12:51, Sakari Ailus wrote: >> >> I don't think this was merged in v6.5-rc1. It's not in linux-next, >> either. Another month passed... > > These are now in the media-stage tree > <URL:https://git.linuxtv.org/media_stage.git/log/>. Assuming nothing goes > wrong, these should end up in Linus's tree for 6.6. Great, thank you! Best regards, Krzysztof
diff --git a/drivers/media/cec/i2c/ch7322.c b/drivers/media/cec/i2c/ch7322.c index 34fad7123704..3c6e6496a001 100644 --- a/drivers/media/cec/i2c/ch7322.c +++ b/drivers/media/cec/i2c/ch7322.c @@ -589,7 +589,7 @@ MODULE_DEVICE_TABLE(of, ch7322_of_match); static struct i2c_driver ch7322_i2c_driver = { .driver = { .name = "ch7322", - .of_match_table = of_match_ptr(ch7322_of_match), + .of_match_table = ch7322_of_match, }, .probe_new = ch7322_probe, .remove = ch7322_remove,
The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might not be relevant here). drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=] Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/media/cec/i2c/ch7322.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)