| Message ID | 20230713130338.31086-9-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT flags | expand |
On Thu, 2023-07-13 at 14:58 +0200, Thomas Zimmermann wrote: > Assign FB_MODE_IS_UNKNOWN to sh7763fb_videomode.flag instead of > FBINFO_FLAG_DEFAULT. Both are 0, so the stored value does not change. > > FBINFO_FLAG_DEFAULT is a flag for a framebuffer in struct fb_info. > Flags for videomodes are prefixed with FB_MODE_. > > v2: > * assign FB_MODE_IS_UNKNOWN (Adrian) > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Acked-by: Sam Ravnborg <sam@ravnborg.org> > Cc: Yoshinori Sato <ysato@users.sourceforge.jp> > Cc: Rich Felker <dalias@libc.org> > Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> > --- > arch/sh/boards/mach-sh7763rdp/setup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/sh/boards/mach-sh7763rdp/setup.c b/arch/sh/boards/mach-sh7763rdp/setup.c > index 97e715e4e9b3..e25193001ea0 100644 > --- a/arch/sh/boards/mach-sh7763rdp/setup.c > +++ b/arch/sh/boards/mach-sh7763rdp/setup.c > @@ -119,7 +119,7 @@ static struct fb_videomode sh7763fb_videomode = { > .vsync_len = 1, > .sync = 0, > .vmode = FB_VMODE_NONINTERLACED, > - .flag = FBINFO_FLAG_DEFAULT, > + .flag = FB_MODE_IS_UNKNOWN, > }; > > static struct sh7760fb_platdata sh7763fb_def_pdata = { Acked-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Hi Thomas! On Thu, 2023-07-13 at 15:53 +0200, John Paul Adrian Glaubitz wrote: > On Thu, 2023-07-13 at 14:58 +0200, Thomas Zimmermann wrote: > > Assign FB_MODE_IS_UNKNOWN to sh7763fb_videomode.flag instead of > > FBINFO_FLAG_DEFAULT. Both are 0, so the stored value does not change. > > > > FBINFO_FLAG_DEFAULT is a flag for a framebuffer in struct fb_info. > > Flags for videomodes are prefixed with FB_MODE_. > > > > v2: > > * assign FB_MODE_IS_UNKNOWN (Adrian) > > > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > > Acked-by: Sam Ravnborg <sam@ravnborg.org> > > Cc: Yoshinori Sato <ysato@users.sourceforge.jp> > > Cc: Rich Felker <dalias@libc.org> > > Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> > > --- > > arch/sh/boards/mach-sh7763rdp/setup.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/sh/boards/mach-sh7763rdp/setup.c b/arch/sh/boards/mach-sh7763rdp/setup.c > > index 97e715e4e9b3..e25193001ea0 100644 > > --- a/arch/sh/boards/mach-sh7763rdp/setup.c > > +++ b/arch/sh/boards/mach-sh7763rdp/setup.c > > @@ -119,7 +119,7 @@ static struct fb_videomode sh7763fb_videomode = { > > .vsync_len = 1, > > .sync = 0, > > .vmode = FB_VMODE_NONINTERLACED, > > - .flag = FBINFO_FLAG_DEFAULT, > > + .flag = FB_MODE_IS_UNKNOWN, > > }; > > > > static struct sh7760fb_platdata sh7763fb_def_pdata = { > > Acked-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> Ah, just one tiny request: Could you change the subject to include the board name, i.e.: sh: mach-sh7763rdp: Assign FB_MODE_IS_UNKNOWN to struct fb_videomode.flag ? I wasn't paying close attention to the path of the file being changed when I first looked at your patch. Sorry for that. Adrian
diff --git a/arch/sh/boards/mach-sh7763rdp/setup.c b/arch/sh/boards/mach-sh7763rdp/setup.c index 97e715e4e9b3..e25193001ea0 100644 --- a/arch/sh/boards/mach-sh7763rdp/setup.c +++ b/arch/sh/boards/mach-sh7763rdp/setup.c @@ -119,7 +119,7 @@ static struct fb_videomode sh7763fb_videomode = { .vsync_len = 1, .sync = 0, .vmode = FB_VMODE_NONINTERLACED, - .flag = FBINFO_FLAG_DEFAULT, + .flag = FB_MODE_IS_UNKNOWN, }; static struct sh7760fb_platdata sh7763fb_def_pdata = {