| Message ID | 20230713-tc-selftests-lkft-v1-3-1eb4fd3a96e7@tessares.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 031c99e71fedcce93b6785d38b7d287bf59e3952 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | selftests: tc: increase timeout and add missing kconfig | expand |
| Context | Check | Description |
|---|---|---|
| netdev/series_format | success | Posting correctly formatted |
| netdev/tree_selection | success | Clearly marked for net |
| netdev/fixes_present | success | Fixes tag present in non-next series |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 8 this patch: 8 |
| netdev/cc_maintainers | success | CCed 8 of 8 maintainers |
| netdev/build_clang | success | Errors and warnings before: 8 this patch: 8 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/deprecated_api | success | None detected |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | Fixes tag looks correct |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 8 this patch: 8 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On 2023/7/14 5:16, Matthieu Baerts wrote: > When looking at the TC selftest reports, I noticed one test was failing > because /proc/net/nf_conntrack was not available. > > not ok 373 3992 - Add ct action triggering DNAT tuple conflict > Could not match regex pattern. Verify command output: > cat: /proc/net/nf_conntrack: No such file or directory > > It is only available if NF_CONNTRACK_PROCFS kconfig is set. So the issue > can be fixed simply by adding it to the list of required kconfig. > > Fixes: e46905641316 ("tc-testing: add test for ct DNAT tuple collision") > Cc: stable@vger.kernel.org > Link: https://lore.kernel.org/netdev/0e061d4a-9a23-9f58-3b35-d8919de332d7@tessares.net/T/ [1] > Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net> > --- > tools/testing/selftests/tc-testing/config | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/tc-testing/config b/tools/testing/selftests/tc-testing/config > index d1ad29040c02..71706197ba0f 100644 > --- a/tools/testing/selftests/tc-testing/config > +++ b/tools/testing/selftests/tc-testing/config > @@ -5,6 +5,7 @@ CONFIG_NF_CONNTRACK=m > CONFIG_NF_CONNTRACK_MARK=y > CONFIG_NF_CONNTRACK_ZONES=y > CONFIG_NF_CONNTRACK_LABELS=y > +CONFIG_NF_CONNTRACK_PROCFS=y > CONFIG_NF_FLOW_TABLE=m > CONFIG_NF_NAT=m > CONFIG_NETFILTER_XT_TARGET_LOG=m > Tested-by: Zhengchao Shao <shaozhengchao@huawei.com>
diff --git a/tools/testing/selftests/tc-testing/config b/tools/testing/selftests/tc-testing/config index d1ad29040c02..71706197ba0f 100644 --- a/tools/testing/selftests/tc-testing/config +++ b/tools/testing/selftests/tc-testing/config @@ -5,6 +5,7 @@ CONFIG_NF_CONNTRACK=m CONFIG_NF_CONNTRACK_MARK=y CONFIG_NF_CONNTRACK_ZONES=y CONFIG_NF_CONNTRACK_LABELS=y +CONFIG_NF_CONNTRACK_PROCFS=y CONFIG_NF_FLOW_TABLE=m CONFIG_NF_NAT=m CONFIG_NETFILTER_XT_TARGET_LOG=m
When looking at the TC selftest reports, I noticed one test was failing because /proc/net/nf_conntrack was not available. not ok 373 3992 - Add ct action triggering DNAT tuple conflict Could not match regex pattern. Verify command output: cat: /proc/net/nf_conntrack: No such file or directory It is only available if NF_CONNTRACK_PROCFS kconfig is set. So the issue can be fixed simply by adding it to the list of required kconfig. Fixes: e46905641316 ("tc-testing: add test for ct DNAT tuple collision") Cc: stable@vger.kernel.org Link: https://lore.kernel.org/netdev/0e061d4a-9a23-9f58-3b35-d8919de332d7@tessares.net/T/ [1] Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net> --- tools/testing/selftests/tc-testing/config | 1 + 1 file changed, 1 insertion(+)