mbox series

[V9,0/3] rpmsg signaling/flowcontrol patches

Message ID 1688679698-31274-1-git-send-email-quic_sarannya@quicinc.com (mailing list archive)
Headers show
Series rpmsg signaling/flowcontrol patches | expand

Message

Sarannya S July 6, 2023, 9:41 p.m. UTC
From: Sarannya S <sarannya@qti.qualcomm.com>

Changes from V8:
* Updated the argument for RPMSG_SET_INCOMING_FLOWCONTROL to int.
* Return -EINVAL if arg > 1 in RPMSG_SET_INCOMING_FLOWCONTROL.

Key changes from earlier revisions:
* Added two new RPMSG IOCTLs for rpmsg_char- RPMSG_GET_SIGNAL_IOCTRL and RPMSG_SET_SIGNAL_IOCTRL, to set/get the flow.
* Updated the cmd name 'RPM_CMD_SIGNALS' to 'GLINK_CMD_SIGNALS'.
* Return EOPNOTSUPP error in rpmsg_set_flow_control(), if the backend does not support flow control ops.
* For rpmsg_set_flow_control, change "EXPORT_SYMBOL" to "EXPORT_SYMBOL_GPL".
* Change return type of qcom_glink_handle_signals() from int to void.
* Added destination address of the endpoint as parameter in rpmsg_set_flow_control.
* Changed 'remote_flow' to bool type, and updated it's evaluation.
* Updated evaluation of 'set' in rpmsg_char as 'set = !!arg'.

Chris Lew (2):
  rpmsg: glink: Add support to handle signals command
  rpmsg: char: Add RPMSG GET/SET FLOWCONTROL IOCTL support

Deepak Kumar Singh (1):
  rpmsg: core: Add signal API support

 drivers/rpmsg/qcom_glink_native.c | 56 +++++++++++++++++++++++++++++++++++++++
 drivers/rpmsg/rpmsg_char.c        | 54 ++++++++++++++++++++++++++++++++-----
 drivers/rpmsg/rpmsg_core.c        | 21 +++++++++++++++
 drivers/rpmsg/rpmsg_internal.h    |  2 ++
 include/linux/rpmsg.h             | 15 +++++++++++
 include/uapi/linux/rpmsg.h        | 10 +++++++
 6 files changed, 152 insertions(+), 6 deletions(-)

Comments

Bjorn Andersson July 15, 2023, 7:45 p.m. UTC | #1
On Fri, 07 Jul 2023 03:11:35 +0530, Sarannya S wrote:
> From: Sarannya S <sarannya@qti.qualcomm.com>
> 
> Changes from V8:
> * Updated the argument for RPMSG_SET_INCOMING_FLOWCONTROL to int.
> * Return -EINVAL if arg > 1 in RPMSG_SET_INCOMING_FLOWCONTROL.
> 
> Key changes from earlier revisions:
> * Added two new RPMSG IOCTLs for rpmsg_char- RPMSG_GET_SIGNAL_IOCTRL and RPMSG_SET_SIGNAL_IOCTRL, to set/get the flow.
> * Updated the cmd name 'RPM_CMD_SIGNALS' to 'GLINK_CMD_SIGNALS'.
> * Return EOPNOTSUPP error in rpmsg_set_flow_control(), if the backend does not support flow control ops.
> * For rpmsg_set_flow_control, change "EXPORT_SYMBOL" to "EXPORT_SYMBOL_GPL".
> * Change return type of qcom_glink_handle_signals() from int to void.
> * Added destination address of the endpoint as parameter in rpmsg_set_flow_control.
> * Changed 'remote_flow' to bool type, and updated it's evaluation.
> * Updated evaluation of 'set' in rpmsg_char as 'set = !!arg'.
> 
> [...]

Applied, thanks!

[1/3] rpmsg: core: Add signal API support
      commit: 8ce49c2a2aa53afde9a20a8ce02b069d3b262af0
[2/3] rpmsg: glink: Add support to handle signals command
      commit: a2b73aa512a4a90dda7dd5bb38b26b4f1381adbb
[3/3] rpmsg: char: Add RPMSG GET/SET FLOWCONTROL IOCTL support
      commit: 5550201c0fe26a76c53983bd36a58d4c4395ec22

Best regards,