| Message ID | 20230714100929.94563-3-jaewon02.kim@samsung.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/3] dt-bindings: pwm: samsung: add exynosautov9 compatible | expand |
Hello, On Fri, Jul 14, 2023 at 07:09:28PM +0900, Jaewon Kim wrote: > Add new compatible string to support ExynosAutov9 SoC. > > Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com> Looks good to me: Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> What are the merge plans here? The whole series via pwm or a samsung tree? Or a mixture? Best regards Uwe
Hello, On 23. 7. 15. 16:22, Uwe Kleine-König wrote: > Hello, > > On Fri, Jul 14, 2023 at 07:09:28PM +0900, Jaewon Kim wrote: >> Add new compatible string to support ExynosAutov9 SoC. >> >> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com> > Looks good to me: > > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > What are the merge plans here? The whole series via pwm or a samsung > tree? Or a mixture? It would be nice to be merged whole series in the samsung tree. Krzysztof could you apply all patch after your review? > > Best regards > Uwe > Thanks Jaewon Kim
On 14/07/2023 12:09, Jaewon Kim wrote: > Add new compatible string to support ExynosAutov9 SoC. > > Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com> > --- > drivers/pwm/pwm-samsung.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c > index e8828f57ab15..50a88565c440 100644 > --- a/drivers/pwm/pwm-samsung.c > +++ b/drivers/pwm/pwm-samsung.c > @@ -513,6 +513,7 @@ static const struct of_device_id samsung_pwm_matches[] = { > { .compatible = "samsung,s5p6440-pwm", .data = &s5p64x0_variant }, > { .compatible = "samsung,s5pc100-pwm", .data = &s5pc100_variant }, > { .compatible = "samsung,exynos4210-pwm", .data = &s5p64x0_variant }, > + { .compatible = "samsung,exynosautov9-pwm", .data = &s5p64x0_variant }, That's not what I asked for. You do not need entry here. Devices are compatible. Best regards, Krzysztof
On 17/07/2023 06:44, Jaewon Kim wrote: > Hello, > > > On 23. 7. 15. 16:22, Uwe Kleine-König wrote: >> Hello, >> >> On Fri, Jul 14, 2023 at 07:09:28PM +0900, Jaewon Kim wrote: >>> Add new compatible string to support ExynosAutov9 SoC. >>> >>> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com> >> Looks good to me: >> >> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> >> >> What are the merge plans here? The whole series via pwm or a samsung >> tree? Or a mixture? > > It would be nice to be merged whole series in the samsung tree. > > Krzysztof could you apply all patch after your review? Patch needs fixes - it is really different than we talked about. Anyway, both PWM patches - bindings and driver - should go via PWM tree. I will take the DTS, once proper version is sent. Best regards, Krzysztof
On 23. 7. 17. 14:58, Krzysztof Kozlowski wrote: > On 14/07/2023 12:09, Jaewon Kim wrote: >> Add new compatible string to support ExynosAutov9 SoC. >> >> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com> >> --- >> drivers/pwm/pwm-samsung.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c >> index e8828f57ab15..50a88565c440 100644 >> --- a/drivers/pwm/pwm-samsung.c >> +++ b/drivers/pwm/pwm-samsung.c >> @@ -513,6 +513,7 @@ static const struct of_device_id samsung_pwm_matches[] = { >> { .compatible = "samsung,s5p6440-pwm", .data = &s5p64x0_variant }, >> { .compatible = "samsung,s5pc100-pwm", .data = &s5pc100_variant }, >> { .compatible = "samsung,exynos4210-pwm", .data = &s5p64x0_variant }, >> + { .compatible = "samsung,exynosautov9-pwm", .data = &s5p64x0_variant }, > That's not what I asked for. You do not need entry here. Devices are > compatible. I misunderstood your intent. I will add only this compatible to DT and send it again with v3 patch. > Best regards, > Krzysztof > > Thanks Jaewon Kim
diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c index e8828f57ab15..50a88565c440 100644 --- a/drivers/pwm/pwm-samsung.c +++ b/drivers/pwm/pwm-samsung.c @@ -513,6 +513,7 @@ static const struct of_device_id samsung_pwm_matches[] = { { .compatible = "samsung,s5p6440-pwm", .data = &s5p64x0_variant }, { .compatible = "samsung,s5pc100-pwm", .data = &s5pc100_variant }, { .compatible = "samsung,exynos4210-pwm", .data = &s5p64x0_variant }, + { .compatible = "samsung,exynosautov9-pwm", .data = &s5p64x0_variant }, {}, }; MODULE_DEVICE_TABLE(of, samsung_pwm_matches);
Add new compatible string to support ExynosAutov9 SoC. Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com> --- drivers/pwm/pwm-samsung.c | 1 + 1 file changed, 1 insertion(+)