| Message ID | 20230717063319.19974-1-jaewon02.kim@samsung.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v3] arm64: dts: exynos: add pwm node for exynosautov9-sadk | expand |
On 17/07/2023 08:33, Jaewon Kim wrote: > Add pwm node to support fan on exynosautov9-sadk board. > PWM channel 3 of ExynosAutov9 is connected to fan for SoC cooling > in SADK board. > > Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com> > --- > Changes in v3: > - removed adding compatible to driver. > > Changes in v2: > - add compatible string to driver. > --- > arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts | 6 ++++++ > arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 10 ++++++++++ > 2 files changed, 16 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts > index 898c2fc345ed..e717bb1cad81 100644 > --- a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts > +++ b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts > @@ -50,6 +50,12 @@ > }; > }; > > +&pwm { > + pinctrl-names = "default"; > + pinctrl-0 = <&pwm_tout3>; > + status = "okay"; > +}; > + > &serial_0 { > pinctrl-0 = <&uart0_bus_dual>; > status = "okay"; > diff --git a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi > index d3c5cdeff47f..3b906f4db907 100644 > --- a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi > @@ -1560,6 +1560,16 @@ > samsung,syscon-phandle = <&pmu_system_controller>; > samsung,cluster-index = <1>; > }; > + > + pwm: pwm@103f0000 { > + compatible = "samsung,exynosautov9-pwm", > + "samsung,exynos4210-pwm"; It does not look like you tested the DTS against bindings. Please run `make dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions). Full DT schema compliance is a requirement for Samsung (since some time). Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts index 898c2fc345ed..e717bb1cad81 100644 --- a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts +++ b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts @@ -50,6 +50,12 @@ }; }; +&pwm { + pinctrl-names = "default"; + pinctrl-0 = <&pwm_tout3>; + status = "okay"; +}; + &serial_0 { pinctrl-0 = <&uart0_bus_dual>; status = "okay"; diff --git a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi index d3c5cdeff47f..3b906f4db907 100644 --- a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi +++ b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi @@ -1560,6 +1560,16 @@ samsung,syscon-phandle = <&pmu_system_controller>; samsung,cluster-index = <1>; }; + + pwm: pwm@103f0000 { + compatible = "samsung,exynosautov9-pwm", + "samsung,exynos4210-pwm"; + reg = <0x103f0000 0x100>; + samsung,pwm-outputs = <0>, <1>, <2>, <3>; + #pwm-cells = <3>; + clocks = <&xtcxo>; + clock-names = "timers"; + }; }; };
Add pwm node to support fan on exynosautov9-sadk board. PWM channel 3 of ExynosAutov9 is connected to fan for SoC cooling in SADK board. Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com> --- Changes in v3: - removed adding compatible to driver. Changes in v2: - add compatible string to driver. --- arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts | 6 ++++++ arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 10 ++++++++++ 2 files changed, 16 insertions(+)