mbox series

[net-next,0/3] clean up the FEC driver

Message ID 20230718090928.2654347-1-wei.fang@nxp.com (mailing list archive)
Headers show
Series clean up the FEC driver | expand

Message

Wei Fang July 18, 2023, 9:09 a.m. UTC 
When reading the codes of the FEC driver recently, I found there are
some redundant or invalid codes, these codes make the FEC driver a
bit messy and not concise, so this patch set has cleaned up the FEC
driver. At present, I only found these, but I believe these are not
all, I will continue to clean up the FEC driver in the future.

Wei Fang (3):
  net: fec: remove the remaining code of rx copybreak
  net: fec: remove fec_set_mac_address() from fec_enet_init()
  net: fec: remove unused members from struct fec_enet_private

 drivers/net/ethernet/freescale/fec.h      |  5 ---
 drivers/net/ethernet/freescale/fec_main.c | 46 -----------------------
 2 files changed, 51 deletions(-)

Comments

Simon Horman July 19, 2023, 8:45 p.m. UTC | #1 
On Tue, Jul 18, 2023 at 05:09:25PM +0800, Wei Fang wrote:
> When reading the codes of the FEC driver recently, I found there are
> some redundant or invalid codes, these codes make the FEC driver a
> bit messy and not concise, so this patch set has cleaned up the FEC
> driver. At present, I only found these, but I believe these are not
> all, I will continue to clean up the FEC driver in the future.
> 
> Wei Fang (3):
>   net: fec: remove the remaining code of rx copybreak
>   net: fec: remove fec_set_mac_address() from fec_enet_init()
>   net: fec: remove unused members from struct fec_enet_private

Reviewed-by: Simon Horman <simon.horman@corigine.com>
patchwork-bot+netdevbpf@kernel.org July 20, 2023, 4:10 a.m. UTC | #2 
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 18 Jul 2023 17:09:25 +0800 you wrote:
> When reading the codes of the FEC driver recently, I found there are
> some redundant or invalid codes, these codes make the FEC driver a
> bit messy and not concise, so this patch set has cleaned up the FEC
> driver. At present, I only found these, but I believe these are not
> all, I will continue to clean up the FEC driver in the future.
> 
> Wei Fang (3):
>   net: fec: remove the remaining code of rx copybreak
>   net: fec: remove fec_set_mac_address() from fec_enet_init()
>   net: fec: remove unused members from struct fec_enet_private
> 
> [...]

Here is the summary with links:
  - [net-next,1/3] net: fec: remove the remaining code of rx copybreak
    https://git.kernel.org/netdev/net-next/c/3b23ecd53ab5
  - [net-next,2/3] net: fec: remove fec_set_mac_address() from fec_enet_init()
    https://git.kernel.org/netdev/net-next/c/36bde9c1accb
  - [net-next,3/3] net: fec: remove unused members from struct fec_enet_private
    https://git.kernel.org/netdev/net-next/c/636a5e88233a

You are awesome, thank you!