| Message ID | 20230720115351.2039431-1-shikemeng@huaweicloud.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Two minor cleanups for compaction | expand |
On 7/20/2023 7:53 PM, Kemeng Shi wrote: > Hi all, this series contains two random cleanups for compaction. > Patch 1 correct wrong comment in fast_isolate_freepages. > Patch 2 avoid to call unneeded pageblock_end_pfn when no_set_skip_hint > is set. > Thanks! I only received the patch 2 in this patch set, and I checked the lore archives[1], still did not find patch 1. You missed patch 1? [1] https://lore.kernel.org/linux-mm/20230720115351.2039431-1-shikemeng@huaweicloud.com/ > > Kemeng Shi (2): > mm/compaction: correct comment of candidate pfn in > fast_isolate_freepages > mm/compaction: avoid unneeded pageblock_end_pfn when no_set_skip_hint > is set > > mm/compaction.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >
on 7/20/2023 2:08 PM, Baolin Wang wrote: > > > On 7/20/2023 7:53 PM, Kemeng Shi wrote: >> Hi all, this series contains two random cleanups for compaction. >> Patch 1 correct wrong comment in fast_isolate_freepages. >> Patch 2 avoid to call unneeded pageblock_end_pfn when no_set_skip_hint >> is set. >> Thanks! > > I only received the patch 2 in this patch set, and I checked the lore > archives[1], still did not find patch 1. You missed patch 1? > > [1] https://lore.kernel.org/linux-mm/20230720115351.2039431-1-shikemeng@huaweicloud.com/ > >> >> Kemeng Shi (2): >> mm/compaction: correct comment of candidate pfn in >> fast_isolate_freepages >> mm/compaction: avoid unneeded pageblock_end_pfn when no_set_skip_hint >> is set >> >> mm/compaction.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> > > Hi Baolin, thanks for the review and for reminding me of this. I can recive the patch 1 in my mail client. There maybe some problem in my mail server. I also found there is a whole patchset I have sent is missing in lcore archives. I will try to resend these patches. Thanks a lot.
Hi Baolin, I try to resend a new v2 patchset, the patch 1 is still missing. Here is the patch 1 in old version and I find it in lore archive of lore.kernel.org with link [1]. It's likely that patch 1 is denied by linux-mm.kvack.org but accepted by linux-kernel@vger.kernel.org. Is anyone know how to submit issue of linux-mm.kvack.org, please let know. Thanks! [1] https://lore.kernel.org/all/20230720115351.2039431-2-shikemeng@huaweicloud.com/ on 7/20/2023 7:53 PM, Kemeng Shi wrote: > If no preferred one was not found, we will use candidate page with maximum > pfn > min_pfn which is saved in high_pfn. Correct "minimum" to "maximum > candidate" in comment. > > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> > --- > mm/compaction.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index eb1d3d9a422c..c0d8d08fc163 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1526,7 +1526,7 @@ static void fast_isolate_freepages(struct compact_control *cc) > break; > } > > - /* Use a minimum pfn if a preferred one was not found */ > + /* Use a maximum candidate pfn if a preferred one was not found */ > if (!page && high_pfn) { > page = pfn_to_page(high_pfn); > >
Hi all, this series contains two random cleanups for compaction. Patch 1 correct wrong comment in fast_isolate_freepages. Patch 2 avoid to call unneeded pageblock_end_pfn when no_set_skip_hint is set. Thanks! Kemeng Shi (2): mm/compaction: correct comment of candidate pfn in fast_isolate_freepages mm/compaction: avoid unneeded pageblock_end_pfn when no_set_skip_hint is set mm/compaction.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)