diff mbox series

[2/2] ASoC: rt1316: fix key tone missing

Message ID 20230721081807.113125-1-shumingf@realtek.com (mailing list archive)
State New, archived
Headers show
Series [1/2] ASoC: rt1316: support the different base clock frequency | expand

Commit Message

Shuming [范書銘] July 21, 2023, 8:18 a.m. UTC 
From: Shuming Fan <shumingf@realtek.com>

This patch disables the soft ramp to output immediately.

Signed-off-by: Shuming Fan <shumingf@realtek.com>
---
 sound/soc/codecs/rt1316-sdw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown July 21, 2023, 11:18 a.m. UTC | #1 
On Fri, Jul 21, 2023 at 04:18:07PM +0800, shumingf@realtek.com wrote:
> From: Shuming Fan <shumingf@realtek.com>
> 
> This patch disables the soft ramp to output immediately.

>  	{ 0xc09d, 0x80 },
>  	{ 0xc0b0, 0x77 },
> -	{ 0xc010, 0xa5 },
> +	{ 0xc010, 0x25 },
>  	{ 0xc050, 0x83 },

This should probably be an actual control not something patched into the
registers - some users might prefer toe soft ramp.
Shuming [范書銘] July 21, 2023, 3:34 p.m. UTC | #2 
> > From: Shuming Fan <shumingf@realtek.com>
> >
> > This patch disables the soft ramp to output immediately.
> 
> >  	{ 0xc09d, 0x80 },
> >  	{ 0xc0b0, 0x77 },
> > -	{ 0xc010, 0xa5 },
> > +	{ 0xc010, 0x25 },
> >  	{ 0xc050, 0x83 },
> 
> This should probably be an actual control not something patched into the
> registers - some users might prefer toe soft ramp.

Got it. I will add a mixer control for it. Thanks.

> ------Please consider the environment before printing this e-mail.
diff mbox series

Patch

diff --git a/sound/soc/codecs/rt1316-sdw.c b/sound/soc/codecs/rt1316-sdw.c
index ce2246a2591c..feea11149d93 100644
--- a/sound/soc/codecs/rt1316-sdw.c
+++ b/sound/soc/codecs/rt1316-sdw.c
@@ -134,7 +134,7 @@  static const struct reg_sequence rt1316_blind_write[] = {
 	{ 0xc093, 0x80 },
 	{ 0xc09d, 0x80 },
 	{ 0xc0b0, 0x77 },
-	{ 0xc010, 0xa5 },
+	{ 0xc010, 0x25 },
 	{ 0xc050, 0x83 },
 	{ 0x2f55, 0x03 },
 	{ 0x3217, 0xb5 },