[v1,0/8] iio: core: A few code cleanups and documentation fixes

Message

Andy Shevchenko July 20, 2023, 8:53 p.m. UTC

Just set of almost unrelated to each other cleanups against IIO
core implementation.

The positive LoCs diffstat due to first patch that adds a lot of
documentation for the new added macro.

Andy Shevchenko (8):
  iio: core: Add opaque_struct_size() helper and use it
  iio: core: Use sysfs_match_string() helper
  iio: core: Switch to krealloc_array()
  iio: core: Use min() instead of min_t() to make code more robust
  iio: core: Get rid of redundant 'else'
  iio: core: Fix issues and style of the comments
  iio: core: Move initcalls closer to the respective calls
  iio: core: Improve indentation in a few places

 drivers/iio/industrialio-core.c | 226 ++++++++++++++++----------------
 1 file changed, 115 insertions(+), 111 deletions(-)

Comments

Nuno Sá July 21, 2023, 8:06 a.m. UTC | #1

On Thu, 2023-07-20 at 23:53 +0300, Andy Shevchenko wrote:
> Just set of almost unrelated to each other cleanups against IIO
> core implementation.
> 
> The positive LoCs diffstat due to first patch that adds a lot of
> documentation for the new added macro.
> 
> Andy Shevchenko (8):
>   iio: core: Add opaque_struct_size() helper and use it
>   iio: core: Use sysfs_match_string() helper
>   iio: core: Switch to krealloc_array()
>   iio: core: Use min() instead of min_t() to make code more robust
>   iio: core: Get rid of redundant 'else'
>   iio: core: Fix issues and style of the comments
>   iio: core: Move initcalls closer to the respective calls
>   iio: core: Improve indentation in a few places
> 
>  drivers/iio/industrialio-core.c | 226 ++++++++++++++++----------------
>  1 file changed, 115 insertions(+), 111 deletions(-)
> 

Neat series... Just a few comments on my side and on patch 3 is up to you to
take the comments or not.

With my comment addressed on patch 2:

Reviewed-by: Nuno Sa <[e-mail]>

Andy Shevchenko July 21, 2023, 10:15 a.m. UTC | #2

On Fri, Jul 21, 2023 at 10:06:05AM +0200, Nuno Sá wrote:
> On Thu, 2023-07-20 at 23:53 +0300, Andy Shevchenko wrote:
> > Just set of almost unrelated to each other cleanups against IIO
> > core implementation.
> > 
> > The positive LoCs diffstat due to first patch that adds a lot of
> > documentation for the new added macro.
> > 
> > Andy Shevchenko (8):
> >   iio: core: Add opaque_struct_size() helper and use it
> >   iio: core: Use sysfs_match_string() helper
> >   iio: core: Switch to krealloc_array()
> >   iio: core: Use min() instead of min_t() to make code more robust
> >   iio: core: Get rid of redundant 'else'
> >   iio: core: Fix issues and style of the comments
> >   iio: core: Move initcalls closer to the respective calls
> >   iio: core: Improve indentation in a few places
> > 
> >  drivers/iio/industrialio-core.c | 226 ++++++++++++++++----------------
> >  1 file changed, 115 insertions(+), 111 deletions(-)
> > 
> 
> Neat series... Just a few comments on my side and on patch 3 is up to you to
> take the comments or not.
> 
> With my comment addressed on patch 2:

Agree, I won't change patch 3 for now, I replied there why.

> Reviewed-by: Nuno Sa <[e-mail]>

Thank you! I'll embed this into v2.

Andy Shevchenko July 21, 2023, 4:55 p.m. UTC | #3

On Fri, Jul 21, 2023 at 10:06:05AM +0200, Nuno Sá wrote:
> On Thu, 2023-07-20 at 23:53 +0300, Andy Shevchenko wrote:

...

> Reviewed-by: Nuno Sa <[e-mail]>

Btw, is it deliberately you don't put accent on "a"?

Andy Shevchenko July 21, 2023, 4:57 p.m. UTC | #4

On Fri, Jul 21, 2023 at 07:55:22PM +0300, Andy Shevchenko wrote:
> On Fri, Jul 21, 2023 at 10:06:05AM +0200, Nuno Sá wrote:
> > On Thu, 2023-07-20 at 23:53 +0300, Andy Shevchenko wrote:

...

> > Reviewed-by: Nuno Sa <[e-mail]>
> 
> Btw, is it deliberately you don't put accent on "a"?

So far in the upstream it had been started from f1caa90085ef ("iio: dac:
set variable max5522_channels storage-class-specifier to static").