| Message ID | 4FFB40A4.5060505@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Jul 9, 2012 at 10:35 PM, Lee Jones <lee.jones@linaro.org> wrote: > From: Lee Jones <lee.jones@linaro.org> > Date: Tue, 26 Jun 2012 10:46:50 +0100 > Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping > > Before we can use any domain allocated IRQ, we need to first create a > map between the Hardware IRQ (hwirq) and the Linux Virtual IRQ (virq). > We do this with a helper function provided by the AB8500 IRQ domain > controller called ab8500_irq_get_virq(). We need to do this for both > IRQs which the Power-On-Key driver uses; one for button press, the other > for button depress. > > Signed-off-by: Lee Jones <lee.jones@linaro.org> Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On 09/07/12 22:37, Linus Walleij wrote: > On Mon, Jul 9, 2012 at 10:35 PM, Lee Jones <lee.jones@linaro.org> wrote: > >> From: Lee Jones <lee.jones@linaro.org> >> Date: Tue, 26 Jun 2012 10:46:50 +0100 >> Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping >> >> Before we can use any domain allocated IRQ, we need to first create a >> map between the Hardware IRQ (hwirq) and the Linux Virtual IRQ (virq). >> We do this with a helper function provided by the AB8500 IRQ domain >> controller called ab8500_irq_get_virq(). We need to do this for both >> IRQs which the Power-On-Key driver uses; one for button press, the other >> for button depress. >> >> Signed-off-by: Lee Jones <lee.jones@linaro.org> > > Acked-by: Linus Walleij <linus.walleij@linaro.org> I've just sent a new one following Dmitry's suggestion.
On Mon, Jul 09, 2012 at 10:35:48PM +0200, Lee Jones wrote: > From: Lee Jones <lee.jones@linaro.org> > Date: Tue, 26 Jun 2012 10:46:50 +0100 > Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping > > Before we can use any domain allocated IRQ, we need to first create a > map between the Hardware IRQ (hwirq) and the Linux Virtual IRQ (virq). > We do this with a helper function provided by the AB8500 IRQ domain > controller called ab8500_irq_get_virq(). We need to do this for both > IRQs which the Power-On-Key driver uses; one for button press, the other > for button depress. > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/input/misc/ab8500-ponkey.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/misc/ab8500-ponkey.c b/drivers/input/misc/ab8500-ponkey.c > index 5ceb23e..8d24189 100644 > --- a/drivers/input/misc/ab8500-ponkey.c > +++ b/drivers/input/misc/ab8500-ponkey.c > @@ -74,8 +74,8 @@ static int __devinit ab8500_ponkey_probe(struct platform_device *pdev) > > ponkey->idev = input; > ponkey->ab8500 = ab8500; > - ponkey->irq_dbf = irq_dbf; > - ponkey->irq_dbr = irq_dbr; > + ponkey->irq_dbf = ab8500_irq_get_virq(ab8500, ponkey->irq_dbf); > + ponkey->irq_dbr = ab8500_irq_get_virq(ab8500, ponkey->irq_dbr); ^^^^^^^^^^^^^^^ These are zeroes now. Man, you are killing me...
On 09/07/12 22:46, Dmitry Torokhov wrote: > On Mon, Jul 09, 2012 at 10:35:48PM +0200, Lee Jones wrote: >> From: Lee Jones <lee.jones@linaro.org> >> Date: Tue, 26 Jun 2012 10:46:50 +0100 >> Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping >> >> Before we can use any domain allocated IRQ, we need to first create a >> map between the Hardware IRQ (hwirq) and the Linux Virtual IRQ (virq). >> We do this with a helper function provided by the AB8500 IRQ domain >> controller called ab8500_irq_get_virq(). We need to do this for both >> IRQs which the Power-On-Key driver uses; one for button press, the other >> for button depress. >> >> Signed-off-by: Lee Jones <lee.jones@linaro.org> >> --- >> drivers/input/misc/ab8500-ponkey.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/input/misc/ab8500-ponkey.c b/drivers/input/misc/ab8500-ponkey.c >> index 5ceb23e..8d24189 100644 >> --- a/drivers/input/misc/ab8500-ponkey.c >> +++ b/drivers/input/misc/ab8500-ponkey.c >> @@ -74,8 +74,8 @@ static int __devinit ab8500_ponkey_probe(struct platform_device *pdev) >> >> ponkey->idev = input; >> ponkey->ab8500 = ab8500; >> - ponkey->irq_dbf = irq_dbf; >> - ponkey->irq_dbr = irq_dbr; >> + ponkey->irq_dbf = ab8500_irq_get_virq(ab8500, ponkey->irq_dbf); >> + ponkey->irq_dbr = ab8500_irq_get_virq(ab8500, ponkey->irq_dbr); > ^^^^^^^^^^^^^^^ > > These are zeroes now. Man, you are killing me... I've been traveling all day and my brain is dead. Hopefully you have a sense of humor. :) Give me two mins.
diff --git a/drivers/input/misc/ab8500-ponkey.c b/drivers/input/misc/ab8500-ponkey.c index 5ceb23e..8d24189 100644 --- a/drivers/input/misc/ab8500-ponkey.c +++ b/drivers/input/misc/ab8500-ponkey.c @@ -74,8 +74,8 @@ static int __devinit ab8500_ponkey_probe(struct platform_device *pdev) ponkey->idev = input; ponkey->ab8500 = ab8500; - ponkey->irq_dbf = irq_dbf; - ponkey->irq_dbr = irq_dbr; + ponkey->irq_dbf = ab8500_irq_get_virq(ab8500, ponkey->irq_dbf); + ponkey->irq_dbr = ab8500_irq_get_virq(ab8500, ponkey->irq_dbr); input->name = "AB8500 POn(PowerOn) Key"; input->dev.parent = &pdev->dev;