diff mbox series

drm/panel: ld9040: add backlight Kconfig dependency

Message ID 20230724121736.1293270-1-arnd@kernel.org (mailing list archive)
State New, archived
Headers show
Series drm/panel: ld9040: add backlight Kconfig dependency | expand

Commit Message

Arnd Bergmann July 24, 2023, 12:17 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

The driver now uses the backlight interface, which breaks when that
is disabled:

ld.lld: error: undefined symbol: devm_backlight_device_register

Enforce the necessary Kconfig dependency to avoid this.

Fixes: c2268daa65fb4 ("drm/panel: ld9040: Register a backlight device")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpu/drm/panel/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Sam Ravnborg July 24, 2023, 5:11 p.m. UTC | #1 
On Mon, Jul 24, 2023 at 02:17:05PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The driver now uses the backlight interface, which breaks when that
> is disabled:
> 
> ld.lld: error: undefined symbol: devm_backlight_device_register
> 
> Enforce the necessary Kconfig dependency to avoid this.
> 
> Fixes: c2268daa65fb4 ("drm/panel: ld9040: Register a backlight device")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

I expect that someone else with drm-misc rights apply the patch.

	Sam
Paul Cercueil July 24, 2023, 10:45 p.m. UTC | #2 
Hi,

Le lundi 24 juillet 2023 à 19:11 +0200, Sam Ravnborg a écrit :
> On Mon, Jul 24, 2023 at 02:17:05PM +0200, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> > 
> > The driver now uses the backlight interface, which breaks when that
> > is disabled:
> > 
> > ld.lld: error: undefined symbol: devm_backlight_device_register
> > 
> > Enforce the necessary Kconfig dependency to avoid this.
> > 
> > Fixes: c2268daa65fb4 ("drm/panel: ld9040: Register a backlight
> > device")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> 
> I expect that someone else with drm-misc rights apply the patch.

Pushed to drm-misc-next.

Thanks,
-Paul
diff mbox series

Patch

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index e8c9f4613a4b4..b097b2507ac5b 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -300,6 +300,7 @@  config DRM_PANEL_LEADTEK_LTK500HD1829
 config DRM_PANEL_SAMSUNG_LD9040
 	tristate "Samsung LD9040 RGB/SPI panel"
 	depends on OF && SPI
+	depends on BACKLIGHT_CLASS_DEVICE
 	select VIDEOMODE_HELPERS
 
 config DRM_PANEL_LG_LB035Q02