| Message ID | 1689934361-32642-1-git-send-email-quic_srichara@quicinc.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | pinctrl: qcom: Remove the unused _groups variable build warning | expand |
On Fri, Jul 21, 2023 at 3:13 AM Sricharan Ramabadhran <quic_srichara@quicinc.com> wrote: > > When building with clang toolchain and arm64-randconfig-r015-20230712 > kernel test robot reports the below warning. > > drivers/pinctrl/qcom/pinctrl-ipq5018.c:244:27: warning: unused variable '_groups' [-Wunused-const-variable] > static const char * const _groups[] = { > ^ > 1 warning generated. > > static const char * const _groups[] = { > "gpio0", "gpio1", "gpio2", "gpio3", "gpio4", "gpio5", "gpio6", "gpio7", > "gpio8", "gpio9", "gpio10", "gpio11", "gpio12", "gpio13", "gpio14", > "gpio15", "gpio16", "gpio17", "gpio18", "gpio19", "gpio20", "gpio21", > "gpio22", "gpio23", "gpio24", "gpio25", "gpio26", "gpio27", "gpio28", > "gpio29", "gpio30", "gpio31", "gpio32", "gpio33", "gpio34", "gpio35", > "gpio36", "gpio37", "gpio38", "gpio39", "gpio40", "gpio41", "gpio42", > "gpio43", "gpio44", "gpio45", "gpio46", > }; > > Fixing it by removing the variable. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202307120814.vWPY6URk-lkp@intel.com/ > Fixes: 725d1c891658 ("pinctrl: qcom: Add IPQ5018 pinctrl driver") > Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> Thanks for the patch! Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > --- > drivers/pinctrl/qcom/pinctrl-ipq5018.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-ipq5018.c b/drivers/pinctrl/qcom/pinctrl-ipq5018.c > index ed58f75..e2951f8 100644 > --- a/drivers/pinctrl/qcom/pinctrl-ipq5018.c > +++ b/drivers/pinctrl/qcom/pinctrl-ipq5018.c > @@ -241,16 +241,6 @@ static const char * const atest_char_groups[] = { > "gpio0", "gpio1", "gpio2", "gpio3", "gpio37", > }; > > -static const char * const _groups[] = { > - "gpio0", "gpio1", "gpio2", "gpio3", "gpio4", "gpio5", "gpio6", "gpio7", > - "gpio8", "gpio9", "gpio10", "gpio11", "gpio12", "gpio13", "gpio14", > - "gpio15", "gpio16", "gpio17", "gpio18", "gpio19", "gpio20", "gpio21", > - "gpio22", "gpio23", "gpio24", "gpio25", "gpio26", "gpio27", "gpio28", > - "gpio29", "gpio30", "gpio31", "gpio32", "gpio33", "gpio34", "gpio35", > - "gpio36", "gpio37", "gpio38", "gpio39", "gpio40", "gpio41", "gpio42", > - "gpio43", "gpio44", "gpio45", "gpio46", > -}; > - > static const char * const wci_txd_groups[] = { > "gpio0", "gpio1", "gpio2", "gpio3", > "gpio42", "gpio43", "gpio44", "gpio45", > -- > 2.7.4 > >
On 21/07/2023 12:12, Sricharan Ramabadhran wrote: > When building with clang toolchain and arm64-randconfig-r015-20230712 > kernel test robot reports the below warning. > > drivers/pinctrl/qcom/pinctrl-ipq5018.c:244:27: warning: unused variable '_groups' [-Wunused-const-variable] > static const char * const _groups[] = { > ^ > 1 warning generated. > > static const char * const _groups[] = { > "gpio0", "gpio1", "gpio2", "gpio3", "gpio4", "gpio5", "gpio6", "gpio7", > "gpio8", "gpio9", "gpio10", "gpio11", "gpio12", "gpio13", "gpio14", > "gpio15", "gpio16", "gpio17", "gpio18", "gpio19", "gpio20", "gpio21", > "gpio22", "gpio23", "gpio24", "gpio25", "gpio26", "gpio27", "gpio28", > "gpio29", "gpio30", "gpio31", "gpio32", "gpio33", "gpio34", "gpio35", > "gpio36", "gpio37", "gpio38", "gpio39", "gpio40", "gpio41", "gpio42", > "gpio43", "gpio44", "gpio45", "gpio46", > }; > > Fixing it by removing the variable. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202307120814.vWPY6URk-lkp@intel.com/ > Fixes: 725d1c891658 ("pinctrl: qcom: Add IPQ5018 pinctrl driver") > Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> This seems to be a duplicate of gpio_groups, so: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Fri, Jul 21, 2023 at 12:13 PM Sricharan Ramabadhran <quic_srichara@quicinc.com> wrote: > When building with clang toolchain and arm64-randconfig-r015-20230712 > kernel test robot reports the below warning. > > drivers/pinctrl/qcom/pinctrl-ipq5018.c:244:27: warning: unused variable '_groups' [-Wunused-const-variable] > static const char * const _groups[] = { > ^ > 1 warning generated. > > static const char * const _groups[] = { > "gpio0", "gpio1", "gpio2", "gpio3", "gpio4", "gpio5", "gpio6", "gpio7", > "gpio8", "gpio9", "gpio10", "gpio11", "gpio12", "gpio13", "gpio14", > "gpio15", "gpio16", "gpio17", "gpio18", "gpio19", "gpio20", "gpio21", > "gpio22", "gpio23", "gpio24", "gpio25", "gpio26", "gpio27", "gpio28", > "gpio29", "gpio30", "gpio31", "gpio32", "gpio33", "gpio34", "gpio35", > "gpio36", "gpio37", "gpio38", "gpio39", "gpio40", "gpio41", "gpio42", > "gpio43", "gpio44", "gpio45", "gpio46", > }; > > Fixing it by removing the variable. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202307120814.vWPY6URk-lkp@intel.com/ > Fixes: 725d1c891658 ("pinctrl: qcom: Add IPQ5018 pinctrl driver") > Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> Patch applied, thanks for fixing this! Yours, Linus Walleij
diff --git a/drivers/pinctrl/qcom/pinctrl-ipq5018.c b/drivers/pinctrl/qcom/pinctrl-ipq5018.c index ed58f75..e2951f8 100644 --- a/drivers/pinctrl/qcom/pinctrl-ipq5018.c +++ b/drivers/pinctrl/qcom/pinctrl-ipq5018.c @@ -241,16 +241,6 @@ static const char * const atest_char_groups[] = { "gpio0", "gpio1", "gpio2", "gpio3", "gpio37", }; -static const char * const _groups[] = { - "gpio0", "gpio1", "gpio2", "gpio3", "gpio4", "gpio5", "gpio6", "gpio7", - "gpio8", "gpio9", "gpio10", "gpio11", "gpio12", "gpio13", "gpio14", - "gpio15", "gpio16", "gpio17", "gpio18", "gpio19", "gpio20", "gpio21", - "gpio22", "gpio23", "gpio24", "gpio25", "gpio26", "gpio27", "gpio28", - "gpio29", "gpio30", "gpio31", "gpio32", "gpio33", "gpio34", "gpio35", - "gpio36", "gpio37", "gpio38", "gpio39", "gpio40", "gpio41", "gpio42", - "gpio43", "gpio44", "gpio45", "gpio46", -}; - static const char * const wci_txd_groups[] = { "gpio0", "gpio1", "gpio2", "gpio3", "gpio42", "gpio43", "gpio44", "gpio45",
When building with clang toolchain and arm64-randconfig-r015-20230712 kernel test robot reports the below warning. drivers/pinctrl/qcom/pinctrl-ipq5018.c:244:27: warning: unused variable '_groups' [-Wunused-const-variable] static const char * const _groups[] = { ^ 1 warning generated. static const char * const _groups[] = { "gpio0", "gpio1", "gpio2", "gpio3", "gpio4", "gpio5", "gpio6", "gpio7", "gpio8", "gpio9", "gpio10", "gpio11", "gpio12", "gpio13", "gpio14", "gpio15", "gpio16", "gpio17", "gpio18", "gpio19", "gpio20", "gpio21", "gpio22", "gpio23", "gpio24", "gpio25", "gpio26", "gpio27", "gpio28", "gpio29", "gpio30", "gpio31", "gpio32", "gpio33", "gpio34", "gpio35", "gpio36", "gpio37", "gpio38", "gpio39", "gpio40", "gpio41", "gpio42", "gpio43", "gpio44", "gpio45", "gpio46", }; Fixing it by removing the variable. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202307120814.vWPY6URk-lkp@intel.com/ Fixes: 725d1c891658 ("pinctrl: qcom: Add IPQ5018 pinctrl driver") Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> --- drivers/pinctrl/qcom/pinctrl-ipq5018.c | 10 ---------- 1 file changed, 10 deletions(-)