| Message ID | 20230723161029.1345-8-jszhang@kernel.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: stmmac: add new features to xgmac | expand |
| Context | Check | Description |
|---|---|---|
| netdev/series_format | success | Posting correctly formatted |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 9 this patch: 9 |
| netdev/cc_maintainers | success | CCed 12 of 12 maintainers |
| netdev/build_clang | success | Errors and warnings before: 9 this patch: 9 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/deprecated_api | success | None detected |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 9 this patch: 9 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 16 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On Mon, Jul 24, 2023 at 12:10:26AM +0800, Jisheng Zhang wrote: > The snps dwmac IP support safety features, and those Safety Feature > Correctible Error and Uncorrectible Error irqs may be separate irqs. > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org> > --- > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index ddf9522a5dc2..bb80ca205d26 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -107,6 +107,8 @@ properties: > - description: Combined signal for various interrupt events > - description: The interrupt to manage the remote wake-up packet detection > - description: The interrupt that occurs when Rx exits the LPI state > + - description: The interrupt that occurs when Safety Feature Correctible Errors happen > + - description: The interrupt that occurs when Safety Feature Uncorrectible Errors happen > > interrupt-names: > minItems: 1 > @@ -114,6 +116,8 @@ properties: > - const: macirq > - enum: [eth_wake_irq, eth_lpi] > - const: eth_lpi > + - const: sfty_ce_irq > + - const: sfty_ue_irq Putting _irq in an interrupt name seems rather redundant to me although, clearly not the first time for it here. Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor.
On Mon, Jul 24, 2023 at 06:23:13PM +0100, Conor Dooley wrote: > On Mon, Jul 24, 2023 at 12:10:26AM +0800, Jisheng Zhang wrote: > > The snps dwmac IP support safety features, and those Safety Feature > > Correctible Error and Uncorrectible Error irqs may be separate irqs. > > > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org> > > --- > > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > index ddf9522a5dc2..bb80ca205d26 100644 > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > @@ -107,6 +107,8 @@ properties: > > - description: Combined signal for various interrupt events > > - description: The interrupt to manage the remote wake-up packet detection > > - description: The interrupt that occurs when Rx exits the LPI state > > + - description: The interrupt that occurs when Safety Feature Correctible Errors happen > > + - description: The interrupt that occurs when Safety Feature Uncorrectible Errors happen > > > > interrupt-names: > > minItems: 1 > > @@ -114,6 +116,8 @@ properties: > > - const: macirq > > - enum: [eth_wake_irq, eth_lpi] > > - const: eth_lpi > > + - const: sfty_ce_irq > > + - const: sfty_ue_irq > > Putting _irq in an interrupt name seems rather redundant to me although, > clearly not the first time for it here. It's already inconsistent, so don't follow that pattern. Drop '_irq'. > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Thanks, > Conor.
On Mon, Jul 24, 2023 at 05:26:24PM -0600, Rob Herring wrote: > On Mon, Jul 24, 2023 at 06:23:13PM +0100, Conor Dooley wrote: > > On Mon, Jul 24, 2023 at 12:10:26AM +0800, Jisheng Zhang wrote: > > > The snps dwmac IP support safety features, and those Safety Feature > > > Correctible Error and Uncorrectible Error irqs may be separate irqs. > > > > > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org> > > > --- > > > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > index ddf9522a5dc2..bb80ca205d26 100644 > > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > @@ -107,6 +107,8 @@ properties: > > > - description: Combined signal for various interrupt events > > > - description: The interrupt to manage the remote wake-up packet detection > > > - description: The interrupt that occurs when Rx exits the LPI state > > > + - description: The interrupt that occurs when Safety Feature Correctible Errors happen > > > + - description: The interrupt that occurs when Safety Feature Uncorrectible Errors happen > > > > > > interrupt-names: > > > minItems: 1 > > > @@ -114,6 +116,8 @@ properties: > > > - const: macirq > > > - enum: [eth_wake_irq, eth_lpi] > > > - const: eth_lpi > > > + - const: sfty_ce_irq > > > + - const: sfty_ue_irq > > > > Putting _irq in an interrupt name seems rather redundant to me although, > > clearly not the first time for it here. > > It's already inconsistent, so don't follow that pattern. Drop '_irq'. Thanks for the suggestion, will wait a bit to get more feedbacks before sending out v2. > > > > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > > > Thanks, > > Conor. > >
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index ddf9522a5dc2..bb80ca205d26 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -107,6 +107,8 @@ properties: - description: Combined signal for various interrupt events - description: The interrupt to manage the remote wake-up packet detection - description: The interrupt that occurs when Rx exits the LPI state + - description: The interrupt that occurs when Safety Feature Correctible Errors happen + - description: The interrupt that occurs when Safety Feature Uncorrectible Errors happen interrupt-names: minItems: 1 @@ -114,6 +116,8 @@ properties: - const: macirq - enum: [eth_wake_irq, eth_lpi] - const: eth_lpi + - const: sfty_ce_irq + - const: sfty_ue_irq clocks: minItems: 1
The snps dwmac IP support safety features, and those Safety Feature Correctible Error and Uncorrectible Error irqs may be separate irqs. Signed-off-by: Jisheng Zhang <jszhang@kernel.org> --- Documentation/devicetree/bindings/net/snps,dwmac.yaml | 4 ++++ 1 file changed, 4 insertions(+)