| Message ID | 1e8b998aa8dcc6e38323e295ee2430b48245cc79.1690299794.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 73365fe44aa52fcd3e634e502937eb029abd0ee0 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] bcmasp: BCMASP should depend on ARCH_BRCMSTB | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net |
| netdev/apply | fail | Patch does not apply to net |
On Tue, Jul 25, 2023 at 05:46:37PM +0200, Geert Uytterhoeven wrote: > The Broadcom ASP 2.0 Ethernet controller is only present on Broadcom STB > SoCs. Hence add a dependency on ARCH_BRCMSTB, to prevent asking the > user about this driver when configuring a kernel without Broadcom > ARM-based set-top box chipset support. > > Fixes: 490cb412007de593 ("net: bcmasp: Add support for ASP2.0 Ethernet controller") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Simon Horman <simon.horman@corigine.com>
On 7/25/2023 8:46 AM, Geert Uytterhoeven wrote: > The Broadcom ASP 2.0 Ethernet controller is only present on Broadcom STB > SoCs. Hence add a dependency on ARCH_BRCMSTB, to prevent asking the > user about this driver when configuring a kernel without Broadcom > ARM-based set-top box chipset support. > > Fixes: 490cb412007de593 ("net: bcmasp: Add support for ASP2.0 Ethernet controller") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Florian Fainelli <florian.fainelli@broadcom.com>
On 7/25/23 8:46 AM, Geert Uytterhoeven wrote: > The Broadcom ASP 2.0 Ethernet controller is only present on Broadcom STB > SoCs. Hence add a dependency on ARCH_BRCMSTB, to prevent asking the > user about this driver when configuring a kernel without Broadcom > ARM-based set-top box chipset support. > > Fixes: 490cb412007de593 ("net: bcmasp: Add support for ASP2.0 Ethernet controller") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Justin Chen <justin.chen@broadcom.com> > --- > drivers/net/ethernet/broadcom/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig > index d4166141145d631c..75ca3ddda1f5e09f 100644 > --- a/drivers/net/ethernet/broadcom/Kconfig > +++ b/drivers/net/ethernet/broadcom/Kconfig > @@ -257,6 +257,7 @@ config BNXT_HWMON > > config BCMASP > tristate "Broadcom ASP 2.0 Ethernet support" > + depends on ARCH_BRCMSTB || COMPILE_TEST > default ARCH_BRCMSTB > depends on OF > select MII
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 25 Jul 2023 17:46:37 +0200 you wrote: > The Broadcom ASP 2.0 Ethernet controller is only present on Broadcom STB > SoCs. Hence add a dependency on ARCH_BRCMSTB, to prevent asking the > user about this driver when configuring a kernel without Broadcom > ARM-based set-top box chipset support. > > Fixes: 490cb412007de593 ("net: bcmasp: Add support for ASP2.0 Ethernet controller") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > [...] Here is the summary with links: - [net] bcmasp: BCMASP should depend on ARCH_BRCMSTB https://git.kernel.org/netdev/net-next/c/73365fe44aa5 You are awesome, thank you!
diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig index d4166141145d631c..75ca3ddda1f5e09f 100644 --- a/drivers/net/ethernet/broadcom/Kconfig +++ b/drivers/net/ethernet/broadcom/Kconfig @@ -257,6 +257,7 @@ config BNXT_HWMON config BCMASP tristate "Broadcom ASP 2.0 Ethernet support" + depends on ARCH_BRCMSTB || COMPILE_TEST default ARCH_BRCMSTB depends on OF select MII
The Broadcom ASP 2.0 Ethernet controller is only present on Broadcom STB SoCs. Hence add a dependency on ARCH_BRCMSTB, to prevent asking the user about this driver when configuring a kernel without Broadcom ARM-based set-top box chipset support. Fixes: 490cb412007de593 ("net: bcmasp: Add support for ASP2.0 Ethernet controller") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/net/ethernet/broadcom/Kconfig | 1 + 1 file changed, 1 insertion(+)