| Message ID | 20230726070241.103545-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 47d7c25a1bc068c31da7102652163859d3b1af05 |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | AMR: dts: renesas: r8a7740-armadillo: switch to enable-gpios | expand |
On Wed, Jul 26, 2023 at 9:02 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > The recommended name for enable GPIOs property in regulator-gpio is > "enable-gpios". This is also required by bindings: > > r8a7740-armadillo800eva.dtb: regulator-vccq-sdhi0: Unevaluated properties are not allowed ('enable-gpio' was unexpected) > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-devel for v6.6. Gr{oetje,eeting}s, Geert
On 26/07/2023 11:11, Geert Uytterhoeven wrote: > On Wed, Jul 26, 2023 at 9:02 AM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> The recommended name for enable GPIOs property in regulator-gpio is >> "enable-gpios". This is also required by bindings: >> >> r8a7740-armadillo800eva.dtb: regulator-vccq-sdhi0: Unevaluated properties are not allowed ('enable-gpio' was unexpected) >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > i.e. will queue in renesas-devel for v6.6. I think I made typo in subject prefix: AMR -> ARM Can you fix it while applying? Best regards, Krzysztof
Hi Krzysztof, On Wed, Jul 26, 2023 at 11:47 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 26/07/2023 11:11, Geert Uytterhoeven wrote: > > On Wed, Jul 26, 2023 at 9:02 AM Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > >> The recommended name for enable GPIOs property in regulator-gpio is > >> "enable-gpios". This is also required by bindings: > >> > >> r8a7740-armadillo800eva.dtb: regulator-vccq-sdhi0: Unevaluated properties are not allowed ('enable-gpio' was unexpected) > >> > >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > i.e. will queue in renesas-devel for v6.6. > > I think I made typo in subject prefix: > AMR -> ARM I had noticed ;-) > Can you fix it while applying? Sure, already done. Gr{oetje,eeting}s, Geert
diff --git a/arch/arm/boot/dts/renesas/r8a7740-armadillo800eva.dts b/arch/arm/boot/dts/renesas/r8a7740-armadillo800eva.dts index fa09295052c6..d21e00e1f401 100644 --- a/arch/arm/boot/dts/renesas/r8a7740-armadillo800eva.dts +++ b/arch/arm/boot/dts/renesas/r8a7740-armadillo800eva.dts @@ -58,7 +58,7 @@ vccq_sdhi0: regulator-vccq-sdhi0 { regulator-max-microvolt = <3300000>; vin-supply = <&vcc_sdhi0>; - enable-gpio = <&pfc 74 GPIO_ACTIVE_HIGH>; + enable-gpios = <&pfc 74 GPIO_ACTIVE_HIGH>; gpios = <&pfc 17 GPIO_ACTIVE_HIGH>; states = <3300000 0>, <1800000 1>;
The recommended name for enable GPIOs property in regulator-gpio is "enable-gpios". This is also required by bindings: r8a7740-armadillo800eva.dtb: regulator-vccq-sdhi0: Unevaluated properties are not allowed ('enable-gpio' was unexpected) Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm/boot/dts/renesas/r8a7740-armadillo800eva.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)