| Message ID | cover.1690454072.git.aclaudi@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | selftests: fix mptcp_join test | expand |
Hi Andrea, On 27/07/2023 13:08, Andrea Claudi wrote: > This series fixes two mptcp_join testcases when using ip mptcp: > - 'implicit EP' fails because of: > - missing iproute support for mptcp 'implicit' flag, fixed with > iproute2-next commit 3a2535a41854 ("mptcp: add support for implicit > flag") > - pm_nl_check_endpoint expecting two ip addresses, while only one is > present in the iproute output; > - 'delete and re-add' fails because the endpoint delete command > provide both id and ip address, while address should be provided only > if id is 0. > > Changelog: > > v1 -> v2 > - Clearly state test fails only when using ip mptcp, i.e. > ./mptcp_join.sh -i > - Remove test numbers from commit messages > - On endpoint delete, continue to provide $addr when id is 0. Thank you for the v2, it looks good to me! Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net> Just one detail for patch 2/2 for the Fixes tag but I can fix that when applying the patches if needed and if that's OK for you. These patches can be applied in mptcp-net (export-net branch). Cheers, Matt
On Thu, Jul 27, 2023 at 06:52:45PM +0200, Matthieu Baerts wrote: > Hi Andrea, > > On 27/07/2023 13:08, Andrea Claudi wrote: > > This series fixes two mptcp_join testcases when using ip mptcp: > > - 'implicit EP' fails because of: > > - missing iproute support for mptcp 'implicit' flag, fixed with > > iproute2-next commit 3a2535a41854 ("mptcp: add support for implicit > > flag") > > - pm_nl_check_endpoint expecting two ip addresses, while only one is > > present in the iproute output; > > - 'delete and re-add' fails because the endpoint delete command > > provide both id and ip address, while address should be provided only > > if id is 0. > > > > Changelog: > > > > v1 -> v2 > > - Clearly state test fails only when using ip mptcp, i.e. > > ./mptcp_join.sh -i > > - Remove test numbers from commit messages > > - On endpoint delete, continue to provide $addr when id is 0. > > Thank you for the v2, it looks good to me! > > Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net> > > Just one detail for patch 2/2 for the Fixes tag but I can fix that when > applying the patches if needed and if that's OK for you. It's OK for me. Thanks for your review, Matthieu. Regards, Andrea > > These patches can be applied in mptcp-net (export-net branch). > > Cheers, > Matt > -- > Tessares | Belgium | Hybrid Access Solutions > www.tessares.net >
Hi Andrea, On 27/07/2023 13:08, Andrea Claudi wrote: > This series fixes two mptcp_join testcases when using ip mptcp: > - 'implicit EP' fails because of: > - missing iproute support for mptcp 'implicit' flag, fixed with > iproute2-next commit 3a2535a41854 ("mptcp: add support for implicit > flag") > - pm_nl_check_endpoint expecting two ip addresses, while only one is > present in the iproute output; > - 'delete and re-add' fails because the endpoint delete command > provide both id and ip address, while address should be provided only > if id is 0. Thank you for the patches! Now in our tree (fixes for -net) with my RvB tag and the use of the right Fixes tag: New patches for t/upstream-net and t/upstream: - 5013654dafcc: selftests: mptcp: join: fix 'delete and re-add' test - b2b73765f521: selftests: mptcp: join: fix 'implicit EP' test - Results: 401d3a99d2a9..be9e061da26c (export-net) - Results: 570583e20711..c4e88c45e27d (export) Tests are now in progress: https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export-net/20230728T102732 https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20230728T102732 Cheers, Matt
This series fixes two mptcp_join testcases when using ip mptcp: - 'implicit EP' fails because of: - missing iproute support for mptcp 'implicit' flag, fixed with iproute2-next commit 3a2535a41854 ("mptcp: add support for implicit flag") - pm_nl_check_endpoint expecting two ip addresses, while only one is present in the iproute output; - 'delete and re-add' fails because the endpoint delete command provide both id and ip address, while address should be provided only if id is 0. Changelog: v1 -> v2 - Clearly state test fails only when using ip mptcp, i.e. ./mptcp_join.sh -i - Remove test numbers from commit messages - On endpoint delete, continue to provide $addr when id is 0. Andrea Claudi (2): selftests: mptcp: join: fix 'delete and re-add' test selftests: mptcp: join: fix 'implicit EP' test tools/testing/selftests/net/mptcp/mptcp_join.sh | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)