| Message ID | b8c9c1a8a05dbf0be8e8be98cfdeafa9cecd8cef.1690535002.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] drm/atomic-helper: Update reference to drm_crtc_force_disable_all() | expand |
Geert Uytterhoeven <geert+renesas@glider.be> writes: Hello Geert, > drm_crtc_force_disable_all() was renamed to > drm_helper_force_disable_all(), but one reference was not updated. > > Fixes: c2d88e06bcb98540 ("drm: Move the legacy kms disable_all helper to crtc helpers") The dim tool complains that: -:10: WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' So I've fixed it locally to only use the first 12 chars of the sha1. > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > Reviewed-by: Sui Jingfeng <suijingfeng@loongson.cn> > --- Pushed to drm-misc (drm-misc-next). Thanks!
Hi Javier, On Fri, Jul 28, 2023 at 11:53 AM Javier Martinez Canillas <javierm@redhat.com> wrote: > Geert Uytterhoeven <geert+renesas@glider.be> writes: > > drm_crtc_force_disable_all() was renamed to > > drm_helper_force_disable_all(), but one reference was not updated. > > > > Fixes: c2d88e06bcb98540 ("drm: Move the legacy kms disable_all helper to crtc helpers") > > The dim tool complains that: > > -:10: WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' > > So I've fixed it locally to only use the first 12 chars of the sha1. Good luck restoring them in the future (you do care about Y2038, do you? ;-) > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Reviewed-by: Sui Jingfeng <suijingfeng@loongson.cn> > > --- > > Pushed to drm-misc (drm-misc-next). Thanks! Thanks! Gr{oetje,eeting}s, Geert
Geert Uytterhoeven <geert@linux-m68k.org> writes: > Hi Javier, > > On Fri, Jul 28, 2023 at 11:53 AM Javier Martinez Canillas > <javierm@redhat.com> wrote: >> Geert Uytterhoeven <geert+renesas@glider.be> writes: >> > drm_crtc_force_disable_all() was renamed to >> > drm_helper_force_disable_all(), but one reference was not updated. >> > >> > Fixes: c2d88e06bcb98540 ("drm: Move the legacy kms disable_all helper to crtc helpers") >> >> The dim tool complains that: >> >> -:10: WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' >> >> So I've fixed it locally to only use the first 12 chars of the sha1. > > Good luck restoring them in the future (you do care about Y2038, > do you? ;-) > Fair. I fixed it not only because checkpatch complained but also to make it consistent with the rest of the Fixes: tag in the tree, in case that people have automation in place having the assumption of the 12 chars...
diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index 41b8066f61fff4be..292e38eb621806a0 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -3332,7 +3332,7 @@ EXPORT_SYMBOL(drm_atomic_helper_disable_all); * that also takes a snapshot of the modeset state to be restored on resume. * * This is just a convenience wrapper around drm_atomic_helper_disable_all(), - * and it is the atomic version of drm_crtc_force_disable_all(). + * and it is the atomic version of drm_helper_force_disable_all(). */ void drm_atomic_helper_shutdown(struct drm_device *dev) {
drm_crtc_force_disable_all() was renamed to drm_helper_force_disable_all(), but one reference was not updated. Fixes: c2d88e06bcb98540 ("drm: Move the legacy kms disable_all helper to crtc helpers") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Sui Jingfeng <suijingfeng@loongson.cn> --- v2: - Add Reviewed-by. --- drivers/gpu/drm/drm_atomic_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)