| Message ID | 20230719130940.659837-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/panel: r66451: select CONFIG_DRM_DISPLAY_DP_HELPER | expand |
On 7/19/2023 6:09 AM, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The newly added driver only builds when DRM_DISPLAY_DP_HELPER is enabled: > > x86_64-linux-ld: drivers/gpu/drm/panel/panel-visionox-r66451.o: in function `visionox_r66451_enable': > panel-visionox-r66451.c:(.text+0x105): undefined reference to `drm_dsc_pps_payload_pack' > > Select both CONFIG_DRM_DISPLAY_DP_HELPER and CONFIG_DRM_DISPLAY_HELPER to > ensure the helper function is always available. Hi Arnd, Thanks for catching this -- hadn't seen this issue due to DRM_MSM selecting both configs already. Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com> Thanks, Jessica Zhang > > Fixes: a6dfab2738fc2 ("drm/panel: Add driver for Visionox r66451 panel") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/gpu/drm/panel/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index 1a0fd0754692e..e8c9f4613a4b4 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -798,6 +798,8 @@ config DRM_PANEL_VISIONOX_R66451 > depends on OF > depends on DRM_MIPI_DSI > depends on BACKLIGHT_CLASS_DEVICE > + select DRM_DISPLAY_DP_HELPER > + select DRM_DISPLAY_HELPER > help > Say Y here if you want to enable support for Visionox > R66451 1080x2340 AMOLED DSI panel. > -- > 2.39.2 >
Hi, On Wed, 19 Jul 2023 15:09:21 +0200, Arnd Bergmann wrote: > The newly added driver only builds when DRM_DISPLAY_DP_HELPER is enabled: > > x86_64-linux-ld: drivers/gpu/drm/panel/panel-visionox-r66451.o: in function `visionox_r66451_enable': > panel-visionox-r66451.c:(.text+0x105): undefined reference to `drm_dsc_pps_payload_pack' > > Select both CONFIG_DRM_DISPLAY_DP_HELPER and CONFIG_DRM_DISPLAY_HELPER to > ensure the helper function is always available. > > [...] Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/1] drm/panel: r66451: select CONFIG_DRM_DISPLAY_DP_HELPER https://cgit.freedesktop.org/drm/drm-misc/commit/?id=a1865d3b98c97d25cbfbba4318180f5cfe8ec22d
Hi, On Wed, 19 Jul 2023 15:09:21 +0200, Arnd Bergmann wrote: > The newly added driver only builds when DRM_DISPLAY_DP_HELPER is enabled: > > x86_64-linux-ld: drivers/gpu/drm/panel/panel-visionox-r66451.o: in function `visionox_r66451_enable': > panel-visionox-r66451.c:(.text+0x105): undefined reference to `drm_dsc_pps_payload_pack' > > Select both CONFIG_DRM_DISPLAY_DP_HELPER and CONFIG_DRM_DISPLAY_HELPER to > ensure the helper function is always available. > > [...] Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/1] drm/panel: r66451: select CONFIG_DRM_DISPLAY_DP_HELPER https://cgit.freedesktop.org/drm/drm-misc/commit/?id=a1865d3b98c97d25cbfbba4318180f5cfe8ec22d
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index 1a0fd0754692e..e8c9f4613a4b4 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -798,6 +798,8 @@ config DRM_PANEL_VISIONOX_R66451 depends on OF depends on DRM_MIPI_DSI depends on BACKLIGHT_CLASS_DEVICE + select DRM_DISPLAY_DP_HELPER + select DRM_DISPLAY_HELPER help Say Y here if you want to enable support for Visionox R66451 1080x2340 AMOLED DSI panel.