| Message ID | 38b71b347f9c75e926dec55d7ecfa078aedd70c6.1690804520.git.marcelo.schmitt1@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | iio: dac: ad3552r: Correct device IDs | expand |
On Mon, 31 Jul 2023 08:59:35 -0300 Marcelo Schmitt <marcelo.schmitt1@gmail.com> wrote: > Device IDs for AD3542R and AD3552R were swapped. > Change device ID values so they are correct for each DAC chip. > Hi Marcelo, Agreed with the patch and that it matches the datasheets.. However needs more info in the description so that people know how urgent the fix is. Missing. - Fixes tag so we know what trees need the fix (as they include the ID in the fixes tag. - Description of the user visible effects of this bug. With those added I'll be happy to queue this up. Note I've just sent a pull request for fixes, so not in a hurry for this - otherwise I 'might' have figured out the details and added them whilst applying. Thanks Jonathan > Signed-off-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com> > --- > drivers/iio/dac/ad3552r.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/dac/ad3552r.c b/drivers/iio/dac/ad3552r.c > index d5ea1a1be122..a492e8f2fc0f 100644 > --- a/drivers/iio/dac/ad3552r.c > +++ b/drivers/iio/dac/ad3552r.c > @@ -140,8 +140,8 @@ enum ad3552r_ch_vref_select { > }; > > enum ad3542r_id { > - AD3542R_ID = 0x4008, > - AD3552R_ID = 0x4009, > + AD3542R_ID = 0x4009, > + AD3552R_ID = 0x4008, > }; > > enum ad3552r_ch_output_range {
diff --git a/drivers/iio/dac/ad3552r.c b/drivers/iio/dac/ad3552r.c index d5ea1a1be122..a492e8f2fc0f 100644 --- a/drivers/iio/dac/ad3552r.c +++ b/drivers/iio/dac/ad3552r.c @@ -140,8 +140,8 @@ enum ad3552r_ch_vref_select { }; enum ad3542r_id { - AD3542R_ID = 0x4008, - AD3552R_ID = 0x4009, + AD3542R_ID = 0x4009, + AD3552R_ID = 0x4008, }; enum ad3552r_ch_output_range {
Device IDs for AD3542R and AD3552R were swapped. Change device ID values so they are correct for each DAC chip. Signed-off-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com> --- drivers/iio/dac/ad3552r.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)