diff mbox series

key: Make key_sysctls static

Message ID 20230802021542.13473-1-guozihua@huawei.com (mailing list archive)
State New
Headers show
Series key: Make key_sysctls static | expand

Commit Message

Guozihua (Scott) Aug. 2, 2023, 2:15 a.m. UTC
key_sysctls is not used outside the file. Make it static

Signed-off-by: GUO Zihua <guozihua@huawei.com>
---
 security/keys/sysctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ben Boeckel Aug. 2, 2023, 2:35 a.m. UTC | #1
On Wed, Aug 02, 2023 at 10:15:42 +0800, GUO Zihua wrote:
> key_sysctls is not used outside the file. Make it static
> 
> Signed-off-by: GUO Zihua <guozihua@huawei.com>

Previously submitted:

    https://lore.kernel.org/keyrings/20230611113210.182652-1-trix@redhat.com/T/#u

--Ben
Guozihua (Scott) Aug. 2, 2023, 3:14 a.m. UTC | #2
Hi Ben,

On 2023/8/2 10:35, Ben Boeckel wrote:
> On Wed, Aug 02, 2023 at 10:15:42 +0800, GUO Zihua wrote:
>> key_sysctls is not used outside the file. Make it static
>>
>> Signed-off-by: GUO Zihua <guozihua@huawei.com>
> 
> Previously submitted:
> 
>     https://lore.kernel.org/keyrings/20230611113210.182652-1-trix@redhat.com/T/#u
> 
> --Ben
Thanks for the info!
Jarkko Sakkinen Aug. 2, 2023, 4:19 a.m. UTC | #3
On Wed Aug 2, 2023 at 5:35 AM EEST, Ben Boeckel wrote:
> On Wed, Aug 02, 2023 at 10:15:42 +0800, GUO Zihua wrote:
> > key_sysctls is not used outside the file. Make it static
> > 
> > Signed-off-by: GUO Zihua <guozihua@huawei.com>
>
> Previously submitted:
>
>     https://lore.kernel.org/keyrings/20230611113210.182652-1-trix@redhat.com/T/#u
>
> --Ben

Oops, sorry, applied:

https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/log/?h=next

BR, Jarkko
diff mbox series

Patch

diff --git a/security/keys/sysctl.c b/security/keys/sysctl.c
index b72b82bb20c6..b348e1679d5d 100644
--- a/security/keys/sysctl.c
+++ b/security/keys/sysctl.c
@@ -9,7 +9,7 @@ 
 #include <linux/sysctl.h>
 #include "internal.h"
 
-struct ctl_table key_sysctls[] = {
+static struct ctl_table key_sysctls[] = {
 	{
 		.procname = "maxkeys",
 		.data = &key_quota_maxkeys,