[v6,0/2] ARM: imx25: print silicon revision at startup

Message

Martin Kaiser July 30, 2023, 4:39 p.m. UTC

Resurrect the unused function to print the imx25 silicon revision at
startup.

This patch set is blocking Arnd's work on enabling -Werror=missing-prototypes.

I'd really appreciate a response from the clk maintainers if these (trivial)
patches are ok.

Thanks,
Martin

changes in v6:
- rebase against today's linux-next
- add Acked-by from Arnd

changes in v5:
- rebase against today's linux-next

changes in v4:
- rebase against today's linux-next
- add Fabio's Reviewed-by tags

changes in v3:
- rebase against today's linux-next

changes in v2:
- drop the patch about silicon revision 1.2. It has already been merged
  by Shawn Guo.
- send the changeset to the clk maintainers



Martin Kaiser (2):
  clk: imx25: print silicon revision during init
  clk: imx25: make __mx25_clocks_init return void

 drivers/clk/imx/clk-imx25.c | 5 +++--
 include/soc/imx/revision.h  | 1 +
 2 files changed, 4 insertions(+), 2 deletions(-)

Comments

Stephen Boyd Aug. 1, 2023, 7:13 p.m. UTC | #1

Quoting Martin Kaiser (2023-07-30 09:39:26)
> Resurrect the unused function to print the imx25 silicon revision at
> startup.
> 
> This patch set is blocking Arnd's work on enabling -Werror=missing-prototypes.
> 
> I'd really appreciate a response from the clk maintainers if these (trivial)
> patches are ok.

You need to Cc [e-mail] on imx clk patches. I think Abel has
some filter that looks for linux-clk@vger and linux-imx.

Also, please don't send series replies to previous rounds. It buries the
patches deep in my MUA and my scripts don't work well to apply patches
when they're sent like that.

I presume that Abel will pick the patches up? Or do you want to land
them through Arnd's tree? Either way feel free to add my acked-by

Acked-by: Stephen Boyd <[e-mail]>

Martin Kaiser Aug. 2, 2023, 6:38 p.m. UTC | #2

Stephen Boyd ([e-mail]) wrote:

> You need to Cc [e-mail] on imx clk patches. I think Abel has
> some filter that looks for linux-clk@vger and linux-imx.

> Also, please don't send series replies to previous rounds. It buries the
> patches deep in my MUA and my scripts don't work well to apply patches
> when they're sent like that.

> I presume that Abel will pick the patches up? Or do you want to land
> them through Arnd's tree? Either way feel free to add my acked-by

> Acked-by: Stephen Boyd <[e-mail]>

Thanks for responding, Stephen.

Ok, understood. I'll resend with Cc [e-mail] and without the
reply to previous versions.

Arnd, are you ok with taking these patches through your tree as
suggested by Stephen?

Thanks,
Martin

Shawn Guo Aug. 6, 2023, 3:23 a.m. UTC | #3

On Wed, Aug 02, 2023 at 08:38:49PM +0200, Martin Kaiser wrote:
> Stephen Boyd ([e-mail]) wrote:
> 
> > You need to Cc [e-mail] on imx clk patches. I think Abel has
> > some filter that looks for linux-clk@vger and linux-imx.
> 
> > Also, please don't send series replies to previous rounds. It buries the
> > patches deep in my MUA and my scripts don't work well to apply patches
> > when they're sent like that.
> 
> > I presume that Abel will pick the patches up? Or do you want to land
> > them through Arnd's tree? Either way feel free to add my acked-by
> 
> > Acked-by: Stephen Boyd <[e-mail]>
> 
> Thanks for responding, Stephen.
> 
> Ok, understood. I'll resend with Cc [e-mail] and without the
> reply to previous versions.
> 
> Arnd, are you ok with taking these patches through your tree as
> suggested by Stephen?

I prefer to have Abel apply the patches through clk tree rather than
arm-soc tree, unless there is a good reason for them to go via the
latter.

Shawn

Martin Kaiser Aug. 7, 2023, 2:38 p.m. UTC | #4

Shawn Guo ([e-mail]) wrote:

> I prefer to have Abel apply the patches through clk tree rather than
> arm-soc tree, unless there is a good reason for them to go via the
> latter.

ok with me. I'd be happy to get this sorted (one way or another) so that
Arnd can enable -Werror=missing-prototypes for 6.6.

Abel, could you pick up these patches?

Thanks,
Martin