diff mbox series

[v5,17/32] media: ov2680: Add support for ACPI enumeration

Message ID 20230803093348.15679-18-hdegoede@redhat.com (mailing list archive)
State New, archived
Headers show
Series media: ov2680: Bugfixes + ACPI + selection(crop-tgt) API support | expand

Commit Message

Hans de Goede Aug. 3, 2023, 9:33 a.m. UTC 
Add an acpi_match_table now that all the other bits necessary for
ACPI support are in place.

The OVTI prefix used for the ACPI-HID is used for various OmniVision
sensors on many generations x86 tablets and laptops.

The OVTI2680 HID specifically is used on multiple models spanning at
least 4 different Intel CPU models (2 ISP2, 2 IPU3).

Acked-by: Rui Miguel Silva <rmfrfs@gmail.com>
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
Changes in v5:
- Add some notes to the commit message about the OVTI2680 HID
---
 drivers/media/i2c/ov2680.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Andy Shevchenko Aug. 3, 2023, 1:15 p.m. UTC | #1 
On Thu, Aug 03, 2023 at 11:33:32AM +0200, Hans de Goede wrote:
> Add an acpi_match_table now that all the other bits necessary for
> ACPI support are in place.

> The OVTI prefix used for the ACPI-HID is used for various OmniVision
> sensors on many generations x86 tablets and laptops.

"OVTI is the official ACPI vendor ID for OmniVision Technologies, Inc."

> The OVTI2680 HID specifically is used on multiple models spanning at
> least 4 different Intel CPU models (2 ISP2, 2 IPU3).

With or without above (as it's still the official vendor ID :-)
Reviewed-by: Andy Shevchenko <andy@kernel.org>
from ACPI ID rules perspective.

But add that in case you need to send a new version.
Sakari Ailus Aug. 3, 2023, 2:45 p.m. UTC | #2 
Hi Andy,

On Thu, Aug 03, 2023 at 04:15:01PM +0300, Andy Shevchenko wrote:
> On Thu, Aug 03, 2023 at 11:33:32AM +0200, Hans de Goede wrote:
> > Add an acpi_match_table now that all the other bits necessary for
> > ACPI support are in place.
> 
> > The OVTI prefix used for the ACPI-HID is used for various OmniVision
> > sensors on many generations x86 tablets and laptops.
> 
> "OVTI is the official ACPI vendor ID for OmniVision Technologies, Inc."
> 
> > The OVTI2680 HID specifically is used on multiple models spanning at
> > least 4 different Intel CPU models (2 ISP2, 2 IPU3).
> 
> With or without above (as it's still the official vendor ID :-)
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
> from ACPI ID rules perspective.
> 
> But add that in case you need to send a new version.

Thanks, Andy!

I'll take this version then, it's "just" a sensor driver patch.
Hans de Goede Aug. 3, 2023, 2:57 p.m. UTC | #3 
Hi andy,

On 8/3/23 15:15, Andy Shevchenko wrote:
> On Thu, Aug 03, 2023 at 11:33:32AM +0200, Hans de Goede wrote:
>> Add an acpi_match_table now that all the other bits necessary for
>> ACPI support are in place.
> 
>> The OVTI prefix used for the ACPI-HID is used for various OmniVision
>> sensors on many generations x86 tablets and laptops.
> 
> "OVTI is the official ACPI vendor ID for OmniVision Technologies, Inc."

Is it though? Is there a list of official ACPI vendor IDs
published somewhere were we can check this ?

I think the Intel MIPI camera driver team may have come up with
the OVTI prefix independently ?

Just because it is used quite a lot does not mean that it is
official ...

Regards,

Hans
Sakari Ailus Aug. 3, 2023, 3:07 p.m. UTC | #4 
Hi Hans,

On Thu, Aug 03, 2023 at 04:57:24PM +0200, Hans de Goede wrote:
> Hi andy,
> 
> On 8/3/23 15:15, Andy Shevchenko wrote:
> > On Thu, Aug 03, 2023 at 11:33:32AM +0200, Hans de Goede wrote:
> >> Add an acpi_match_table now that all the other bits necessary for
> >> ACPI support are in place.
> > 
> >> The OVTI prefix used for the ACPI-HID is used for various OmniVision
> >> sensors on many generations x86 tablets and laptops.
> > 
> > "OVTI is the official ACPI vendor ID for OmniVision Technologies, Inc."
> 
> Is it though? Is there a list of official ACPI vendor IDs
> published somewhere were we can check this ?
> 
> I think the Intel MIPI camera driver team may have come up with
> the OVTI prefix independently ?
> 
> Just because it is used quite a lot does not mean that it is
> official ...

It is. Only ACPI and PNP vendor IDs allocated to vendors should be used
(and HIDs allocated by that vendor only).

<URL:https://uefi.org/acpi_id_list>
<URL:https://uefi.org/pnp_id_list>
diff mbox series

Patch

diff --git a/drivers/media/i2c/ov2680.c b/drivers/media/i2c/ov2680.c
index d4664581b49b..0adfacc70735 100644
--- a/drivers/media/i2c/ov2680.c
+++ b/drivers/media/i2c/ov2680.c
@@ -932,11 +932,18 @@  static const struct of_device_id ov2680_dt_ids[] = {
 };
 MODULE_DEVICE_TABLE(of, ov2680_dt_ids);
 
+static const struct acpi_device_id ov2680_acpi_ids[] = {
+	{ "OVTI2680" },
+	{ /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(acpi, ov2680_acpi_ids);
+
 static struct i2c_driver ov2680_i2c_driver = {
 	.driver = {
 		.name  = "ov2680",
 		.pm = pm_sleep_ptr(&ov2680_pm_ops),
 		.of_match_table	= ov2680_dt_ids,
+		.acpi_match_table = ov2680_acpi_ids,
 	},
 	.probe		= ov2680_probe,
 	.remove		= ov2680_remove,