diff mbox series

rcu: include torture_sched_setaffinity() declaration

Message ID 20230803144025.14023-1-arnd@kernel.org (mailing list archive)
State Accepted
Commit 778df208f00107d5f1d10da8355fbf64b73b0bfe
Headers show
Series rcu: include torture_sched_setaffinity() declaration | expand

Commit Message

Arnd Bergmann Aug. 3, 2023, 2:40 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

The prototype for torture_sched_setaffinity() moved to a
different header, which needs to be included from update.c
to avoid this W=1 warning:

kernel/rcu/update.c:529:6: error: no previous prototype for 'torture_sched_setaffinity' [-Werror=missing-prototypes]
  529 | long torture_sched_setaffinity(pid_t pid, const struct cpumask *in_mask)

Fixes: 521ec59e5453e ("torture: Move rcutorture_sched_setaffinity() out of rcutorture")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 kernel/rcu/update.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Joel Fernandes Aug. 3, 2023, 4:02 p.m. UTC | #1 
On Thu, Aug 3, 2023 at 10:40 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The prototype for torture_sched_setaffinity() moved to a
> different header, which needs to be included from update.c
> to avoid this W=1 warning:
>
> kernel/rcu/update.c:529:6: error: no previous prototype for 'torture_sched_setaffinity' [-Werror=missing-prototypes]
>   529 | long torture_sched_setaffinity(pid_t pid, const struct cpumask *in_mask)
>
> Fixes: 521ec59e5453e ("torture: Move rcutorture_sched_setaffinity() out of rcutorture")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>

thanks,

- Joel


> ---
>  kernel/rcu/update.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/kernel/rcu/update.c b/kernel/rcu/update.c
> index 0533b510f0a8..c534d6806d3d 100644
> --- a/kernel/rcu/update.c
> +++ b/kernel/rcu/update.c
> @@ -25,6 +25,7 @@
>  #include <linux/interrupt.h>
>  #include <linux/sched/signal.h>
>  #include <linux/sched/debug.h>
> +#include <linux/torture.h>
>  #include <linux/atomic.h>
>  #include <linux/bitops.h>
>  #include <linux/percpu.h>
> --
> 2.39.2
>
Paul E. McKenney Aug. 3, 2023, 4:32 p.m. UTC | #2 
On Thu, Aug 03, 2023 at 12:02:52PM -0400, Joel Fernandes wrote:
> On Thu, Aug 3, 2023 at 10:40 AM Arnd Bergmann <arnd@kernel.org> wrote:
> >
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > The prototype for torture_sched_setaffinity() moved to a
> > different header, which needs to be included from update.c
> > to avoid this W=1 warning:
> >
> > kernel/rcu/update.c:529:6: error: no previous prototype for 'torture_sched_setaffinity' [-Werror=missing-prototypes]
> >   529 | long torture_sched_setaffinity(pid_t pid, const struct cpumask *in_mask)
> >
> > Fixes: 521ec59e5453e ("torture: Move rcutorture_sched_setaffinity() out of rcutorture")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>

Queued (likely for the v6.7 merge window), thank you both!

							Thanx, Paul

> thanks,
> 
> - Joel
> 
> 
> > ---
> >  kernel/rcu/update.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/kernel/rcu/update.c b/kernel/rcu/update.c
> > index 0533b510f0a8..c534d6806d3d 100644
> > --- a/kernel/rcu/update.c
> > +++ b/kernel/rcu/update.c
> > @@ -25,6 +25,7 @@
> >  #include <linux/interrupt.h>
> >  #include <linux/sched/signal.h>
> >  #include <linux/sched/debug.h>
> > +#include <linux/torture.h>
> >  #include <linux/atomic.h>
> >  #include <linux/bitops.h>
> >  #include <linux/percpu.h>
> > --
> > 2.39.2
> >
diff mbox series

Patch

diff --git a/kernel/rcu/update.c b/kernel/rcu/update.c
index 0533b510f0a8..c534d6806d3d 100644
--- a/kernel/rcu/update.c
+++ b/kernel/rcu/update.c
@@ -25,6 +25,7 @@ 
 #include <linux/interrupt.h>
 #include <linux/sched/signal.h>
 #include <linux/sched/debug.h>
+#include <linux/torture.h>
 #include <linux/atomic.h>
 #include <linux/bitops.h>
 #include <linux/percpu.h>