| Message ID | 20230804113035.1698118-1-shaozhengchao@huawei.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] team: remove unreferenced header in activebackup/broadcast/roundrobin files | expand |
On Fri, Aug 04, 2023 at 07:30:35PM +0800, Zhengchao Shao wrote: > Because linux/errno.h is unreferenced in activebackup/broadcast/roundrobin > files, so remove it. > > Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> > --- > drivers/net/team/team_mode_activebackup.c | 1 - > drivers/net/team/team_mode_broadcast.c | 1 - > drivers/net/team/team_mode_roundrobin.c | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/drivers/net/team/team_mode_activebackup.c b/drivers/net/team/team_mode_activebackup.c > index e0f599e2a51d..419b9083515e 100644 > --- a/drivers/net/team/team_mode_activebackup.c > +++ b/drivers/net/team/team_mode_activebackup.c > @@ -8,7 +8,6 @@ > #include <linux/types.h> > #include <linux/module.h> > #include <linux/init.h> > -#include <linux/errno.h> > #include <linux/netdevice.h> > #include <net/rtnetlink.h> > #include <linux/if_team.h> Hi Zhengchao Shao, Removing the inclusion of errno.h from team_mode_activebackup.c doesn't seem right to me, ENOENT is used in that file. The other two below seem fine to me. > diff --git a/drivers/net/team/team_mode_broadcast.c b/drivers/net/team/team_mode_broadcast.c > index 313a3e2d68bf..61d7d79f0c36 100644 > --- a/drivers/net/team/team_mode_broadcast.c > +++ b/drivers/net/team/team_mode_broadcast.c > @@ -8,7 +8,6 @@ > #include <linux/types.h> > #include <linux/module.h> > #include <linux/init.h> > -#include <linux/errno.h> > #include <linux/netdevice.h> > #include <linux/if_team.h> > > diff --git a/drivers/net/team/team_mode_roundrobin.c b/drivers/net/team/team_mode_roundrobin.c > index 3ec63de97ae3..dd405d82c6ac 100644 > --- a/drivers/net/team/team_mode_roundrobin.c > +++ b/drivers/net/team/team_mode_roundrobin.c > @@ -8,7 +8,6 @@ > #include <linux/types.h> > #include <linux/module.h> > #include <linux/init.h> > -#include <linux/errno.h> > #include <linux/netdevice.h> > #include <linux/if_team.h>
On 2023/8/5 19:48, Simon Horman wrote: > On Fri, Aug 04, 2023 at 07:30:35PM +0800, Zhengchao Shao wrote: >> Because linux/errno.h is unreferenced in activebackup/broadcast/roundrobin >> files, so remove it. >> >> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> >> --- >> drivers/net/team/team_mode_activebackup.c | 1 - >> drivers/net/team/team_mode_broadcast.c | 1 - >> drivers/net/team/team_mode_roundrobin.c | 1 - >> 3 files changed, 3 deletions(-) >> >> diff --git a/drivers/net/team/team_mode_activebackup.c b/drivers/net/team/team_mode_activebackup.c >> index e0f599e2a51d..419b9083515e 100644 >> --- a/drivers/net/team/team_mode_activebackup.c >> +++ b/drivers/net/team/team_mode_activebackup.c >> @@ -8,7 +8,6 @@ >> #include <linux/types.h> >> #include <linux/module.h> >> #include <linux/init.h> >> -#include <linux/errno.h> >> #include <linux/netdevice.h> >> #include <net/rtnetlink.h> >> #include <linux/if_team.h> > > Hi Zhengchao Shao, > > Removing the inclusion of errno.h from team_mode_activebackup.c doesn't > seem right to me, ENOENT is used in that file. > > The other two below seem fine to me. > Hi Simon: Thank you for your review. You are right here and I will send V2. Zhengchao Shao >> diff --git a/drivers/net/team/team_mode_broadcast.c b/drivers/net/team/team_mode_broadcast.c >> index 313a3e2d68bf..61d7d79f0c36 100644 >> --- a/drivers/net/team/team_mode_broadcast.c >> +++ b/drivers/net/team/team_mode_broadcast.c >> @@ -8,7 +8,6 @@ >> #include <linux/types.h> >> #include <linux/module.h> >> #include <linux/init.h> >> -#include <linux/errno.h> >> #include <linux/netdevice.h> >> #include <linux/if_team.h> >> >> diff --git a/drivers/net/team/team_mode_roundrobin.c b/drivers/net/team/team_mode_roundrobin.c >> index 3ec63de97ae3..dd405d82c6ac 100644 >> --- a/drivers/net/team/team_mode_roundrobin.c >> +++ b/drivers/net/team/team_mode_roundrobin.c >> @@ -8,7 +8,6 @@ >> #include <linux/types.h> >> #include <linux/module.h> >> #include <linux/init.h> >> -#include <linux/errno.h> >> #include <linux/netdevice.h> >> #include <linux/if_team.h> >
diff --git a/drivers/net/team/team_mode_activebackup.c b/drivers/net/team/team_mode_activebackup.c index e0f599e2a51d..419b9083515e 100644 --- a/drivers/net/team/team_mode_activebackup.c +++ b/drivers/net/team/team_mode_activebackup.c @@ -8,7 +8,6 @@ #include <linux/types.h> #include <linux/module.h> #include <linux/init.h> -#include <linux/errno.h> #include <linux/netdevice.h> #include <net/rtnetlink.h> #include <linux/if_team.h> diff --git a/drivers/net/team/team_mode_broadcast.c b/drivers/net/team/team_mode_broadcast.c index 313a3e2d68bf..61d7d79f0c36 100644 --- a/drivers/net/team/team_mode_broadcast.c +++ b/drivers/net/team/team_mode_broadcast.c @@ -8,7 +8,6 @@ #include <linux/types.h> #include <linux/module.h> #include <linux/init.h> -#include <linux/errno.h> #include <linux/netdevice.h> #include <linux/if_team.h> diff --git a/drivers/net/team/team_mode_roundrobin.c b/drivers/net/team/team_mode_roundrobin.c index 3ec63de97ae3..dd405d82c6ac 100644 --- a/drivers/net/team/team_mode_roundrobin.c +++ b/drivers/net/team/team_mode_roundrobin.c @@ -8,7 +8,6 @@ #include <linux/types.h> #include <linux/module.h> #include <linux/init.h> -#include <linux/errno.h> #include <linux/netdevice.h> #include <linux/if_team.h>
Because linux/errno.h is unreferenced in activebackup/broadcast/roundrobin files, so remove it. Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> --- drivers/net/team/team_mode_activebackup.c | 1 - drivers/net/team/team_mode_broadcast.c | 1 - drivers/net/team/team_mode_roundrobin.c | 1 - 3 files changed, 3 deletions(-)