[00/10] mtd: rawnand: qcom: Bunch of fixes and cleanups

Message

Manivannan Sadhasivam Aug. 5, 2023, 5:41 p.m. UTC

Hi Miquel,

This series has fixes for the smatch warnings reported by Kbuild bot [1]
and also several cleanup patches based on my code observation.

I've only compile tested this series. So let's wait for Sadre/Sricharan to
give a tested-by tag to make sure I didn't mess up anything.

- Mani

[1] https://lore.kernel.org/all/[e-mail]/

Manivannan Sadhasivam (10):
  mtd: rawnand: qcom: Remove superfluous initialization of "ret"
  mtd: rawnand: qcom: Rename variables in qcom_op_cmd_mapping()
  mtd: rawnand: qcom: Handle unsupported opcode in qcom_op_cmd_mapping()
  mtd: rawnand: qcom: Fix the opcode check in qcom_check_op()
  mtd: rawnand: qcom: Use EOPNOTSUPP instead of ENOTSUPP
  mtd: rawnand: qcom: Wrap qcom_nand_exec_op() to 80 columns
  mtd: rawnand: qcom: Unmap sg_list and free desc within submic_descs()
  mtd: rawnand: qcom: Simplify the call to nand_prog_page_end_op()
  mtd: rawnand: qcom: Do not override the error no of submit_descs()
  mtd: rawnand: qcom: Sort includes alphabetically

 drivers/mtd/nand/raw/qcom_nandc.c | 192 ++++++++++++++----------------
 1 file changed, 91 insertions(+), 101 deletions(-)

Comments

Miquel Raynal Aug. 6, 2023, 1:53 p.m. UTC | #1

Hi Manivannan,

[e-mail] wrote on Sat,  5 Aug 2023 23:11:36
+0530:

> Hi Miquel,
> 
> This series has fixes for the smatch warnings reported by Kbuild bot [1]
> and also several cleanup patches based on my code observation.
> 
> I've only compile tested this series. So let's wait for Sadre/Sricharan to
> give a tested-by tag to make sure I didn't mess up anything.

I reviewed all the patches, they look good to me. I'm waiting for the
tests. Please provide the output of nandbiterrs -i.

Thanks,
Miquèl

Manivannan Sadhasivam Aug. 7, 2023, 11:50 a.m. UTC | #2

On Sun, Aug 06, 2023 at 03:53:09PM +0200, Miquel Raynal wrote:
> Hi Manivannan,
> 
> [e-mail] wrote on Sat,  5 Aug 2023 23:11:36
> +0530:
> 
> > Hi Miquel,
> > 
> > This series has fixes for the smatch warnings reported by Kbuild bot [1]
> > and also several cleanup patches based on my code observation.
> > 
> > I've only compile tested this series. So let's wait for Sadre/Sricharan to
> > give a tested-by tag to make sure I didn't mess up anything.
> 
> I reviewed all the patches, they look good to me. I'm waiting for the
> tests. Please provide the output of nandbiterrs -i.
> 

I tested the series on Qcom SDX55 based dev board, but it was broken already due
to commit <3fc92384b654> ("mtd: rawnand: qcom: Implement exec_op()").

I'm seeing a string of this error while the partitions were being enumerated:
qcom-nandc 1b30000.nand-controller: failed to copy last codeword

It just goes on...

Sadre, on what platform did you test 3fc92384b654? From a quick look, the BAM
DMA transactions are timing out.

- Mani

> Thanks,
> Miquèl