| Message ID | 20230804123116.2495908-1-shaozhengchao@huawei.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | team: do some cleanups in team driver | expand |
On Fri, Aug 04, 2023 at 08:31:10PM +0800, Zhengchao Shao wrote: > Do some cleanups in team driver. > > Zhengchao Shao (6): > team: add __exit modifier to team_nl_fini() > team: remove unreferenced header in activebackup/broadcast/roundrobin > files > team: change the init function in the team_option structure to void > team: change the getter function in the team_option structure to void > team: get lb_priv from team directly in lb_htpm_select_tx_port > team: remove unused input parameters in lb_htpm_select_tx_port and > lb_hash_select_tx_port Hi Zhengchao Shao, Some of these patches appear to have been posted several times within a few hours. Please follow the guidance that at least 24h must elapse between posting the same patch. This is to allow time for review, else things can get really confusing for the reviewers. Link: https://docs.kernel.org/process/maintainer-netdev.html
On 2023/8/5 19:55, Simon Horman wrote: > On Fri, Aug 04, 2023 at 08:31:10PM +0800, Zhengchao Shao wrote: >> Do some cleanups in team driver. >> >> Zhengchao Shao (6): >> team: add __exit modifier to team_nl_fini() >> team: remove unreferenced header in activebackup/broadcast/roundrobin >> files >> team: change the init function in the team_option structure to void >> team: change the getter function in the team_option structure to void >> team: get lb_priv from team directly in lb_htpm_select_tx_port >> team: remove unused input parameters in lb_htpm_select_tx_port and >> lb_hash_select_tx_port > > Hi Zhengchao Shao, > > Some of these patches appear to have been posted several times within > a few hours. Please follow the guidance that at least 24h must elapse > between posting the same patch. This is to allow time for review, > else things can get really confusing for the reviewers. > > Link: https://docs.kernel.org/process/maintainer-netdev.html Hi Simon: I'll follow this rule. Thank you for reminding me. Zhengchao Shao
Do some cleanups in team driver. Zhengchao Shao (6): team: add __exit modifier to team_nl_fini() team: remove unreferenced header in activebackup/broadcast/roundrobin files team: change the init function in the team_option structure to void team: change the getter function in the team_option structure to void team: get lb_priv from team directly in lb_htpm_select_tx_port team: remove unused input parameters in lb_htpm_select_tx_port and lb_hash_select_tx_port drivers/net/team/team.c | 62 +++++++++-------------- drivers/net/team/team_mode_activebackup.c | 9 ++-- drivers/net/team/team_mode_broadcast.c | 1 - drivers/net/team/team_mode_loadbalance.c | 50 +++++++----------- drivers/net/team/team_mode_roundrobin.c | 1 - include/linux/if_team.h | 4 +- 6 files changed, 48 insertions(+), 79 deletions(-)