| Message ID | 20230804035346.2879318-7-ruanjinjie@huawei.com (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: Remove unnecessary ternary operators | expand |
> -----Original Message----- > From: Ruan Jinjie <ruanjinjie@huawei.com> > Sent: Friday, August 4, 2023 11:54 AM > To: sgoutham@marvell.com; davem@davemloft.net; edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; > jesse.brandeburg@intel.com; anthony.l.nguyen@intel.com; tariqt@nvidia.com; s.shtylyov@omp.ru; > aspriel@gmail.com; franky.lin@broadcom.com; hante.meuleman@broadcom.com; kvalo@kernel.org; > richardcochran@gmail.com; yoshihiro.shimoda.uh@renesas.com; ruanjinjie@huawei.com; > u.kleine-koenig@pengutronix.de; mkl@pengutronix.de; lee@kernel.org; set_pte_at@outlook.com; > linux-arm-kernel@lists.infradead.org; netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; > linux-rdma@vger.kernel.org; linux-renesas-soc@vger.kernel.org; linux-wireless@vger.kernel.org; > brcm80211-dev-list.pdl@broadcom.com; SHA-cyfmac-dev-list@infineon.com > Subject: [PATCH -next 6/6] brcm80211: Remove an unnecessary ternary operator > > There is a ternary operator, the true or false judgement of which > is unnecessary in C language semantics. > > Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> > --- > drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c > b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c > index 8580a2754789..8328b22829c5 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c > @@ -27351,8 +27351,7 @@ static int wlc_phy_cal_rxiq_nphy_rev3(struct brcms_phy *pi, > > for (rx_core = 0; rx_core < pi->pubpi.phy_corenum; rx_core++) { > > - skip_rxiqcal = > - ((rxcore_state & (1 << rx_core)) == 0) ? true : false; > + skip_rxiqcal = (rxcore_state & (1 << rx_core)) == 0; skip_rxiqcal = !(rxcore_state & (1 << rx_core)); > > wlc_phy_rxcal_physetup_nphy(pi, rx_core); > > -- > 2.34.1 > > > ------Please consider the environment before printing this e-mail.
On 2023/8/7 9:42, Ping-Ke Shih wrote: > > >> -----Original Message----- >> From: Ruan Jinjie <ruanjinjie@huawei.com> >> Sent: Friday, August 4, 2023 11:54 AM >> To: sgoutham@marvell.com; davem@davemloft.net; edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; >> jesse.brandeburg@intel.com; anthony.l.nguyen@intel.com; tariqt@nvidia.com; s.shtylyov@omp.ru; >> aspriel@gmail.com; franky.lin@broadcom.com; hante.meuleman@broadcom.com; kvalo@kernel.org; >> richardcochran@gmail.com; yoshihiro.shimoda.uh@renesas.com; ruanjinjie@huawei.com; >> u.kleine-koenig@pengutronix.de; mkl@pengutronix.de; lee@kernel.org; set_pte_at@outlook.com; >> linux-arm-kernel@lists.infradead.org; netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; >> linux-rdma@vger.kernel.org; linux-renesas-soc@vger.kernel.org; linux-wireless@vger.kernel.org; >> brcm80211-dev-list.pdl@broadcom.com; SHA-cyfmac-dev-list@infineon.com >> Subject: [PATCH -next 6/6] brcm80211: Remove an unnecessary ternary operator >> >> There is a ternary operator, the true or false judgement of which >> is unnecessary in C language semantics. >> >> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> >> --- >> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c >> b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c >> index 8580a2754789..8328b22829c5 100644 >> --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c >> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c >> @@ -27351,8 +27351,7 @@ static int wlc_phy_cal_rxiq_nphy_rev3(struct brcms_phy *pi, >> >> for (rx_core = 0; rx_core < pi->pubpi.phy_corenum; rx_core++) { >> >> - skip_rxiqcal = >> - ((rxcore_state & (1 << rx_core)) == 0) ? true : false; >> + skip_rxiqcal = (rxcore_state & (1 << rx_core)) == 0; > > skip_rxiqcal = !(rxcore_state & (1 << rx_core)); Thank you! I'll improve it sooner. > >> >> wlc_phy_rxcal_physetup_nphy(pi, rx_core); >> >> -- >> 2.34.1 >> >> >> ------Please consider the environment before printing this e-mail. >
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c index 8580a2754789..8328b22829c5 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c @@ -27351,8 +27351,7 @@ static int wlc_phy_cal_rxiq_nphy_rev3(struct brcms_phy *pi, for (rx_core = 0; rx_core < pi->pubpi.phy_corenum; rx_core++) { - skip_rxiqcal = - ((rxcore_state & (1 << rx_core)) == 0) ? true : false; + skip_rxiqcal = (rxcore_state & (1 << rx_core)) == 0; wlc_phy_rxcal_physetup_nphy(pi, rx_core);
There is a ternary operator, the true or false judgement of which is unnecessary in C language semantics. Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> --- drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)