| Message ID | 40823fbaa9e0a9b026e5ff3b01af9d83583889fd.1691162261.git.nicola.vetrini@bugseng.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | xen: address MISRA C:2012 Rule 5.3 | expand |
On Fri, 4 Aug 2023, Nicola Vetrini wrote: > s/mpc_default_type/mpc_default in 'xen/arch/x86/include/asm/mpspec.h' > to avoid clashing with function parameter names in 'mpparse.c'. > > No functional changes. > > Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> > --- > Even though the global variable does not seem to be used anywhere and is > perhaps better to remove it entirely. Please remove it > --- > xen/arch/x86/include/asm/mpspec.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/x86/include/asm/mpspec.h b/xen/arch/x86/include/asm/mpspec.h > index 1246eece0b..cc96ee63bd 100644 > --- a/xen/arch/x86/include/asm/mpspec.h > +++ b/xen/arch/x86/include/asm/mpspec.h > @@ -15,7 +15,7 @@ extern void get_smp_config (void); > extern unsigned char apic_version [MAX_APICS]; > extern int mp_irq_entries; > extern struct mpc_config_intsrc mp_irqs [MAX_IRQ_SOURCES]; > -extern int mpc_default_type; > +extern int mpc_default; > extern unsigned long mp_lapic_addr; > extern bool pic_mode; > > -- > 2.34.1 >
On 04/08/2023 23:24, Stefano Stabellini wrote: > On Fri, 4 Aug 2023, Nicola Vetrini wrote: >> s/mpc_default_type/mpc_default in 'xen/arch/x86/include/asm/mpspec.h' >> to avoid clashing with function parameter names in 'mpparse.c'. >> >> No functional changes. >> >> Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> >> --- >> Even though the global variable does not seem to be used anywhere and >> is >> perhaps better to remove it entirely. > > Please remove it > Noted.
diff --git a/xen/arch/x86/include/asm/mpspec.h b/xen/arch/x86/include/asm/mpspec.h index 1246eece0b..cc96ee63bd 100644 --- a/xen/arch/x86/include/asm/mpspec.h +++ b/xen/arch/x86/include/asm/mpspec.h @@ -15,7 +15,7 @@ extern void get_smp_config (void); extern unsigned char apic_version [MAX_APICS]; extern int mp_irq_entries; extern struct mpc_config_intsrc mp_irqs [MAX_IRQ_SOURCES]; -extern int mpc_default_type; +extern int mpc_default; extern unsigned long mp_lapic_addr; extern bool pic_mode;
s/mpc_default_type/mpc_default in 'xen/arch/x86/include/asm/mpspec.h' to avoid clashing with function parameter names in 'mpparse.c'. No functional changes. Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> --- Even though the global variable does not seem to be used anywhere and is perhaps better to remove it entirely. --- xen/arch/x86/include/asm/mpspec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)