| Message ID | dfb1c50881a7bb21a1b32083f447e31995004f35.1691063432.git.oleksii.kurochko@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | RISCV basic exception handling implementation | expand |
On Thu, Aug 3, 2023 at 8:05 AM Oleksii Kurochko <oleksii.kurochko@gmail.com> wrote: > > <xen/lib.h> will be used in the patch "xen/riscv: introduce > decode_cause() stuff" and requires <asm/bug.h> > > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com> Acked-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > Changes in V7: > - Nothing changed. Only rebase. > --- > Changes in V6: > - Nothing changed. Only rebase. > --- > Changes in V5: > * the patch was introduced in the current patch series (V5) > --- > xen/arch/riscv/include/asm/bug.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > create mode 100644 xen/arch/riscv/include/asm/bug.h > > diff --git a/xen/arch/riscv/include/asm/bug.h b/xen/arch/riscv/include/asm/bug.h > new file mode 100644 > index 0000000000..e8b1e40823 > --- /dev/null > +++ b/xen/arch/riscv/include/asm/bug.h > @@ -0,0 +1,10 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (C) 2012 Regents of the University of California > + * Copyright (C) 2021-2023 Vates > + * > + */ > +#ifndef _ASM_RISCV_BUG_H > +#define _ASM_RISCV_BUG_H > + > +#endif /* _ASM_RISCV_BUG_H */ > -- > 2.41.0 > >
On 03.08.2023 14:05, Oleksii Kurochko wrote: > <xen/lib.h> will be used in the patch "xen/riscv: introduce > decode_cause() stuff" and requires <asm/bug.h> While as it stands the description is accurate, I don't think that later patch has a need to include xen/lib.h anymore. xen/macros.h will do, I think. Also please don't write descriptions in terms of "patches" or more generally future "commits". Their titles may change, they may disappear altogether, etc. Finding such a description later will end up confusing. Jan
On Mon, 2023-08-07 at 11:01 +0200, Jan Beulich wrote: > On 03.08.2023 14:05, Oleksii Kurochko wrote: > > <xen/lib.h> will be used in the patch "xen/riscv: introduce > > decode_cause() stuff" and requires <asm/bug.h> > > While as it stands the description is accurate, I don't think that > later > patch has a need to include xen/lib.h anymore. xen/macros.h will do, > I > think. > > Also please don't write descriptions in terms of "patches" or more > generally future "commits". Their titles may change, they may > disappear > altogether, etc. Finding such a description later will end up > confusing. Thanks for recommendations. I'll take them into account. ~ Oleksii
On Mon, 2023-08-07 at 11:01 +0200, Jan Beulich wrote: > On 03.08.2023 14:05, Oleksii Kurochko wrote: > > <xen/lib.h> will be used in the patch "xen/riscv: introduce > > decode_cause() stuff" and requires <asm/bug.h> > > While as it stands the description is accurate, I don't think that > later > patch has a need to include xen/lib.h anymore. xen/macros.h will do, > I > think. It looks like xen/lib.h should be still included as the code in traps.c uses printk(). > > Also please don't write descriptions in terms of "patches" or more > generally future "commits". Their titles may change, they may > disappear > altogether, etc. Finding such a description later will end up > confusing. > ~ Oleksii
diff --git a/xen/arch/riscv/include/asm/bug.h b/xen/arch/riscv/include/asm/bug.h new file mode 100644 index 0000000000..e8b1e40823 --- /dev/null +++ b/xen/arch/riscv/include/asm/bug.h @@ -0,0 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright (C) 2012 Regents of the University of California + * Copyright (C) 2021-2023 Vates + * + */ +#ifndef _ASM_RISCV_BUG_H +#define _ASM_RISCV_BUG_H + +#endif /* _ASM_RISCV_BUG_H */
<xen/lib.h> will be used in the patch "xen/riscv: introduce decode_cause() stuff" and requires <asm/bug.h> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com> --- Changes in V7: - Nothing changed. Only rebase. --- Changes in V6: - Nothing changed. Only rebase. --- Changes in V5: * the patch was introduced in the current patch series (V5) --- xen/arch/riscv/include/asm/bug.h | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 xen/arch/riscv/include/asm/bug.h