| Message ID | 20230724224903.146092-1-hphyperxdev@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [V2] Input: xpad - Add HyperX Clutch Gladiate Support | expand |
On Mon, 24 Jul, 2023 15:49:05 -0700 HP Dev <hphyperxdev@gmail.com> wrote: > Add HyperX controller support to xpad_device and xpad_table. > > Suggested-by: Chris Toledanes <chris.toledanes@hp.com> > Reviewed-by: Carl Ng <carl.ng@hp.com> > Signed-off-by: Max Nguyen <maxwell.nguyen@hp.com> > --- > V1 -> V2: Remove Xbox 360 vendor-specific class support. Thanks for making this change. I think it makes sense. I think if we want to have universal support for probing both Xbox 360 and Xbox One controller devices for a single vendorId in the xpad driver, the XPAD_XBOX360_VENDOR and XPAD_XBOXONE_VENDOR macros would be consolidated (one macro that instantiates support for both protocols). Since no HyperX controller for supporting Xbox 360 exists currently, I do not think it makes sense to introduce XPAD_XBOX360_VENDOR vendor-specific class matching for the HyperX vendorId in this patch (what v2 resolves). > > drivers/input/joystick/xpad.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c > index cdb193317c3b..1e377d040c43 100644 > --- a/drivers/input/joystick/xpad.c > +++ b/drivers/input/joystick/xpad.c > @@ -130,6 +130,7 @@ static const struct xpad_device { > { 0x0079, 0x18d4, "GPD Win 2 X-Box Controller", 0, XTYPE_XBOX360 }, > { 0x03eb, 0xff01, "Wooting One (Legacy)", 0, XTYPE_XBOX360 }, > { 0x03eb, 0xff02, "Wooting Two (Legacy)", 0, XTYPE_XBOX360 }, > + { 0x03f0, 0x0495, "HyperX Clutch Gladiate", 0, XTYPE_XBOXONE }, > { 0x044f, 0x0f00, "Thrustmaster Wheel", 0, XTYPE_XBOX }, > { 0x044f, 0x0f03, "Thrustmaster Wheel", 0, XTYPE_XBOX }, > { 0x044f, 0x0f07, "Thrustmaster, Inc. Controller", 0, XTYPE_XBOX }, > @@ -457,6 +458,7 @@ static const struct usb_device_id xpad_table[] = { > { USB_INTERFACE_INFO('X', 'B', 0) }, /* Xbox USB-IF not-approved class */ > XPAD_XBOX360_VENDOR(0x0079), /* GPD Win 2 controller */ > XPAD_XBOX360_VENDOR(0x03eb), /* Wooting Keyboards (Legacy) */ > + XPAD_XBOXONE_VENDOR(0x03f0), /* HP HyperX Xbox One controllers */ > XPAD_XBOX360_VENDOR(0x044f), /* Thrustmaster Xbox 360 controllers */ > XPAD_XBOX360_VENDOR(0x045e), /* Microsoft Xbox 360 controllers */ > XPAD_XBOXONE_VENDOR(0x045e), /* Microsoft Xbox One controllers */ Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Hi Rahul, Is there anything else we need to provide? When can we expect the patch to be rolled in?
On Fri, 04 Aug, 2023 13:19:26 -0700 HP Dev <hphyperxdev@gmail.com> wrote: > Hi Rahul, > Is there anything else we need to provide? From what I can tell, this patch looks good now to me. > When can we expect the patch to be rolled in? This is up to the subsystem maintainers to manage. In the case of the input subsystem, that would be Dmitry. Keep in mind the subsystem maintainers are busy and persevere to help look at patches. I am sure he will get to it in the future when he has a chance. It's also ok to resend the patch or the patch series after a couple of weeks with the word "RESEND" added to the subject line: https://docs.kernel.org/process/submitting-patches.html#don-t-get-discouraged-or-impatient If you need to do a RESEND for this patch after a couple weeks, feel free to add my Reviewed-by to the git trailer in your commit message. -- Thanks, Rahul Rameshbabu
diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c index cdb193317c3b..1e377d040c43 100644 --- a/drivers/input/joystick/xpad.c +++ b/drivers/input/joystick/xpad.c @@ -130,6 +130,7 @@ static const struct xpad_device { { 0x0079, 0x18d4, "GPD Win 2 X-Box Controller", 0, XTYPE_XBOX360 }, { 0x03eb, 0xff01, "Wooting One (Legacy)", 0, XTYPE_XBOX360 }, { 0x03eb, 0xff02, "Wooting Two (Legacy)", 0, XTYPE_XBOX360 }, + { 0x03f0, 0x0495, "HyperX Clutch Gladiate", 0, XTYPE_XBOXONE }, { 0x044f, 0x0f00, "Thrustmaster Wheel", 0, XTYPE_XBOX }, { 0x044f, 0x0f03, "Thrustmaster Wheel", 0, XTYPE_XBOX }, { 0x044f, 0x0f07, "Thrustmaster, Inc. Controller", 0, XTYPE_XBOX }, @@ -457,6 +458,7 @@ static const struct usb_device_id xpad_table[] = { { USB_INTERFACE_INFO('X', 'B', 0) }, /* Xbox USB-IF not-approved class */ XPAD_XBOX360_VENDOR(0x0079), /* GPD Win 2 controller */ XPAD_XBOX360_VENDOR(0x03eb), /* Wooting Keyboards (Legacy) */ + XPAD_XBOXONE_VENDOR(0x03f0), /* HP HyperX Xbox One controllers */ XPAD_XBOX360_VENDOR(0x044f), /* Thrustmaster Xbox 360 controllers */ XPAD_XBOX360_VENDOR(0x045e), /* Microsoft Xbox 360 controllers */ XPAD_XBOXONE_VENDOR(0x045e), /* Microsoft Xbox One controllers */