| Message ID | 20230809132249.37948-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [-next] scsi: libsas: Remove unused declarations | expand |
On 09/08/2023 14:22, Yue Haibing wrote: > Commit 042ebd293b86 ("scsi: libsas: kill useless ha_event and do some cleanup") > removed sas_hae_reset() but not its declaration. > Commit 2908d778ab3e ("[SCSI] aic94xx: new driver") declared but never implemented > other functions. > > Signed-off-by: Yue Haibing<yuehaibing@huawei.com> Reviewed-by: John Garry <john.g.garry@oracle.com>
On 2023/8/9 21:22, Yue Haibing wrote: > Commit 042ebd293b86 ("scsi: libsas: kill useless ha_event and do some cleanup") > removed sas_hae_reset() but not its declaration. > Commit 2908d778ab3e ("[SCSI] aic94xx: new driver") declared but never implemented > other functions. > > Signed-off-by: Yue Haibing<yuehaibing@huawei.com> > --- > drivers/scsi/libsas/sas_internal.h | 7 ------- > include/scsi/libsas.h | 2 -- > 2 files changed, 9 deletions(-) Reviewed-by: Jason Yan <yanaijie@huawei.com> .
Yue, > Commit 042ebd293b86 ("scsi: libsas: kill useless ha_event and do some > cleanup") removed sas_hae_reset() but not its declaration. Commit > 2908d778ab3e ("[SCSI] aic94xx: new driver") declared but never > implemented other functions. Applied to 6.6/scsi-staging, thanks!
On Wed, 09 Aug 2023 21:22:49 +0800, Yue Haibing wrote: > Commit 042ebd293b86 ("scsi: libsas: kill useless ha_event and do some cleanup") > removed sas_hae_reset() but not its declaration. > Commit 2908d778ab3e ("[SCSI] aic94xx: new driver") declared but never implemented > other functions. > > Applied to 6.6/scsi-queue, thanks! [1/1] scsi: libsas: Remove unused declarations https://git.kernel.org/mkp/scsi/c/2fcd1e2b648f
diff --git a/drivers/scsi/libsas/sas_internal.h b/drivers/scsi/libsas/sas_internal.h index 6f593fa69b58..a6dc7dc07fce 100644 --- a/drivers/scsi/libsas/sas_internal.h +++ b/drivers/scsi/libsas/sas_internal.h @@ -41,13 +41,7 @@ struct sas_phy_data { void sas_scsi_recover_host(struct Scsi_Host *shost); -int sas_show_class(enum sas_class class, char *buf); -int sas_show_proto(enum sas_protocol proto, char *buf); -int sas_show_linkrate(enum sas_linkrate linkrate, char *buf); -int sas_show_oob_mode(enum sas_oob_mode oob_mode, char *buf); - int sas_register_phys(struct sas_ha_struct *sas_ha); -void sas_unregister_phys(struct sas_ha_struct *sas_ha); struct asd_sas_event *sas_alloc_event(struct asd_sas_phy *phy, gfp_t gfp_flags); void sas_free_event(struct asd_sas_event *event); @@ -91,7 +85,6 @@ int sas_get_report_phy_sata(struct domain_device *dev, int phy_id, int sas_get_phy_attached_dev(struct domain_device *dev, int phy_id, u8 *sas_addr, enum sas_device_type *type); int sas_try_ata_reset(struct asd_sas_phy *phy); -void sas_hae_reset(struct work_struct *work); void sas_free_device(struct kref *kref); void sas_destruct_devices(struct asd_sas_port *port); diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h index 159823e0afbf..8557a0caf5fe 100644 --- a/include/scsi/libsas.h +++ b/include/scsi/libsas.h @@ -727,8 +727,6 @@ extern struct device_attribute dev_attr_phy_event_threshold; int sas_discover_root_expander(struct domain_device *); -void sas_init_ex_attr(void); - int sas_ex_revalidate_domain(struct domain_device *); void sas_unregister_domain_devices(struct asd_sas_port *port, int gone);
Commit 042ebd293b86 ("scsi: libsas: kill useless ha_event and do some cleanup") removed sas_hae_reset() but not its declaration. Commit 2908d778ab3e ("[SCSI] aic94xx: new driver") declared but never implemented other functions. Signed-off-by: Yue Haibing <yuehaibing@huawei.com> --- drivers/scsi/libsas/sas_internal.h | 7 ------- include/scsi/libsas.h | 2 -- 2 files changed, 9 deletions(-)