[BlueZ,v5,0/7] Add support for BAP broadcast sink

Message

Claudia Draghicescu Aug. 8, 2023, 11:50 a.m. UTC

This series of patches adds support for BAP broadcast sink.
It consists in registering a broadcastsink endpoint using the
Basic Audio Announcement Service UUID,
discovering of broadcast advertisers that announce the
Broadcast Audio Announcement Service, synchronizes to the Periodic
advertisements of the source and synchronizes to the BIG advertised
in the PA train.
To retrieve the BASE info advertised in the PA train, the patch
Bluetooth: ISO: Add support for periodic adv reports processing
was used.

This feature was tested using bluetoothctl with the following commands:

[bluetooth]# endpoint.register 00001851-0000-1000-8000-00805f9b34fb 0x06
[bluetooth]# scan on
[NEW] Endpoint /org/bluez/hci0/dev_XX_XX_XX_XX_XX_XX/pac_bcast0
[bluetooth]# endpoint.config
/org/bluez/hci0/dev_XX_XX_XX_XX_XX_XX/pac_bcast0
/local/endpoint/ep0 16_2_1

Claudia Draghicescu (7):
  client/player: Add broadcast sink endpoint
  btio: Add support for getsockopt(BT_ISO_BASE)
  adapter: Do not filter out broadcast advertiser
  profile: Add probe_on_discover flag
  bap: Add support for BAP broadcast sink
  media: Add broadcast sink media endpoint
  transport: Update transport properties for a broadcast stream

 btio/btio.c                |  13 +-
 client/player.c            |  61 ++++++-
 profiles/audio/bap.c       | 334 +++++++++++++++++++++++++++++++++----
 profiles/audio/media.c     |  82 +++++++--
 profiles/audio/media.h     |   3 +-
 profiles/audio/transport.c | 245 ++++++++++++++++++++++++++-
 src/adapter.c              |  10 ++
 src/device.c               |  22 ++-
 src/profile.h              |   5 +
 src/shared/bap.c           | 139 ++++++++++++---
 src/shared/bap.h           |   6 +-
 11 files changed, 831 insertions(+), 89 deletions(-)


base-commit: 59569c1f947d648f1e0b9234dad3707f6c34739b

Comments

[e-mail] Aug. 9, 2023, 5:20 p.m. UTC | #1

Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[e-mail]>:

On Tue,  8 Aug 2023 14:50:33 +0300 you wrote:
> This series of patches adds support for BAP broadcast sink.
> It consists in registering a broadcastsink endpoint using the
> Basic Audio Announcement Service UUID,
> discovering of broadcast advertisers that announce the
> Broadcast Audio Announcement Service, synchronizes to the Periodic
> advertisements of the source and synchronizes to the BIG advertised
> in the PA train.
> To retrieve the BASE info advertised in the PA train, the patch
> Bluetooth: ISO: Add support for periodic adv reports processing
> was used.
> 
> [...]

Here is the summary with links:
  - [BlueZ,v5,1/7] client/player: Add broadcast sink endpoint
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=4352a42ec1e2
  - [BlueZ,v5,2/7] btio: Add support for getsockopt(BT_ISO_BASE)
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=7b3aa05323f2
  - [BlueZ,v5,3/7] adapter: Do not filter out broadcast advertiser
    (no matching commit)
  - [BlueZ,v5,4/7] profile: Add probe_on_discover flag
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=67a26abe53bf
  - [BlueZ,v5,5/7] bap: Add support for BAP broadcast sink
    (no matching commit)
  - [BlueZ,v5,6/7] media: Add broadcast sink media endpoint
    (no matching commit)
  - [BlueZ,v5,7/7] transport: Update transport properties for a broadcast stream
    (no matching commit)

You are awesome, thank you!

Luiz Augusto von Dentz Aug. 15, 2023, 7:19 p.m. UTC | #2

Hi Claudia,

On Wed, Aug 9, 2023 at 10:40 AM <[e-mail]> wrote:
>
> Hello:
>
> This series was applied to bluetooth/bluez.git (master)
> by Luiz Augusto von Dentz <[e-mail]>:
>
> On Tue,  8 Aug 2023 14:50:33 +0300 you wrote:
> > This series of patches adds support for BAP broadcast sink.
> > It consists in registering a broadcastsink endpoint using the
> > Basic Audio Announcement Service UUID,
> > discovering of broadcast advertisers that announce the
> > Broadcast Audio Announcement Service, synchronizes to the Periodic
> > advertisements of the source and synchronizes to the BIG advertised
> > in the PA train.
> > To retrieve the BASE info advertised in the PA train, the patch
> > Bluetooth: ISO: Add support for periodic adv reports processing
> > was used.
> >
> > [...]
>
> Here is the summary with links:
>   - [BlueZ,v5,1/7] client/player: Add broadcast sink endpoint
>     https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=4352a42ec1e2
>   - [BlueZ,v5,2/7] btio: Add support for getsockopt(BT_ISO_BASE)
>     https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=7b3aa05323f2
>   - [BlueZ,v5,3/7] adapter: Do not filter out broadcast advertiser
>     (no matching commit)
>   - [BlueZ,v5,4/7] profile: Add probe_on_discover flag
>     https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=67a26abe53bf
>   - [BlueZ,v5,5/7] bap: Add support for BAP broadcast sink
>     (no matching commit)
>   - [BlueZ,v5,6/7] media: Add broadcast sink media endpoint
>     (no matching commit)
>   - [BlueZ,v5,7/7] transport: Update transport properties for a broadcast stream
>     (no matching commit)
>
> You are awesome, thank you!
> --
> Deet-doot-dot, I am a bot.
> https://korg.docs.kernel.org/patchwork/pwbot.html

Let me know if you need more feedback for this set, we do intend to
have a release soon, so I hope we can have the broadcast sink working
as well.