| Message ID | 20230809210248.2898981-4-stefanha@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | vfio: use __aligned_u64 for ioctl structs | expand |
> From: Stefan Hajnoczi <stefanha@redhat.com> > Sent: Thursday, August 10, 2023 5:03 AM > > @@ -1303,8 +1303,9 @@ struct vfio_iommu_type1_info { > __u32 flags; > #define VFIO_IOMMU_INFO_PGSIZES (1 << 0) /* supported page sizes info > */ > #define VFIO_IOMMU_INFO_CAPS (1 << 1) /* Info supports caps */ > - __u64 iova_pgsizes; /* Bitmap of supported page sizes */ > + __aligned_u64 iova_pgsizes; /* Bitmap of supported page > sizes */ > __u32 cap_offset; /* Offset within info struct of first cap */ > + __u32 reserved; isn't this conflicting with the new 'pad' field introduced in your another patch " [PATCH v3] vfio: align capability structures"? @@ -1304,6 +1305,7 @@ struct vfio_iommu_type1_info { #define VFIO_IOMMU_INFO_CAPS (1 << 1) /* Info supports caps */ __u64 iova_pgsizes; /* Bitmap of supported page sizes */ __u32 cap_offset; /* Offset within info struct of first cap */ + __u32 pad; };
On Thu, Aug 10, 2023 at 03:25:37AM +0000, Tian, Kevin wrote: > > From: Stefan Hajnoczi <stefanha@redhat.com> > > Sent: Thursday, August 10, 2023 5:03 AM > > > > @@ -1303,8 +1303,9 @@ struct vfio_iommu_type1_info { > > __u32 flags; > > #define VFIO_IOMMU_INFO_PGSIZES (1 << 0) /* supported page sizes info > > */ > > #define VFIO_IOMMU_INFO_CAPS (1 << 1) /* Info supports caps */ > > - __u64 iova_pgsizes; /* Bitmap of supported page sizes */ > > + __aligned_u64 iova_pgsizes; /* Bitmap of supported page > > sizes */ > > __u32 cap_offset; /* Offset within info struct of first cap */ > > + __u32 reserved; > > isn't this conflicting with the new 'pad' field introduced in your another > patch " [PATCH v3] vfio: align capability structures"? > > @@ -1304,6 +1305,7 @@ struct vfio_iommu_type1_info { > #define VFIO_IOMMU_INFO_CAPS (1 << 1) /* Info supports caps */ > __u64 iova_pgsizes; /* Bitmap of supported page sizes */ > __u32 cap_offset; /* Offset within info struct of first cap */ > + __u32 pad; > }; Yes, I will rebase this series when "[PATCH v3] vfio: align capability structures" is merged. I see the __aligned_u64 as a separate issue and don't want to combine the patch series. Stefan
On Wed, Aug 09, 2023 at 05:02:47PM -0400, Stefan Hajnoczi wrote: > The memory layout of struct vfio_iommu_type1_info is > architecture-dependent due to a u64 field and a struct size that is not > a multiple of 8 bytes: > - On x86_64 the struct size is padded to a multiple of 8 bytes. > - On x32 the struct size is only a multiple of 4 bytes, not 8. > - Other architectures may vary. > > Use __aligned_u64 to make memory layout consistent. This reduces the > chance of holes that result in an information leak and the chance that > 32-bit userspace on a 64-bit kernel breakage. > > This patch increases the struct size on x32 but this is safe because of > the struct's argsz field. The kernel may grow the struct as long as it > still supports smaller argsz values from userspace (e.g. applications > compiled against older kernel headers). > > Suggested-by: Jason Gunthorpe <jgg@ziepe.ca> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> > --- > include/uapi/linux/vfio.h | 3 ++- > drivers/vfio/vfio_iommu_type1.c | 11 ++--------- > 2 files changed, 4 insertions(+), 10 deletions(-) Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> Jason
diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h index 45db62d74064..0b5786ec50d8 100644 --- a/include/uapi/linux/vfio.h +++ b/include/uapi/linux/vfio.h @@ -1303,8 +1303,9 @@ struct vfio_iommu_type1_info { __u32 flags; #define VFIO_IOMMU_INFO_PGSIZES (1 << 0) /* supported page sizes info */ #define VFIO_IOMMU_INFO_CAPS (1 << 1) /* Info supports caps */ - __u64 iova_pgsizes; /* Bitmap of supported page sizes */ + __aligned_u64 iova_pgsizes; /* Bitmap of supported page sizes */ __u32 cap_offset; /* Offset within info struct of first cap */ + __u32 reserved; }; /* diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c index ebe0ad31d0b0..f51159a7a4de 100644 --- a/drivers/vfio/vfio_iommu_type1.c +++ b/drivers/vfio/vfio_iommu_type1.c @@ -2762,27 +2762,20 @@ static int vfio_iommu_dma_avail_build_caps(struct vfio_iommu *iommu, static int vfio_iommu_type1_get_info(struct vfio_iommu *iommu, unsigned long arg) { - struct vfio_iommu_type1_info info; + struct vfio_iommu_type1_info info = {}; unsigned long minsz; struct vfio_info_cap caps = { .buf = NULL, .size = 0 }; - unsigned long capsz; int ret; minsz = offsetofend(struct vfio_iommu_type1_info, iova_pgsizes); - /* For backward compatibility, cannot require this */ - capsz = offsetofend(struct vfio_iommu_type1_info, cap_offset); - if (copy_from_user(&info, (void __user *)arg, minsz)) return -EFAULT; if (info.argsz < minsz) return -EINVAL; - if (info.argsz >= capsz) { - minsz = capsz; - info.cap_offset = 0; /* output, no-recopy necessary */ - } + minsz = min_t(unsigned long, info.argsz, sizeof(info)); mutex_lock(&iommu->lock); info.flags = VFIO_IOMMU_INFO_PGSIZES;
The memory layout of struct vfio_iommu_type1_info is architecture-dependent due to a u64 field and a struct size that is not a multiple of 8 bytes: - On x86_64 the struct size is padded to a multiple of 8 bytes. - On x32 the struct size is only a multiple of 4 bytes, not 8. - Other architectures may vary. Use __aligned_u64 to make memory layout consistent. This reduces the chance of holes that result in an information leak and the chance that 32-bit userspace on a 64-bit kernel breakage. This patch increases the struct size on x32 but this is safe because of the struct's argsz field. The kernel may grow the struct as long as it still supports smaller argsz values from userspace (e.g. applications compiled against older kernel headers). Suggested-by: Jason Gunthorpe <jgg@ziepe.ca> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> --- include/uapi/linux/vfio.h | 3 ++- drivers/vfio/vfio_iommu_type1.c | 11 ++--------- 2 files changed, 4 insertions(+), 10 deletions(-)