| Message ID | 20230730121047.43115-1-david@ixit.cz (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: imx8mq-librem5-devkit: switch to vqmmc-supply | expand |
Hi, On Sun, Jul 30, 2023 at 03:10:46PM +0300, David Heidelberg wrote: > Resolves following warning: > arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: mmc@30b50000: Unevaluated properties are not allowed ('power-supply' was unexpected) > from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-esdhc.yaml# > > Cc: kernel@puri.sm > Cc: Guido Günther <agx@sigxcpu.org> > Signed-off-by: David Heidelberg <david@ixit.cz> > --- > arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > index b3549eae6278..a8b5da3ca08f 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > @@ -1031,7 +1031,7 @@ &usdhc2 { > pinctrl-2 = <&pinctrl_usdhc2_200mhz>; > bus-width = <4>; > vmmc-supply = <®_usdhc2_vmmc>; > - power-supply = <&wifi_pwr_en>; > + vqmmc-supply = <&wifi_pwr_en>; From the schematics WIFI_PWR_EN connects to the Wifi card's `W_DISABLE` so I don't think vqmmc is correct here. I wonder if there's a better way to model that in DT? Any suggestions would be welcome. Cheers, -- Guido > broken-cd; > disable-wp; > cap-sdio-irq; > -- > 2.40.1 >
Hello David, Hello Guido, On 31.07.23 13:32, Guido Günther wrote: > Hi, > On Sun, Jul 30, 2023 at 03:10:46PM +0300, David Heidelberg wrote: >> Resolves following warning: >> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: mmc@30b50000: Unevaluated properties are not allowed ('power-supply' was unexpected) >> from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-esdhc.yaml# >> >> Cc: kernel@puri.sm >> Cc: Guido Günther <agx@sigxcpu.org> >> Signed-off-by: David Heidelberg <david@ixit.cz> >> --- >> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts >> index b3549eae6278..a8b5da3ca08f 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts >> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts >> @@ -1031,7 +1031,7 @@ &usdhc2 { >> pinctrl-2 = <&pinctrl_usdhc2_200mhz>; >> bus-width = <4>; >> vmmc-supply = <®_usdhc2_vmmc>; >> - power-supply = <&wifi_pwr_en>; >> + vqmmc-supply = <&wifi_pwr_en>; > > From the schematics WIFI_PWR_EN connects to the Wifi card's `W_DISABLE` > so I don't think vqmmc is correct here. I wonder if there's a better way > to model that in DT? Any suggestions would be welcome. I think mmc-pwrseq is what you are after. Cheers, Ahmad > > Cheers, > -- Guido > >> broken-cd; >> disable-wp; >> cap-sdio-irq; >> -- >> 2.40.1 >> > >
On 31/07/2023 14:42, Ahmad Fatoum wrote: > Hello David, > Hello Guido, > > On 31.07.23 13:32, Guido Günther wrote: >> Hi, >> On Sun, Jul 30, 2023 at 03:10:46PM +0300, David Heidelberg wrote: >>> Resolves following warning: >>> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: mmc@30b50000: Unevaluated properties are not allowed ('power-supply' was unexpected) >>> from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-esdhc.yaml# >>> >>> Cc: kernel@puri.sm >>> Cc: Guido Günther <agx@sigxcpu.org> >>> Signed-off-by: David Heidelberg <david@ixit.cz> >>> --- >>> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts >>> index b3549eae6278..a8b5da3ca08f 100644 >>> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts >>> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts >>> @@ -1031,7 +1031,7 @@ &usdhc2 { >>> pinctrl-2 = <&pinctrl_usdhc2_200mhz>; >>> bus-width = <4>; >>> vmmc-supply = <®_usdhc2_vmmc>; >>> - power-supply = <&wifi_pwr_en>; >>> + vqmmc-supply = <&wifi_pwr_en>; >> From the schematics WIFI_PWR_EN connects to the Wifi card's `W_DISABLE` >> so I don't think vqmmc is correct here. I wonder if there's a better way >> to model that in DT? Any suggestions would be welcome. > I think mmc-pwrseq is what you are after. Guido sent patch to replace it with `mmc-pwrseq` in https://www.spinics.net/lists/kernel/msg4894084.html
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts index b3549eae6278..a8b5da3ca08f 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts @@ -1031,7 +1031,7 @@ &usdhc2 { pinctrl-2 = <&pinctrl_usdhc2_200mhz>; bus-width = <4>; vmmc-supply = <®_usdhc2_vmmc>; - power-supply = <&wifi_pwr_en>; + vqmmc-supply = <&wifi_pwr_en>; broken-cd; disable-wp; cap-sdio-irq;
Resolves following warning: arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: mmc@30b50000: Unevaluated properties are not allowed ('power-supply' was unexpected) from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-esdhc.yaml# Cc: kernel@puri.sm Cc: Guido Günther <agx@sigxcpu.org> Signed-off-by: David Heidelberg <david@ixit.cz> --- arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)