[v2,0/8] btrfs-progs: add encryption support

Message

Sweet Tea Dorminy Aug. 8, 2023, 5:22 p.m. UTC

This is the progs side of the encryption feature [1]. The first four
changes are attempts to replicate the relevant kernel changes precisely
to the equivalents in kernel-shared; the next four add support to check
and dump-tree.

[1] https://lore.kernel.org/linux-btrfs/[e-mail]/

Changelog:
v2:
- updated to match new extent context format

v1: 
- https://lore.kernel.org/linux-btrfs/[e-mail]/

Sweet Tea Dorminy (8):
  btrfs-progs: add new FEATURE_INCOMPAT_ENCRYPT flag
  btrfs-progs: start tracking extent encryption context info
  btrfs-progs: add inode encryption contexts
  btrfs-progs: save and load fscrypt extent contexts
  btrfs-progs: interpret encrypted file extents.
  btrfs-progs: handle fscrypt context items
  btrfs-progs: escape unprintable characters in names
  btrfs-progs: check: update inline extent length checking

 check/main.c                    | 29 ++++++++-------
 kernel-shared/accessors.h       |  2 ++
 kernel-shared/ctree.h           |  3 +-
 kernel-shared/fscrypt.h         | 25 +++++++++++++
 kernel-shared/print-tree.c      | 64 +++++++++++++++++++++++++++++++--
 kernel-shared/tree-checker.c    | 37 ++++++++++++++-----
 kernel-shared/uapi/btrfs.h      |  1 +
 kernel-shared/uapi/btrfs_tree.h | 16 ++++++++-
 8 files changed, 151 insertions(+), 26 deletions(-)
 create mode 100644 kernel-shared/fscrypt.h


base-commit: 9a7c1226664ab3145f7382ffeae80770bd2d8d3a

Comments

Josef Bacik Aug. 9, 2023, 8:41 p.m. UTC | #1

On Tue, Aug 08, 2023 at 01:22:19PM -0400, Sweet Tea Dorminy wrote:
> This is the progs side of the encryption feature [1]. The first four
> changes are attempts to replicate the relevant kernel changes precisely
> to the equivalents in kernel-shared; the next four add support to check
> and dump-tree.
> 
> [1] https://lore.kernel.org/linux-btrfs/[e-mail]/
> 

You can add

Reviewed-by: Josef Bacik <[e-mail]>

to the series.  Thanks,

Josef

Neal Gompa Aug. 10, 2023, 12:23 p.m. UTC | #2

On Tue, Aug 8, 2023 at 2:42 PM Sweet Tea Dorminy
<[e-mail]> wrote:
>
> This is the progs side of the encryption feature [1]. The first four
> changes are attempts to replicate the relevant kernel changes precisely
> to the equivalents in kernel-shared; the next four add support to check
> and dump-tree.
>
> [1] https://lore.kernel.org/linux-btrfs/[e-mail]/
>
> Changelog:
> v2:
> - updated to match new extent context format
>
> v1:
> - https://lore.kernel.org/linux-btrfs/[e-mail]/
>
> Sweet Tea Dorminy (8):
>   btrfs-progs: add new FEATURE_INCOMPAT_ENCRYPT flag
>   btrfs-progs: start tracking extent encryption context info
>   btrfs-progs: add inode encryption contexts
>   btrfs-progs: save and load fscrypt extent contexts
>   btrfs-progs: interpret encrypted file extents.
>   btrfs-progs: handle fscrypt context items
>   btrfs-progs: escape unprintable characters in names
>   btrfs-progs: check: update inline extent length checking
>
>  check/main.c                    | 29 ++++++++-------
>  kernel-shared/accessors.h       |  2 ++
>  kernel-shared/ctree.h           |  3 +-
>  kernel-shared/fscrypt.h         | 25 +++++++++++++
>  kernel-shared/print-tree.c      | 64 +++++++++++++++++++++++++++++++--
>  kernel-shared/tree-checker.c    | 37 ++++++++++++++-----
>  kernel-shared/uapi/btrfs.h      |  1 +
>  kernel-shared/uapi/btrfs_tree.h | 16 ++++++++-
>  8 files changed, 151 insertions(+), 26 deletions(-)
>  create mode 100644 kernel-shared/fscrypt.h
>
>
> base-commit: 9a7c1226664ab3145f7382ffeae80770bd2d8d3a
> --
> 2.41.0
>

This patch set series looks reasonable to me.

Reviewed-by: Neal Gompa <[e-mail]>