| Message ID | 20230810015117.3085574-1-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] usb: dwc3: dwc3-octeon: remove unnecessary platform_set_drvdata() | expand |
On Thu, Aug 10, 2023 at 09:51:17AM +0800, Yang Yingliang wrote: > Remove unnecessary platform_set_drvdata(..., NULL) in ->remove(), > the driver_data will be cleared in device_unbind_cleanup() after > calling ->remove() in driver call code. Isn't the same true also for dwc3-imx8mp, dwc3-keystone and dwc3-am62.c? > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > drivers/usb/dwc3/dwc3-octeon.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/usb/dwc3/dwc3-octeon.c b/drivers/usb/dwc3/dwc3-octeon.c > index 6b6581057345..356347780c15 100644 > --- a/drivers/usb/dwc3/dwc3-octeon.c > +++ b/drivers/usb/dwc3/dwc3-octeon.c > @@ -517,7 +517,6 @@ static void dwc3_octeon_remove(struct platform_device *pdev) > struct dwc3_octeon *octeon = platform_get_drvdata(pdev); > > of_platform_depopulate(octeon->dev); > - platform_set_drvdata(pdev, NULL); > } > > static const struct of_device_id dwc3_octeon_of_match[] = { > -- > 2.25.1
On 2023/8/10 17:46, Ladislav Michl wrote: > On Thu, Aug 10, 2023 at 09:51:17AM +0800, Yang Yingliang wrote: >> Remove unnecessary platform_set_drvdata(..., NULL) in ->remove(), >> the driver_data will be cleared in device_unbind_cleanup() after >> calling ->remove() in driver call code. > Isn't the same true also for dwc3-imx8mp, dwc3-keystone and dwc3-am62.c? Yes, I can squash them in one patch. Thanks, Yang > >> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> >> --- >> drivers/usb/dwc3/dwc3-octeon.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/usb/dwc3/dwc3-octeon.c b/drivers/usb/dwc3/dwc3-octeon.c >> index 6b6581057345..356347780c15 100644 >> --- a/drivers/usb/dwc3/dwc3-octeon.c >> +++ b/drivers/usb/dwc3/dwc3-octeon.c >> @@ -517,7 +517,6 @@ static void dwc3_octeon_remove(struct platform_device *pdev) >> struct dwc3_octeon *octeon = platform_get_drvdata(pdev); >> >> of_platform_depopulate(octeon->dev); >> - platform_set_drvdata(pdev, NULL); >> } >> >> static const struct of_device_id dwc3_octeon_of_match[] = { >> -- >> 2.25.1 > .
diff --git a/drivers/usb/dwc3/dwc3-octeon.c b/drivers/usb/dwc3/dwc3-octeon.c index 6b6581057345..356347780c15 100644 --- a/drivers/usb/dwc3/dwc3-octeon.c +++ b/drivers/usb/dwc3/dwc3-octeon.c @@ -517,7 +517,6 @@ static void dwc3_octeon_remove(struct platform_device *pdev) struct dwc3_octeon *octeon = platform_get_drvdata(pdev); of_platform_depopulate(octeon->dev); - platform_set_drvdata(pdev, NULL); } static const struct of_device_id dwc3_octeon_of_match[] = {
Remove unnecessary platform_set_drvdata(..., NULL) in ->remove(), the driver_data will be cleared in device_unbind_cleanup() after calling ->remove() in driver call code. Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/usb/dwc3/dwc3-octeon.c | 1 - 1 file changed, 1 deletion(-)