mbox series

[v8,0/9] TI-Nspire cleanups

Message ID 20230802153333.55546-1-afd@ti.com (mailing list archive)
Headers show
Series TI-Nspire cleanups | expand

Message

Andrew Davis Aug. 2, 2023, 3:33 p.m. UTC
Hello all,

This series is an extended version of the series started here[0]
and here[1].

We break out what was the first patch into one for DTS change and
one for code changes as suggested by Krzysztof. Those are now patches
1 and 8 of this series (I kept the ACKs, hope that is okay).

While I was adding that, I noticed some other dtbs_check issues,
so while here fixed some of those up too (patches 2-6).

Thanks,
Andrew

[0] https://lore.kernel.org/lkml/20221026161302.5319-1-afd@ti.com/
[1] https://lore.kernel.org/linux-arm-kernel/20221027181337.8651-1-afd@ti.com/

Changes from v7:
 - Rebase on latest with new dts dirs

Changes from v6:
 - Old first patch was taken, remove from series
 - Add new patch 7/9, should be trivial enough

Changes from v5:
 - Rebase on latest master
 - Fix DT binding comments from Rob and add ACK

Changes from v4:
 - Rebase on latest master

Changes from v3:
 - Add Reviewed-by
 - Make new binding for patch #1

Changes from v2:
 - See cover letter message

Changes from v1:
 - Add ACKs
 - Rebase on latest

Andrew Davis (9):
  ARM: dts: nspire: Use syscon-reboot to handle restart
  ARM: dts: nspire: Fix cpu node to conform with DT binding
  ARM: dts: nspire: Fix sram node to conform with DT binding
  ARM: dts: nspire: Fix vbus_reg node to conform with DT binding
  ARM: dts: nspire: Fix uart node to conform with DT binding
  ARM: dts: nspire: Use MATRIX_KEY macro for linux,keymap
  ARM: dts: nspire: Remove file name from the files themselves
  ARM: nspire: Use syscon-reboot to handle restart
  ARM: nspire: Remove unused header file mmio.h

 arch/arm/boot/dts/nspire/nspire-classic.dtsi |  2 -
 arch/arm/boot/dts/nspire/nspire-clp.dts      | 93 ++++++++++++++-----
 arch/arm/boot/dts/nspire/nspire-cx.dts       | 95 ++++++++++++++------
 arch/arm/boot/dts/nspire/nspire-tp.dts       | 93 ++++++++++++++-----
 arch/arm/boot/dts/nspire/nspire.dtsi         | 26 ++++--
 arch/arm/mach-nspire/Kconfig                 |  2 +
 arch/arm/mach-nspire/mmio.h                  | 16 ----
 arch/arm/mach-nspire/nspire.c                | 24 -----
 8 files changed, 231 insertions(+), 120 deletions(-)
 delete mode 100644 arch/arm/mach-nspire/mmio.h

Comments

Fabian Vogt Aug. 11, 2023, 3:13 p.m. UTC | #1
Hi,

Am Mittwoch, 2. August 2023, 17:33:24 CEST schrieb Andrew Davis:
> Hello all,
> 
> This series is an extended version of the series started here[0]
> and here[1].
> 
> We break out what was the first patch into one for DTS change and
> one for code changes as suggested by Krzysztof. Those are now patches
> 1 and 8 of this series (I kept the ACKs, hope that is okay).
> 
> While I was adding that, I noticed some other dtbs_check issues,
> so while here fixed some of those up too (patches 2-6).

Whole series applied on top of cacc6e22932f and confirmed to work:

Tested-by: Fabian Vogt <fabian@ritter-vogt.de>

Thanks,
Fabian

> Thanks,
> Andrew
> 
> [0] https://lore.kernel.org/lkml/20221026161302.5319-1-afd@ti.com/
> [1] https://lore.kernel.org/linux-arm-kernel/20221027181337.8651-1-afd@ti.com/
> 
> Changes from v7:
>  - Rebase on latest with new dts dirs
> 
> Changes from v6:
>  - Old first patch was taken, remove from series
>  - Add new patch 7/9, should be trivial enough
> 
> Changes from v5:
>  - Rebase on latest master
>  - Fix DT binding comments from Rob and add ACK
> 
> Changes from v4:
>  - Rebase on latest master
> 
> Changes from v3:
>  - Add Reviewed-by
>  - Make new binding for patch #1
> 
> Changes from v2:
>  - See cover letter message
> 
> Changes from v1:
>  - Add ACKs
>  - Rebase on latest
> 
> Andrew Davis (9):
>   ARM: dts: nspire: Use syscon-reboot to handle restart
>   ARM: dts: nspire: Fix cpu node to conform with DT binding
>   ARM: dts: nspire: Fix sram node to conform with DT binding
>   ARM: dts: nspire: Fix vbus_reg node to conform with DT binding
>   ARM: dts: nspire: Fix uart node to conform with DT binding
>   ARM: dts: nspire: Use MATRIX_KEY macro for linux,keymap
>   ARM: dts: nspire: Remove file name from the files themselves
>   ARM: nspire: Use syscon-reboot to handle restart
>   ARM: nspire: Remove unused header file mmio.h
> 
>  arch/arm/boot/dts/nspire/nspire-classic.dtsi |  2 -
>  arch/arm/boot/dts/nspire/nspire-clp.dts      | 93 ++++++++++++++-----
>  arch/arm/boot/dts/nspire/nspire-cx.dts       | 95 ++++++++++++++------
>  arch/arm/boot/dts/nspire/nspire-tp.dts       | 93 ++++++++++++++-----
>  arch/arm/boot/dts/nspire/nspire.dtsi         | 26 ++++--
>  arch/arm/mach-nspire/Kconfig                 |  2 +
>  arch/arm/mach-nspire/mmio.h                  | 16 ----
>  arch/arm/mach-nspire/nspire.c                | 24 -----
>  8 files changed, 231 insertions(+), 120 deletions(-)
>  delete mode 100644 arch/arm/mach-nspire/mmio.h
Arnd Bergmann Aug. 12, 2023, 9:53 a.m. UTC | #2
On Fri, Aug 11, 2023, at 17:13, Fabian Vogt wrote:
> Hi,
>
> Am Mittwoch, 2. August 2023, 17:33:24 CEST schrieb Andrew Davis:
>> Hello all,
>> 
>> This series is an extended version of the series started here[0]
>> and here[1].
>> 
>> We break out what was the first patch into one for DTS change and
>> one for code changes as suggested by Krzysztof. Those are now patches
>> 1 and 8 of this series (I kept the ACKs, hope that is okay).
>> 
>> While I was adding that, I noticed some other dtbs_check issues,
>> so while here fixed some of those up too (patches 2-6).
>
> Whole series applied on top of cacc6e22932f and confirmed to work:
>
> Tested-by: Fabian Vogt <fabian@ritter-vogt.de>

I've added all 9 patches to the soc tree now, the first seven
in the soc/dt branch, the other two in the soc/arm branch.

This does mean that the soc/arm branch has a minor regression
when tested by itself, as it won't be able to restart the
system, which is a regression we'd still get with old dtb
files, but I think this is acceptable here since it does not
impact normal operation, and there is a very small user base
that is affected by this.

Thanks,

       Arnd